You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/03/07 17:53:48 UTC
[GitHub] [libcloud] c-w opened a new pull request #1564: Enable auth to Cloudflare DNS via API Tokens
c-w opened a new pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564
## Enable auth to Cloudflare DNS via API Tokens
### Description
This pull request adds support to the Cloudflare DNS driver to authenticate via API Tokens ([see docs](https://api.cloudflare.com/#getting-started-requests)) in addition to the previous Global API Key authentication mechanism.
### Status
- done, ready for review
### Checklist
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] c-w commented on pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Posted by GitBox <gi...@apache.org>.
c-w commented on pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564#issuecomment-792332047
@Kami "Generate Code Coverage" failure in this pull request seems unrelated to the changes:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] c-w commented on a change in pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Posted by GitBox <gi...@apache.org>.
c-w commented on a change in pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564#discussion_r593818996
##########
File path: libcloud/dns/drivers/cloudflare.py
##########
@@ -146,27 +147,37 @@ def parse_error(self):
raise exception_class(**kwargs)
-class CloudFlareDNSConnection(ConnectionUserAndKey):
+class BaseDNSConnection:
Review comment:
Fixed in 1d209ed8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on a change in pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564#discussion_r593793990
##########
File path: libcloud/dns/drivers/cloudflare.py
##########
@@ -146,27 +147,37 @@ def parse_error(self):
raise exception_class(**kwargs)
-class CloudFlareDNSConnection(ConnectionUserAndKey):
+class BaseDNSConnection:
Review comment:
Minor style thing - we tend to explicitly inherit from object everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] c-w merged pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Posted by GitBox <gi...@apache.org>.
c-w merged pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] micafer commented on pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Posted by GitBox <gi...@apache.org>.
micafer commented on pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564#issuecomment-795089691
> @Kami "Generate Code Coverage" failure in this pull request seems unrelated to the changes:
>
> 
This error has been fixed in trunk, merge the changes and this tests will pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-io commented on pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564#issuecomment-798806666
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=h1) Report
> Merging [#1564](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=desc) (1d209ed) into [trunk](https://codecov.io/gh/apache/libcloud/commit/6bac7102df34305ea28e0ac9fe8bc08002f7ce92?el=desc) (6bac710) will **decrease** coverage by `0.00%`.
> The diff coverage is `85.00%`.
[](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1564 +/- ##
==========================================
- Coverage 83.00% 83.00% -0.01%
==========================================
Files 394 394
Lines 84943 84959 +16
Branches 9036 9037 +1
==========================================
+ Hits 70508 70521 +13
- Misses 11369 11372 +3
Partials 3066 3066
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/dns/drivers/cloudflare.py](https://codecov.io/gh/apache/libcloud/pull/1564/diff?src=pr&el=tree#diff-bGliY2xvdWQvZG5zL2RyaXZlcnMvY2xvdWRmbGFyZS5weQ==) | `91.18% <78.57%> (-0.98%)` | :arrow_down: |
| [libcloud/test/dns/test\_cloudflare.py](https://codecov.io/gh/apache/libcloud/pull/1564/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9kbnMvdGVzdF9jbG91ZGZsYXJlLnB5) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=footer). Last update [6bac710...1d209ed](https://codecov.io/gh/apache/libcloud/pull/1564?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org