You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/09 12:14:18 UTC
[PR] test(client): pin the unconfigured provider degradation [rocketmq-dashboard]
zjncs opened a new pull request, #5829:
URL: https://github.com/apache/rocketmq-dashboard/pull/5829
### What
`ClientProviderStub` is what answers client lookups when no real provider is configured. It had no test. This adds 3 tests.
### What is pinned
- **every lookup fails loudly with a 501** `BusinessException` and a stable message — rather than answering an empty list the UI would read as “no connections”.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean.
- Discriminating mutation: the status code changed from 501 to 500 (all three red).
- Restored: 3/3 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): pin the unconfigured provider degradation [rocketmq-dashboard]
Posted by "zjncs (via GitHub)" <gi...@apache.org>.
zjncs closed pull request #5829: test(client): pin the unconfigured provider degradation
URL: https://github.com/apache/rocketmq-dashboard/pull/5829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): pin the unconfigured provider degradation [rocketmq-dashboard]
Posted by "zjncs (via GitHub)" <gi...@apache.org>.
zjncs commented on PR #5829:
URL: https://github.com/apache/rocketmq-dashboard/pull/5829#issuecomment-6081465900
Closing this one myself: I missed that the existing `ProviderStubContractTest` already pins the 501 degradation contract for all three `ClientProviderStub` methods, so this PR only adds the message-text assertion on top of coverage that already exists upstream. Apologies for the noise - the other batch PRs are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org