You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/09/21 05:40:27 UTC
[GitHub] [hudi] yanghua opened a new pull request #2097: [MINOR] Add description to remind users that Hudis docker images have mounted the projects workspace
yanghua opened a new pull request #2097:
URL: https://github.com/apache/hudi/pull/2097
## What is the purpose of the pull request
*This pull request adds a description to remind users that Hudis docker images have mounted the projects workspace*
## Brief change log
- *Added a description*
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #2097: [MINOR] Add description to remind users that Hudis docker images have mounted the projects workspace
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #2097:
URL: https://github.com/apache/hudi/pull/2097#discussion_r492303063
##########
File path: docs/_docs/0_4_docker_demo.cn.md
##########
@@ -1106,6 +1106,9 @@ and compose scripts are carefully implemented so that they serve dual-purpose
2. For running integration-tests, we need the jars generated locally to be used for running services within docker. The
docker-compose scripts (see `docker/compose/docker-compose_hadoop284_hive233_spark231.yml`) ensures local jars override
inbuilt jars by mounting local HUDI workspace over the docker location
+3. Due to the docker images have mounted local HUDI workspace, so any changes happen in the workspace would reflect into the
Review comment:
Reword To : "As these docker containers have mounted local HUDI workspace, any changes that happen in the workspace would automatically reflect in the containers. This is a convenient way for developing and verifying Hudi for
developers who do not own a distributed environment. Note that this is how integration tests are run."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #2097: [MINOR] Add description to remind users that Hudis docker images have mounted the projects workspace
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #2097:
URL: https://github.com/apache/hudi/pull/2097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #2097: [MINOR] Add description to remind users that Hudis docker images have mounted the projects workspace
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #2097:
URL: https://github.com/apache/hudi/pull/2097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #2097: [MINOR] Add description to remind users that Hudis docker images have mounted the projects workspace
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #2097:
URL: https://github.com/apache/hudi/pull/2097#discussion_r492303063
##########
File path: docs/_docs/0_4_docker_demo.cn.md
##########
@@ -1106,6 +1106,9 @@ and compose scripts are carefully implemented so that they serve dual-purpose
2. For running integration-tests, we need the jars generated locally to be used for running services within docker. The
docker-compose scripts (see `docker/compose/docker-compose_hadoop284_hive233_spark231.yml`) ensures local jars override
inbuilt jars by mounting local HUDI workspace over the docker location
+3. Due to the docker images have mounted local HUDI workspace, so any changes happen in the workspace would reflect into the
Review comment:
Reword To : "As these docker containers have mounted local HUDI workspace, any changes that happen in the workspace would automatically reflect in the containers. This is a convenient way for developing and verifying Hudi for
developers who do not own a distributed environment. Note that this is how integration tests are run."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #2097: [MINOR] Add description to remind users that Hudis docker images have mounted the projects workspace
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #2097:
URL: https://github.com/apache/hudi/pull/2097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org