[jira] [Commented] (RYA-323) Enable Multi Var Geo Functions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RYA-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100715#comment-16100715 ] 

ASF GitHub Bot commented on RYA-323:
------------------------------------

GitHub user amihalik opened a pull request:

    https://github.com/apache/incubator-rya/pull/183

    RYA-323 Enabling Multi Var Geo Functions. Closes #183

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    >What Changed?
    [Brief Description of what changed]
    
    ### Tests
    >Coverage?
    
    [Description of what tests were written]
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-323)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Reivew
    @meiercaleb 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amihalik/incubator-rya GEO-MULTI-VAR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit 80d98670873bbe422f3cefaec27752d2bbd3cd89
Author: Aaron Mihalik <mi...@alum.mit.edu>
Date:   2017-07-25T17:43:03Z

    RYA-323 Enabling Multi Var Geo Functions. Closes #183

----


> Enable Multi Var Geo Functions
> ------------------------------
>
>                 Key: RYA-323
>                 URL: https://issues.apache.org/jira/browse/RYA-323
>             Project: Rya
>          Issue Type: Improvement
>          Components: sail
>            Reporter: Aaron Mihalik
>            Assignee: Aaron Mihalik
>
> Currently, all Rya GeoSPARQL functions must have at least one parameter as a constant, eg:
> {code}
>   ?point geo:asWKT ?wkt .
>   FILTER(geof:sfWithin(?wkt, "POLYGON(( ... ))"^^geo:wktLiteral)) 
> {code}
> however, there is no good reason for this.  In fact, we will later want to support functions that take in two variables.  For instance, a previous set of statement patterns will resolve a wkt, then I want to pass that wkt value into the function, eg:
> {code}
>   <myEntity> <hasLocation> ?point .
>   ?point geo:asWKT ?wkt1 .
>   ?point geo:asWKT ?wkt2 .
>   FILTER(geof:near(?wkt2, ?wkt1)) 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)