[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit
URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r373738425
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
 ##########
 @@ -526,6 +526,19 @@ public abstract MergeSpecification findForcedMerges(
   public abstract MergeSpecification findForcedDeletesMerges(
       SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException;
 
+  /**
+   * Identifies merges that we want to execute (synchronously) on commit. By default, do not synchronously merge on commit.
+   *
+   * Implementers of this method should use isMergingSegment to exclude any already-merging segments from the returned
+   * {@link MergeSpecification}. If a segment already registered in a merge is returned, then the commit will fail.
 
 Review comment:
   OK I agree to explosive failure!  Less trappy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org