You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/08/31 01:16:36 UTC
Review Request 13921: Fixed a bug in reconciliation that failed to account
for unknown executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13921/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-673
https://issues.apache.org/jira/browse/MESOS-673
Repository: mesos-git
Description
-------
See MESOS-673.
Diffs
-----
src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54
Diff: https://reviews.apache.org/r/13921/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 13921: Fixed a bug in reconciliation that failed to
account for unknown executors.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13921/#review25875
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Sept. 4, 2013, 1:42 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13921/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 1:42 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-673
> https://issues.apache.org/jira/browse/MESOS-673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-673.
>
>
> Diffs
> -----
>
> src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
> src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54
>
> Diff: https://reviews.apache.org/r/13921/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13921: Fixed a bug in reconciliation that failed to
account for unknown executors.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13921/
-----------------------------------------------------------
(Updated Sept. 4, 2013, 1:42 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review.
Bugs: MESOS-673
https://issues.apache.org/jira/browse/MESOS-673
Repository: mesos-git
Description
-------
See MESOS-673.
Diffs (updated)
-----
src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54
Diff: https://reviews.apache.org/r/13921/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 13921: Fixed a bug in reconciliation that failed to
account for unknown executors.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13921/#review25813
-----------------------------------------------------------
Ship it!
Did a quick test in our staging cluster, looks good.
- Brenden Matthews
On Aug. 30, 2013, 11:16 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13921/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2013, 11:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-673
> https://issues.apache.org/jira/browse/MESOS-673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-673.
>
>
> Diffs
> -----
>
> src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
> src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54
>
> Diff: https://reviews.apache.org/r/13921/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13921: Fixed a bug in reconciliation that failed to
account for unknown executors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13921/#review25814
-----------------------------------------------------------
Ship it!
Thanks for fixing this.
Too bad we don't have a test for this. The reason we didn't catch this earlier even though we added resource accounting checks in all our slave recovery tests is because we use command executors :( Command executors neither use resources nor are known to the master. I think its time we implemented a test executor that could be actually launched. I'm going to create a ticket for it.
src/master/master.hpp
<https://reviews.apache.org/r/13921/#comment50352>
s/reconcileTasks/reconcile/
now that we are doing both tasks and executors.
src/master/master.cpp
<https://reviews.apache.org/r/13921/#comment50353>
s/must// ?
- Vinod Kone
On Aug. 30, 2013, 11:16 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13921/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2013, 11:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-673
> https://issues.apache.org/jira/browse/MESOS-673
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-673.
>
>
> Diffs
> -----
>
> src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976
> src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54
>
> Diff: https://reviews.apache.org/r/13921/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>