You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/08/20 19:32:40 UTC

[kudu-CR] [hms] use IPv4 for mini HMS 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11276


Change subject: [hms] use IPv4 for mini HMS
......................................................................

[hms] use IPv4 for mini HMS

This patch explictly uses IPv4 protocal in the JVM environment options
that pass to the mini HMS, to avoid IPv6 being accidentally used, which
is not support in Hadoop/Hive yet.

Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11276/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG@10
PS1, Line 10: that pass to the mini HMS, to avoid IPv6 being accidentally used. Since
> Makes sense. Could you add some of this into the commit message?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 00:23:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG@10
PS1, Line 10: that pass to the mini HMS, to avoid IPv6 being accidentally used, which
> Our HMS-based tests are all passing today, so what was the issue with using
Hadoop does not support IPv4 yet, here is the wiki page reference: https://wiki.apache.org/hadoop/HadoopIPv6 and the jira to support it: https://issues.apache.org/jira/browse/HADOOP-11890?subTaskView=all.

I think our current HMS-based tests are passing today because the Hadoop distribution we are using has the HADOOP_OPTS set with '-Djava.net.preferIPv4Stack=true'. But in case it is not, issues will occur.


http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG@11
PS1, Line 11: support
> supported
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 23:34:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG@9
PS4, Line 9: protocol
> protocol
Done


http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG@10
PS4, Line 10: y used,
> ", because"
Done


http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG@10
PS4, Line 10: are 
> are passed
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:44:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11276

to look at the new patch set (#2).

Change subject: [hms] use IPv4 for mini HMS
......................................................................

[hms] use IPv4 for mini HMS

This patch explictly uses IPv4 protocal in the JVM environment options
that pass to the mini HMS, to avoid IPv6 being accidentally used, which
is not supported in Hadoop/Hive yet.

Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11276/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:51:31 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11276

to look at the new patch set (#4).

Change subject: [hms] use IPv4 for mini HMS
......................................................................

[hms] use IPv4 for mini HMS

This patch explictly uses IPv4 protocal in the JVM environment options
that pass to the mini HMS, to avoid IPv6 being accidentally used. Since
IPv6 is not supported in Hadoop yet (https://wiki.apache.org/hadoop/HadoopIPv6).

Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11276/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11276

to look at the new patch set (#3).

Change subject: [hms] use IPv4 for mini HMS
......................................................................

[hms] use IPv4 for mini HMS

This patch explictly uses IPv4 protocal in the JVM environment options
that pass to the mini HMS, to avoid IPv6 being accidentally used. Since
IPv6 is not supported in Hadoop yet (wiki.apache.org/hadoop/HadoopIPv6).

Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11276/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11276

to look at the new patch set (#5).

Change subject: [hms] use IPv4 for mini HMS
......................................................................

[hms] use IPv4 for mini HMS

This patch explictly uses IPv4 protocol in the JVM environment options
that are passed to the mini HMS, to avoid IPv6 being accidentally used,
because IPv6 is not supported in Hadoop yet (https://wiki.apache.org/hadoop/HadoopIPv6).

Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11276/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG@10
PS1, Line 10: that pass to the mini HMS, to avoid IPv6 being accidentally used, which
Our HMS-based tests are all passing today, so what was the issue with using IPv6?


http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG@11
PS1, Line 11: support
supported



-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 19:44:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 21:22:50 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG@9
PS4, Line 9: protocal
protocol


http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG@10
PS4, Line 10: pass
are passed


http://gerrit.cloudera.org:8080/#/c/11276/4//COMMIT_MSG@10
PS4, Line 10: . Since
", because"



-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 04:07:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11276/1//COMMIT_MSG@10
PS1, Line 10: that pass to the mini HMS, to avoid IPv6 being accidentally used, which
> Hadoop does not support IPv4 yet, here is the wiki page reference: https://
Makes sense. Could you add some of this into the commit message?



-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 23:44:45 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] use IPv4 for mini HMS

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11276 )

Change subject: [hms] use IPv4 for mini HMS
......................................................................

[hms] use IPv4 for mini HMS

This patch explictly uses IPv4 protocol in the JVM environment options
that are passed to the mini HMS, to avoid IPv6 being accidentally used,
because IPv6 is not supported in Hadoop yet (https://wiki.apache.org/hadoop/HadoopIPv6).

Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Reviewed-on: http://gerrit.cloudera.org:8080/11276
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ceeccb45f3cdd13ccdc5ed77e0675ae5442f808
Gerrit-Change-Number: 11276
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins