You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 2001/03/01 00:08:42 UTC

Re: [PATCH] why is this missing from ap_getline()?

apr_bucket_delete() does a REMOVE and a destroy.


On Wed, Feb 28, 2001 at 05:46:58PM -0500, Jeff Trawick wrote:
> What am I missing?  It looks to me that APR_BUCKET_REMOVE() is
> critical here.  I must be confused.
> 
> Index: server/protocol.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/server/protocol.c,v
> retrieving revision 1.2
> diff -u -r1.2 protocol.c
> --- server/protocol.c	2001/02/28 15:13:30	1.2
> +++ server/protocol.c	2001/02/28 22:46:29
> @@ -526,6 +526,7 @@
>          }
>          e = APR_BRIGADE_FIRST(b); 
>          if (e->length == 0) {
> +            APR_BUCKET_REMOVE(e);
>              apr_bucket_delete(e);
>              continue;
>          }
> 
> 
> -- 
> Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...

-- 
Greg Stein, http://www.lyra.org/