You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/09/28 09:20:41 UTC
[GitHub] [incubator-celeborn] cxzl25 opened a new pull request, #1946: [CELEBORN-313] Add rest endpoint to show master group info
cxzl25 opened a new pull request, #1946:
URL: https://github.com/apache/incubator-celeborn/pull/1946
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
```bash
./bin/celeborn-ratis sh -Draft.rpc.type=NETTY group info -peers clb-1:9872,clb-2:9873,clb-3:9874
```
```
group id: c5196f6d-2c34-3ed3-8b8a-47bede733167
leader info: 1(clb-1:9872)
[server {
id: "1"
address: "clb-1:9872"
clientAddress: "clb-1:9097"
startupRole: FOLLOWER
}
commitIndex: 316
, server {
id: "2"
address: "clb-2:9873"
clientAddress: "clb-2:9098"
startupRole: FOLLOWER
}
commitIndex: 316
, server {
id: "3"
address: "clb-3:9874"
clientAddress: "clb-3:9099"
startupRole: FOLLOWER
}
commitIndex: 316
]
```
```bash
curl http://clb-3:9983/masterGroupInfo
```
```
====================== Master Group INFO ==============================
group id: c5196f6d-2c34-3ed3-8b8a-47bede733167
leader info: 1(clb-1:9872)
[server {
id: "3"
address: "clb-3:9874"
clientAddress: "clb-3:9099"
startupRole: FOLLOWER
}
commitIndex: 316
, server {
id: "1"
address: "clb-1:9872"
clientAddress: "clb-1:9097"
startupRole: FOLLOWER
}
commitIndex: 316
, server {
id: "2"
address: "clb-2:9873"
clientAddress: "clb-2:9098"
startupRole: FOLLOWER
}
commitIndex: 316
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1946: [CELEBORN-313] Add rest endpoint to show master group info
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1946:
URL: https://github.com/apache/incubator-celeborn/pull/1946#issuecomment-1738806341
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1946](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1946?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eba3530) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/ef4fc51d5f2d9d1a707e06cac2c64f3a07082e42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ef4fc51) will **decrease** coverage by `0.00%`.
> Report is 1 commits behind head on main.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 46.37% 46.37% -0.00%
==========================================
Files 164 164
Lines 10341 10340 -1
Branches 953 954 +1
==========================================
- Hits 4795 4794 -1
+ Misses 5230 5229 -1
- Partials 316 317 +1
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/celeborn/server/common/HttpService.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vSHR0cFNlcnZpY2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...leborn/server/common/http/HttpRequestHandler.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2NlbGVib3JuL3NlcnZlci9jb21tb24vaHR0cC9IdHRwUmVxdWVzdEhhbmRsZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1946/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1946: [CELEBORN-313] Add rest endpoint to show master group info
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1946:
URL: https://github.com/apache/incubator-celeborn/pull/1946#issuecomment-1739019093
Merged to main for 0.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cxzl25 commented on a diff in pull request #1946: [CELEBORN-313] Add rest endpoint to show master group info
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1946:
URL: https://github.com/apache/incubator-celeborn/pull/1946#discussion_r1340003261
##########
docs/monitoring.md:
##########
@@ -291,6 +291,7 @@ API path listed as below:
|-----------------------|-------------------------------------------------------------------------------------------------------------|
| /metrics/prometheus | List the metrics data in prometheus format of the master. |
| /conf | List the conf setting of the master. |
+| /masterGroupInfo | List master group information of the service. It will list all master's LEADER, FOLLOWER information. |
Review Comment:
```properties
celeborn.master.ha.enabled false
```
```bash
curl http://clb-3:9983/masterGroupInfo
```
```
====================== Master Group INFO ==============================
HA is not enabled
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1946: [CELEBORN-313] Add rest endpoint to show master group info
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1946:
URL: https://github.com/apache/incubator-celeborn/pull/1946#discussion_r1339948250
##########
docs/monitoring.md:
##########
@@ -291,6 +291,7 @@ API path listed as below:
|-----------------------|-------------------------------------------------------------------------------------------------------------|
| /metrics/prometheus | List the metrics data in prometheus format of the master. |
| /conf | List the conf setting of the master. |
+| /masterGroupInfo | List master group information of the service. It will list all master's LEADER, FOLLOWER information. |
Review Comment:
what if master ha is disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1946: [CELEBORN-313] Add rest endpoint to show master group info
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1946: [CELEBORN-313] Add rest endpoint to show master group info
URL: https://github.com/apache/incubator-celeborn/pull/1946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org