You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/07 02:29:37 UTC

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1648: feature: support to enable HTTPS for admin API

moonming commented on a change in pull request #1648:
URL: https://github.com/apache/incubator-apisix/pull/1648#discussion_r436317905



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -72,3 +72,47 @@ done
 
 sed -i '/dns_resolver:/,+4s/^#//'  conf/config.yaml
 echo "passed: system nameserver imported"
+

Review comment:
       I think we should add test cases in `t/admin/`.
   like https://github.com/apache/incubator-apisix/blob/master/t/admin/stream-routes-disable.t#L37 to change `config.yaml`, and call https request like https://github.com/apache/incubator-apisix/blob/master/t/plugin/redirect.t#L608




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org