You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/11 07:23:57 UTC
[GitHub] [doris] Jibing-Li opened a new pull request, #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Jibing-Li opened a new pull request, #14992:
URL: https://github.com/apache/doris/pull/14992
# Proposed changes
Issue Number: close #xxx
## Problem summary
Some cases of convert_to_doris_type are missing break, cause convert to wrong type.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14992:
URL: https://github.com/apache/doris/pull/14992#issuecomment-1347619141
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14992:
URL: https://github.com/apache/doris/pull/14992#issuecomment-1345481760
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.52 seconds
load time: 448 seconds
storage size: 17123356910 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221211074538_clickbench_pr_61529.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14992:
URL: https://github.com/apache/doris/pull/14992#issuecomment-1345478857
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14992:
URL: https://github.com/apache/doris/pull/14992#issuecomment-1347619116
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #14992:
URL: https://github.com/apache/doris/pull/14992#issuecomment-1347773443
Please add regression test in your next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #14992: [fix](multi catalog)Fix convert_to_doris_type missing break for some cases.
Posted by GitBox <gi...@apache.org>.
morningman merged PR #14992:
URL: https://github.com/apache/doris/pull/14992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org