You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/23 15:18:33 UTC

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #2002: buildAckCommand taskInstanceId not set modify

codecov-io edited a comment on issue #2002: buildAckCommand taskInstanceId not set modify
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2002#issuecomment-590076997
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=h1) Report
   > Merging [#2002](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=desc) into [refactor-worker](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/91d3495b770d6d1916342d0c14d6579358de2113?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=tree)
   
   ```diff
   @@                  Coverage Diff                  @@
   ##             refactor-worker    #2002      +/-   ##
   =====================================================
   + Coverage              29.33%   29.33%   +<.01%     
   - Complexity              1367     1368       +1     
   =====================================================
     Files                    314      314              
     Lines                  15489    15492       +3     
     Branches                1842     1842              
   =====================================================
   + Hits                    4543     4545       +2     
   - Misses                 10495    10497       +2     
   + Partials                 451      450       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...uler/server/master/processor/TaskAckProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvVGFza0Fja1Byb2Nlc3Nvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...server/master/processor/TaskResponseProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvVGFza1Jlc3BvbnNlUHJvY2Vzc29yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...master/dispatch/executor/NettyExecutorManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9leGVjdXRvci9OZXR0eUV4ZWN1dG9yTWFuYWdlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: |
   | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `100% <0%> (+8.69%)` | `8% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=footer). Last update [91d3495...7e27310](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services