You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/02 11:45:26 UTC
[GitHub] [incubator-eventmesh] weihubeats opened a new pull request, #2420: [Enhancement] Method throws alternative exception from catch block without history [ZipkinConfiguration]
weihubeats opened a new pull request, #2420:
URL: https://github.com/apache/incubator-eventmesh/pull/2420
Fixes https://github.com/apache/incubator-eventmesh/issues/2242
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #2420: [Enhancement] Method throws alternative exception from catch block without history [ZipkinConfiguration]
Posted by GitBox <gi...@apache.org>.
jonyangx merged PR #2420:
URL: https://github.com/apache/incubator-eventmesh/pull/2420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2420: [Enhancement] Method throws alternative exception from catch block without history [ZipkinConfiguration]
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2420:
URL: https://github.com/apache/incubator-eventmesh/pull/2420#issuecomment-1335152296
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2420](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e3e922) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/b03b29589457f4cbec10eab7457978e12add753f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b03b295) will **increase** coverage by `0.00%`.
> The diff coverage is `89.47%`.
> :exclamation: Current head 6e3e922 differs from pull request most recent head c399d6c. Consider uploading reports for the commit c399d6c to get more accurate results
```diff
@@ Coverage Diff @@
## master #2420 +/- ##
=========================================
Coverage 11.75% 11.75%
Complexity 899 899
=========================================
Files 473 473
Lines 27856 27851 -5
Branches 3000 2992 -8
=========================================
Hits 3275 3275
+ Misses 24286 24283 -3
+ Partials 295 293 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/core/protocol/grpc/producer/ProducerManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9kdWNlci9Qcm9kdWNlck1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tmesh/trace/zipkin/config/ZipkinConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2Utemlwa2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2Uvemlwa2luL2NvbmZpZy9aaXBraW5Db25maWd1cmF0aW9uLmphdmE=) | `75.00% <0.00%> (ø)` | |
| [...esh/runtime/admin/handler/AbstractHttpHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvQWJzdHJhY3RIdHRwSGFuZGxlci5qYXZh) | `66.66% <66.66%> (ø)` | |
| [...ntime/admin/controller/ClientManageController.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2NvbnRyb2xsZXIvQ2xpZW50TWFuYWdlQ29udHJvbGxlci5qYXZh) | `96.96% <95.45%> (ø)` | |
| [...h/runtime/admin/controller/HttpHandlerManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2NvbnRyb2xsZXIvSHR0cEhhbmRsZXJNYW5hZ2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...time/admin/handler/DeleteWebHookConfigHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvRGVsZXRlV2ViSG9va0NvbmZpZ0hhbmRsZXIuamF2YQ==) | `26.66% <100.00%> (ø)` | |
| [...time/admin/handler/InsertWebHookConfigHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvSW5zZXJ0V2ViSG9va0NvbmZpZ0hhbmRsZXIuamF2YQ==) | `26.66% <100.00%> (ø)` | |
| [.../admin/handler/QueryRecommendEventMeshHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlSZWNvbW1lbmRFdmVudE1lc2hIYW5kbGVyLmphdmE=) | `92.59% <100.00%> (ø)` | |
| [...e/admin/handler/QueryWebHookConfigByIdHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlXZWJIb29rQ29uZmlnQnlJZEhhbmRsZXIuamF2YQ==) | `26.66% <100.00%> (ø)` | |
| [...ndler/QueryWebHookConfigByManufacturerHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlXZWJIb29rQ29uZmlnQnlNYW51ZmFjdHVyZXJIYW5kbGVyLmphdmE=) | `22.22% <100.00%> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2420/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org