You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "nkuprins (via GitHub)" <gi...@apache.org> on 2026/08/27 19:52:51 UTC
[PR] fix: copy sheet-level read params to sheet holder [fesod]
nkuprins opened a new pull request, #1052:
URL: https://github.com/apache/fesod/pull/1052
Closed: #1051
## Purpose of the pull request
`ReadSheet.copyBasicParameter` copied 12 of the 15 read parameters - `locale`, `useScientificFormat` and `filedCacheLocation` were missing, so a value set after `.sheet(...)` was dropped and the workbook-level value was silently applied instead
## What's changed?
This adds the three missing copies, so all three now behave like `autoTrim`, `autoStrip`, `use1904windowing` and `headRowNumber`, which were already copied.
## Checklist
- [x] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/).
- [x] I have written the necessary doc or comment.
- [ ] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] fix: copy sheet-level read params to sheet holder [fesod]
Posted by "delei (via GitHub)" <gi...@apache.org>.
delei merged PR #1052:
URL: https://github.com/apache/fesod/pull/1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org