[GitHub] mrutkows edited a comment on issue #1016: Whisk Client Refactor including Platform Agnostic Home Dir location

[GitBox <gi...@apache.org>]

mrutkows edited a comment on issue #1016: Whisk Client Refactor including Platform Agnostic Home Dir location
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1016#issuecomment-442942954
 
 
   @pritidesai 
   In regard to the $HOME/~/UserProfile directory … after having slept on the issue, we may need to replicate what CLI has done in wskdeploy… basically I am wrestling with the issue that the go-client (all clients actually) should likely be agnostic of where they are run (OS/platform) … that info should be injected/provided by surrounding tooling (even if it means, for now CLI and wskdeploy must have duplicate/similar code). If indeed the go-client needs to still have some odd way of providing defaults (not injected by tool using it) then it should also use same lib as an import (edited).
   
   **With this in mind, both CLI and wskdeploy SHOULD use the same lib., (i.e, the [https://github.com/mitchellh/go-homedir](https://github.com/mitchellh/go-homedir)) and set default value to include '~' which the lib. will Expand() based upon OS.**
   
   I would think that the design should be that any IDE or app using REST directly should instantiate the go-client (or any client) with the values it needs for the target provider in general
   that is just good OO design...
   
   IMO, am 99% sure at least wskdeploy should use the same method CLI is using for consistency at least at our “layer” of tooling… and wskdeploy likely should adopt the ENV_ variable as well
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services