You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/01 22:04:00 UTC

[jira] [Work logged] (GOBBLIN-933) JsonRecordAvroSchemaToAvroConverter does not handle arrays of unions

     [ https://issues.apache.org/jira/browse/GOBBLIN-933?focusedWorklogId=337581&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337581 ]

ASF GitHub Bot logged work on GOBBLIN-933:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/19 22:03
            Start Date: 01/Nov/19 22:03
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on pull request #2792: [GOBBLIN-933] add support for array of unions in json schema
URL: https://github.com/apache/incubator-gobblin/pull/2792
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @zxcware  please review
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-933
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   It handles unions inside an array.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   enhanced a test case
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 337581)
    Remaining Estimate: 0h
            Time Spent: 10m

> JsonRecordAvroSchemaToAvroConverter does not handle arrays of unions
> --------------------------------------------------------------------
>
>                 Key: GOBBLIN-933
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-933
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Ahmed Abdul Hamid
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Using {{JsonRecordAvroSchemaToAvroConverter}} to convert an array of a union type fails. For instance, using it with the following Avro schema:
> {code:java}
> {
>   "name": "arrayField",
>   "type": {
>     "type": "array",
>     "items": ["string", "null"]
>   }
> } {code}
> yields the following error:
> {code:java}
> java.lang.StackOverflowError
> 	at org.apache.gobblin.configuration.State.getProp(State.java)
> 	at org.apache.gobblin.configuration.WorkUnitState.getProp(WorkUnitState.java:333)
> 	at org.apache.gobblin.converter.avro.JsonElementConversionFactory.getConvertor(JsonElementConversionFactory.java:106)
> 	at org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.getConverter(JsonElementConversionFactory.java:737)
> 	at org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.<init>(JsonElementConversionFactory.java:729)
> 	at org.apache.gobblin.converter.avro.JsonElementConversionFactory.getConvertor(JsonElementConversionFactory.java:160)
> 	at org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.getConverter(JsonElementConversionFactory.java:737)
> 	at org.apache.gobblin.converter.avro.JsonElementConversionFactory$UnionConverter.<init>(JsonElementConversionFactory.java:729)
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)