You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/04 18:08:24 UTC

[GitHub] [beam] chadrik commented on a change in pull request #11038: [BEAM-7746] More typing fixes

chadrik commented on a change in pull request #11038:
URL: https://github.com/apache/beam/pull/11038#discussion_r419627186



##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1300,12 +1300,13 @@ def to_runner_api_parameter(self, context):
           common_urns.requirements.REQUIRES_STATEFUL_PROCESSING.urn)
     from apache_beam.runners.common import DoFnSignature
     sig = DoFnSignature(self.fn)
-    is_splittable = sig.is_splittable_dofn()

Review comment:
       > It is an error to say is_splittable_dofn is True without returning a restriction coder as well and vice versa.
   
   This seems to validate my earlier assessment that a None result from this `get_restriction_coder` means "is not splittable", and therefore that my proposed change is valid.  
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org