You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/08 07:08:33 UTC
[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new issue #2925: [BUG] There is no exitVal judge in OSUtils.exeCmd function
yangyichao-mango opened a new issue #2925:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2925
**Describe the bug**
There is no exitVal judge in OSUtils.exeCmd function. So when I run cmd in this function in MacOS and this cmd fail, there is no log or exception thrown.
**To Reproduce**
Steps to reproduce the behavior, for example:
1.Make sure `sudo sysadminctl -addUser 1 -password 1` will produce error when you execute in your shell.
1. Run OSUtils.exeCmd with `sudo sysadminctl -addUser 1 -password 1` params.
2. Judge the `p.waitFor()`'s result, it will be `1` that means failed.
**Expected behavior**
Judge the `p.waitFor()`'s result, it will be `1` that means failed.
**Screenshots**
**Which version of Dolphin Scheduler:**
-[dev]
**Requirement or improvement
- Judge the result of `Process.waitFor()`
- Remove the exeCmd from OSUtils, and use the `ShellExecutor.execCommand(command)` function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #2925: [BUG] There is no exitVal judge in OSUtils.exeCmd function
Posted by GitBox <gi...@apache.org>.
dailidong closed issue #2925:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #2925: [BUG] There is no exitVal judge in OSUtils.exeCmd function
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #2925:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2925#issuecomment-643735900
> good job
>
> could you submit a PR to solve this problem? I think it's not difficult, you can try. if you meet problems, please leave message
Hi @dailidong @gabrywu . I've commit the PR for this issue. Can you help to review this PR? Thx a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2925: [BUG] There is no exitVal judge in OSUtils.exeCmd function
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2925:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2925#issuecomment-643202638
good job
could you submit a PR to solve this problem? I think it's not difficult, you can try. if you meet problems, please leave message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #2925: [BUG] There is no exitVal judge in OSUtils.exeCmd function
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #2925:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2925#issuecomment-643284233
> good job
>
>
>
> could you submit a PR to solve this problem? I think it's not difficult, you can try. if you meet problems, please leave message
I will do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org