You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2023/05/22 03:35:56 UTC
[GitHub] [druid] abhishekrb19 opened a new pull request, #14323: Return `RESOURCES` in `EXPLAIN PLAN` as an ordered collection
abhishekrb19 opened a new pull request, #14323:
URL: https://github.com/apache/druid/pull/14323
The `EXPLAIN PLAN` output includes a `RESOURCES` column that contains a collection of resources used in the query as a string. Previously the resources would be an unordered collection, where the ordering wasn't deterministic. This change makes them ordered (by name), thereby deterministic by changing from `Set` to a `List` and adding a `sorted` operation to the stream operations.
- Added a new unit test to demonstrate the ordering that would change based on different test runs.
- Cleaned up some unit tests
- Fixed the EXPLAIN PLAN docs stuff
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] amaechler commented on a diff in pull request #14323: Return `RESOURCES` in `EXPLAIN PLAN` as an ordered collection
Posted by "amaechler (via GitHub)" <gi...@apache.org>.
amaechler commented on code in PR #14323:
URL: https://github.com/apache/druid/pull/14323#discussion_r1200609576
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/QueryHandler.java:
##########
Review Comment:
Since you're in here, I noticed that the `ObjectNode#put` calls around line 437 are deprecated and could be replaced with `set` for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #14323: Return `RESOURCES` in `EXPLAIN PLAN` as an ordered collection
Posted by "jon-wei (via GitHub)" <gi...@apache.org>.
jon-wei merged PR #14323:
URL: https://github.com/apache/druid/pull/14323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekrb19 commented on a diff in pull request #14323: Return `RESOURCES` in `EXPLAIN PLAN` as an ordered collection
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on code in PR #14323:
URL: https://github.com/apache/druid/pull/14323#discussion_r1200701740
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/QueryHandler.java:
##########
Review Comment:
Yep, thanks, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org