You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Mike Edwards (JIRA)" <de...@tuscany.apache.org> on 2010/07/22 15:36:59 UTC

[jira] Created: (TUSCANY-3629) Tuscany does not handle cases where component @source attribute references a multi-valued composite property

Tuscany does not handle cases where component <property> @source attribute references a multi-valued composite property
-----------------------------------------------------------------------------------------------------------------------

                 Key: TUSCANY-3629
                 URL: https://issues.apache.org/jira/browse/TUSCANY-3629
             Project: Tuscany
          Issue Type: Bug
          Components: Java SCA Assembly Model
    Affects Versions: Java-SCA-2.0-M5
            Reporter: Mike Edwards
             Fix For: Java-SCA-2.0


Creation of OASIS SCA Assembly testcases ASM_5043 and ASM_5044 revealed some limitations in the Tuscany handling of <property> @source attributes which reference a <composite> <property> that is multi-valued.

Basically there are 2 items:

1) The Tuscany code will only ever retrieve a single value even if both properties are multi-valued (this is simply a bug)
2) These testcases introduce some clarifications to the syntax for @source referencing sub-portions of a multi-valued property (this is an enchancement to what is in Tuscany now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TUSCANY-3629) Tuscany does not handle cases where component @source attribute references a multi-valued composite property

Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891157#action_12891157 ] 

Mike Edwards commented on TUSCANY-3629:
---------------------------------------

Possible values for the @source string value are:
 a) $name
 b) $name/expression
 c) $name[xx]
 d) $name[xx]/expression

c) and d) are clarifications. 
The [xx] is typically meant to be used with a number e.g. [1] 
- this means "choose the 1st value element of the multi-valued property"

...but the XPath meaning is more general and could be extended to [@foo="bar"]
- meaning "choose all value elements of the property which have @foo attribute with the value "bar"

For any of a), b) c) and d), the expression COULD result in multiple values being returned - all returned values should be placed into the property containing the @source attribute - this may result in an error if the property is actually single valued - but in that case, go fix the composite, since it is clearly wrong.

> Tuscany does not handle cases where component <property> @source attribute references a multi-valued composite property
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3629
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3629
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>    Affects Versions: Java-SCA-2.0-M5
>            Reporter: Mike Edwards
>             Fix For: Java-SCA-2.0
>
>
> Creation of OASIS SCA Assembly testcases ASM_5043 and ASM_5044 revealed some limitations in the Tuscany handling of <property> @source attributes which reference a <composite> <property> that is multi-valued.
> Basically there are 2 items:
> 1) The Tuscany code will only ever retrieve a single value even if both properties are multi-valued (this is simply a bug)
> 2) These testcases introduce some clarifications to the syntax for @source referencing sub-portions of a multi-valued property (this is an enchancement to what is in Tuscany now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TUSCANY-3629) Tuscany does not handle cases where component @source attribute references a multi-valued composite property

Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Edwards resolved TUSCANY-3629.
-----------------------------------

    Resolution: Fixed

Testcases ASM_5043 & ASM_5044 now running clean

> Tuscany does not handle cases where component <property> @source attribute references a multi-valued composite property
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3629
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3629
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>    Affects Versions: Java-SCA-2.0-M5
>            Reporter: Mike Edwards
>             Fix For: Java-SCA-2.0
>
>
> Creation of OASIS SCA Assembly testcases ASM_5043 and ASM_5044 revealed some limitations in the Tuscany handling of <property> @source attributes which reference a <composite> <property> that is multi-valued.
> Basically there are 2 items:
> 1) The Tuscany code will only ever retrieve a single value even if both properties are multi-valued (this is simply a bug)
> 2) These testcases introduce some clarifications to the syntax for @source referencing sub-portions of a multi-valued property (this is an enchancement to what is in Tuscany now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TUSCANY-3629) Tuscany does not handle cases where component @source attribute references a multi-valued composite property

Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Edwards closed TUSCANY-3629.
---------------------------------


Closing resolved issues

> Tuscany does not handle cases where component <property> @source attribute references a multi-valued composite property
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3629
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3629
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>    Affects Versions: Java-SCA-2.0-M5
>            Reporter: Mike Edwards
>             Fix For: Java-SCA-2.0
>
>
> Creation of OASIS SCA Assembly testcases ASM_5043 and ASM_5044 revealed some limitations in the Tuscany handling of <property> @source attributes which reference a <composite> <property> that is multi-valued.
> Basically there are 2 items:
> 1) The Tuscany code will only ever retrieve a single value even if both properties are multi-valued (this is simply a bug)
> 2) These testcases introduce some clarifications to the syntax for @source referencing sub-portions of a multi-valued property (this is an enchancement to what is in Tuscany now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TUSCANY-3629) Tuscany does not handle cases where component @source attribute references a multi-valued composite property

Posted by "Mike Edwards (JIRA)" <de...@tuscany.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891160#action_12891160 ] 

Mike Edwards commented on TUSCANY-3629:
---------------------------------------

Change to CompositeProcessor.java in 966650

- this deals with the generation of the XPathExpression object from the @source string

Change to ComponentBuilderImpl.java in 966653

- this deals with the execution of the XPathExpression against the target composite property object and the setting of the result value into the component property

A significant change here is that the new code sets up the XPathExpression to operate against the root <property/> element where the value(s) are stored - this permits a scan across all the subelements, if there are multiple present.  Previously the XPath was structured to operate against the first <value/> subelement.



> Tuscany does not handle cases where component <property> @source attribute references a multi-valued composite property
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3629
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3629
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Assembly Model
>    Affects Versions: Java-SCA-2.0-M5
>            Reporter: Mike Edwards
>             Fix For: Java-SCA-2.0
>
>
> Creation of OASIS SCA Assembly testcases ASM_5043 and ASM_5044 revealed some limitations in the Tuscany handling of <property> @source attributes which reference a <composite> <property> that is multi-valued.
> Basically there are 2 items:
> 1) The Tuscany code will only ever retrieve a single value even if both properties are multi-valued (this is simply a bug)
> 2) These testcases introduce some clarifications to the syntax for @source referencing sub-portions of a multi-valued property (this is an enchancement to what is in Tuscany now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.