You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/08/15 15:48:25 UTC
[GitHub] storm pull request #2278: Quick fix: remove duplicated IStormClusterState ob...
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2278
Quick fix: remove duplicated IStormClusterState object in ReadClusterState.java
It seems to me that `private final IStormClusterState clusterState;` is a dup of ` private final IStormClusterState stormClusterState;`. So I removed `clusterState`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm DUPS-IN-ReadClusterState-CLASS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2278
----
commit f18330f3836dc481e13a21df2781eaf44856be30
Author: Ethan Li <et...@gmail.com>
Date: 2017-08-15T15:43:51Z
Quick fix: remove duplicated IStormClusterState object in ReadClusterState.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2278: Quick fix: remove duplicated IStormClusterState object in...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2278
+1 Nice finding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2278: Quick fix: remove duplicated IStormClusterState object in...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2278
Thanks @Ethanlm, I merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2278: Quick fix: remove duplicated IStormClusterState ob...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---