You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "masaori335 (via GitHub)" <gi...@apache.org> on 2023/10/02 03:19:57 UTC

[GitHub] [trafficserver] masaori335 opened a new pull request, #10551: Make NextHopConsistentHash unit test stable

masaori335 opened a new pull request, #10551:
URL: https://github.com/apache/trafficserver/pull/10551

   Fix #10296.
   
   The unit tests of Next Hop is using `parent_retry_time = 1`. In some cases, like enabling ASan, this makes down hosts retryable due to execution takes time. To make these tests stable, making current time in the past (1 second).
   
   https://github.com/apache/trafficserver/blob/561d1f79a4015bf86ed6301f627a0f7fbe5f63d1/proxy/http/remap/unit-tests/nexthop_test_stubs.cc#L120
   
   
   ## Log
   
   ```
   next_hop NextHopConsistentHash.cc:309:findNextHop() [30007] firstcall, line_number: -1, result: PARENT_UNDEFINED
   next_hop NextHopConsistentHash.cc:415:findNextHop() [30007] next hop c2.foo.com is now retryable ///< this host should not retryable
   next_hop NextHopConsistentHash.cc:453:findNextHop() [30007] Initial parent lookups: 1
   next_hop NextHopConsistentHash.cc:494:findNextHop() [30007] result->result: PARENT_SPECIFIED Chosen parent: c2.foo.com.80
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make NextHopConsistentHash unit test stable [trafficserver]

Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #10551:
URL: https://github.com/apache/trafficserver/pull/10551#issuecomment-1764901720

   Cherry-picked to v9.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make NextHopConsistentHash unit test stable [trafficserver]

Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 merged PR #10551:
URL: https://github.com/apache/trafficserver/pull/10551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org