You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2010/12/30 21:13:54 UTC
svn commit: r1053996 [1/2] - in /subversion/trunk/subversion: include/
include/private/ libsvn_client/ libsvn_diff/ libsvn_fs_base/
libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_neon/ libsvn_ra_serf/
libsvn_ra_svn/ libsvn_subr/ libsvn_wc/ mod_authz_svn/ ...
Author: danielsh
Date: Thu Dec 30 20:13:50 2010
New Revision: 1053996
URL: http://svn.apache.org/viewvc?rev=1053996&view=rev
Log:
Once and for all, name all our anonymous struct/enum typedefs.
Follows up on r1040058, and with thanks to Danny Trebbien.
* everywhere:
Change 'typedef struct {} foo_t;' to 'typedef struct foo_t {} foo_t;'.
* subversion/libsvn_ra_serf/fake_sspi.h
(PSecurityFunctionTable, SecurityFunctionTable):
Manually effect the same change in the single pointer-to-struct typedef.
Modified:
subversion/trunk/subversion/include/private/svn_token.h
subversion/trunk/subversion/include/svn_checksum.h
subversion/trunk/subversion/include/svn_editor.h
subversion/trunk/subversion/include/svn_fs.h
subversion/trunk/subversion/include/svn_mergeinfo.h
subversion/trunk/subversion/include/svn_repos.h
subversion/trunk/subversion/include/svn_types.h
subversion/trunk/subversion/libsvn_client/add.c
subversion/trunk/subversion/libsvn_client/client.h
subversion/trunk/subversion/libsvn_client/copy.c
subversion/trunk/subversion/libsvn_client/log.c
subversion/trunk/subversion/libsvn_client/merge.c
subversion/trunk/subversion/libsvn_client/patch.c
subversion/trunk/subversion/libsvn_client/ra.c
subversion/trunk/subversion/libsvn_diff/diff_file.c
subversion/trunk/subversion/libsvn_diff/diff_memory.c
subversion/trunk/subversion/libsvn_fs_base/bdb/env.c
subversion/trunk/subversion/libsvn_fs_base/bdb/env.h
subversion/trunk/subversion/libsvn_fs_base/fs.h
subversion/trunk/subversion/libsvn_fs_base/id.c
subversion/trunk/subversion/libsvn_fs_base/tree.c
subversion/trunk/subversion/libsvn_fs_fs/id.c
subversion/trunk/subversion/libsvn_fs_fs/lock.c
subversion/trunk/subversion/libsvn_fs_fs/tree.c
subversion/trunk/subversion/libsvn_ra_neon/commit.c
subversion/trunk/subversion/libsvn_ra_neon/fetch.c
subversion/trunk/subversion/libsvn_ra_neon/get_dated_rev.c
subversion/trunk/subversion/libsvn_ra_neon/get_deleted_rev.c
subversion/trunk/subversion/libsvn_ra_neon/get_location_segments.c
subversion/trunk/subversion/libsvn_ra_neon/get_locations.c
subversion/trunk/subversion/libsvn_ra_neon/get_locks.c
subversion/trunk/subversion/libsvn_ra_neon/lock.c
subversion/trunk/subversion/libsvn_ra_neon/merge.c
subversion/trunk/subversion/libsvn_ra_neon/options.c
subversion/trunk/subversion/libsvn_ra_neon/props.c
subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h
subversion/trunk/subversion/libsvn_ra_neon/replay.c
subversion/trunk/subversion/libsvn_ra_neon/util.c
subversion/trunk/subversion/libsvn_ra_serf/auth.c
subversion/trunk/subversion/libsvn_ra_serf/auth_digest.h
subversion/trunk/subversion/libsvn_ra_serf/auth_kerb.c
subversion/trunk/subversion/libsvn_ra_serf/blame.c
subversion/trunk/subversion/libsvn_ra_serf/commit.c
subversion/trunk/subversion/libsvn_ra_serf/fake_sspi.h
subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c
subversion/trunk/subversion/libsvn_ra_serf/getdate.c
subversion/trunk/subversion/libsvn_ra_serf/getlocations.c
subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c
subversion/trunk/subversion/libsvn_ra_serf/getlocks.c
subversion/trunk/subversion/libsvn_ra_serf/locks.c
subversion/trunk/subversion/libsvn_ra_serf/log.c
subversion/trunk/subversion/libsvn_ra_serf/merge.c
subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c
subversion/trunk/subversion/libsvn_ra_serf/options.c
subversion/trunk/subversion/libsvn_ra_serf/property.c
subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h
subversion/trunk/subversion/libsvn_ra_serf/replay.c
subversion/trunk/subversion/libsvn_ra_serf/update.c
subversion/trunk/subversion/libsvn_ra_serf/win32_auth_sspi.h
subversion/trunk/subversion/libsvn_ra_svn/client.c
subversion/trunk/subversion/libsvn_ra_svn/editorp.c
subversion/trunk/subversion/libsvn_ra_svn/streams.c
subversion/trunk/subversion/libsvn_subr/auth.c
subversion/trunk/subversion/libsvn_subr/cache-inprocess.c
subversion/trunk/subversion/libsvn_subr/cache-memcache.c
subversion/trunk/subversion/libsvn_subr/cache.h
subversion/trunk/subversion/libsvn_subr/date.c
subversion/trunk/subversion/libsvn_subr/dirent_uri.c
subversion/trunk/subversion/libsvn_subr/error.c
subversion/trunk/subversion/libsvn_subr/mergeinfo.c
subversion/trunk/subversion/libsvn_subr/simple_providers.c
subversion/trunk/subversion/libsvn_subr/ssl_client_cert_providers.c
subversion/trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c
subversion/trunk/subversion/libsvn_subr/ssl_server_trust_providers.c
subversion/trunk/subversion/libsvn_subr/subst.c
subversion/trunk/subversion/libsvn_subr/username_providers.c
subversion/trunk/subversion/libsvn_subr/win32_crashrpt.c
subversion/trunk/subversion/libsvn_wc/adm_ops.c
subversion/trunk/subversion/libsvn_wc/entries.c
subversion/trunk/subversion/libsvn_wc/wc_db.c
subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c
subversion/trunk/subversion/mod_dav_svn/dav_svn.h
subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
subversion/trunk/subversion/mod_dav_svn/reports/replay.c
subversion/trunk/subversion/mod_dav_svn/reports/update.c
subversion/trunk/subversion/mod_dav_svn/repos.c
subversion/trunk/subversion/svn/blame-cmd.c
subversion/trunk/subversion/svn/cl.h
subversion/trunk/subversion/svn/main.c
subversion/trunk/subversion/svn/proplist-cmd.c
subversion/trunk/subversion/svnserve/serve.c
subversion/trunk/subversion/svnsync/main.c
subversion/trunk/subversion/svnsync/sync.c
subversion/trunk/subversion/tests/libsvn_client/client-test.c
subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c
Modified: subversion/trunk/subversion/include/private/svn_token.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_token.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_token.h (original)
+++ subversion/trunk/subversion/include/private/svn_token.h Thu Dec 30 20:13:50 2010
@@ -36,7 +36,7 @@ extern "C" {
*
* Maps are an array of these, terminated with a struct where STR == NULL.
*/
-typedef struct
+typedef struct svn_token_map_t
{
const char *str;
int val;
Modified: subversion/trunk/subversion/include/svn_checksum.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_checksum.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_checksum.h (original)
+++ subversion/trunk/subversion/include/svn_checksum.h Thu Dec 30 20:13:50 2010
@@ -42,7 +42,7 @@ extern "C" {
*
* @since New in 1.6.
*/
-typedef enum
+typedef enum svn_checksum_kind_t
{
/** The checksum is (or should be set to) an MD5 checksum. */
svn_checksum_md5,
Modified: subversion/trunk/subversion/include/svn_editor.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_editor.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_editor.h (original)
+++ subversion/trunk/subversion/include/svn_editor.h Thu Dec 30 20:13:50 2010
@@ -640,7 +640,7 @@ svn_editor_setcb_abort(svn_editor_t *edi
* @see svn_editor_setcb_many(), svn_editor_create(), svn_editor_t.
* @since New in 1.7.
*/
-typedef struct
+typedef struct svn_editor_cb_many_t
{
svn_editor_cb_add_directory_t cb_add_directory;
svn_editor_cb_add_file_t cb_add_file;
Modified: subversion/trunk/subversion/include/svn_fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_fs.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_fs.h (original)
+++ subversion/trunk/subversion/include/svn_fs.h Thu Dec 30 20:13:50 2010
@@ -1061,7 +1061,7 @@ svn_fs_revision_root_revision(svn_fs_roo
/** The kind of change that occurred on the path. */
-typedef enum
+typedef enum svn_fs_path_change_kind_t
{
/** path modified in txn */
svn_fs_path_change_modify = 0,
@@ -2222,7 +2222,7 @@ svn_fs_print_modules(svn_stringbuf_t *ou
/** The kind of action being taken by 'pack'. */
-typedef enum
+typedef enum svn_fs_pack_notify_action_t
{
/** packing of the shard has commenced */
svn_fs_pack_notify_start = 0,
Modified: subversion/trunk/subversion/include/svn_mergeinfo.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_mergeinfo.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_mergeinfo.h (original)
+++ subversion/trunk/subversion/include/svn_mergeinfo.h Thu Dec 30 20:13:50 2010
@@ -507,7 +507,7 @@ svn_rangelist_dup(const apr_array_header
*
* @since New in 1.5.
*/
-typedef enum
+typedef enum svn_mergeinfo_inheritance_t
{
/** Explicit mergeinfo only. */
svn_mergeinfo_explicit,
Modified: subversion/trunk/subversion/include/svn_repos.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_repos.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_repos.h (original)
+++ subversion/trunk/subversion/include/svn_repos.h Thu Dec 30 20:13:50 2010
@@ -107,7 +107,7 @@ typedef svn_error_t *(*svn_repos_authz_f
*
* @since New in 1.3.
*/
-typedef enum
+typedef enum svn_repos_authz_access_t
{
/** No access. */
svn_authz_none = 0,
@@ -2972,7 +2972,7 @@ svn_repos_authz_check_access(svn_authz_t
*
* @since New in 1.5.
*/
-typedef enum
+typedef enum svn_repos_revision_access_level_t
{
svn_repos_revision_access_none,
svn_repos_revision_access_partial,
Modified: subversion/trunk/subversion/include/svn_types.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_types.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_types.h (original)
+++ subversion/trunk/subversion/include/svn_types.h Thu Dec 30 20:13:50 2010
@@ -169,7 +169,7 @@ svn__apr_hash_index_val(const apr_hash_i
/** @} */
/** The various types of nodes in the Subversion filesystem. */
-typedef enum
+typedef enum svn_node_kind_t
{
/** absent */
svn_node_none,
@@ -211,7 +211,7 @@ svn_node_kind_from_word(const char *word
* not a valid value.
*
* @since New in 1.7. */
-typedef enum
+typedef enum svn_tristate_t
{
svn_tristate_false = 2,
svn_tristate_true,
@@ -364,7 +364,7 @@ enum svn_recurse_kind
*
* @since New in 1.5.
*/
-typedef enum
+typedef enum svn_depth_t
{
/* The order of these depths is important: the higher the number,
the deeper it descends. This allows us to compare two depths
Modified: subversion/trunk/subversion/libsvn_client/add.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/add.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/add.c (original)
+++ subversion/trunk/subversion/libsvn_client/add.c Thu Dec 30 20:13:50 2010
@@ -57,7 +57,7 @@
/* This structure is used as baton for enumerating the config entries
in the auto-props section.
*/
-typedef struct
+typedef struct auto_props_baton_t
{
/* the file name for which properties are searched */
const char *filename;
Modified: subversion/trunk/subversion/libsvn_client/client.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/client.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/client.h (original)
+++ subversion/trunk/subversion/libsvn_client/client.h Thu Dec 30 20:13:50 2010
@@ -502,7 +502,7 @@ svn_client__update_internal(svn_revnum_t
This structure is used by svn_client__checkout_internal() to save
one or more round-trips if the client already gathered some of this
information. Not all the fields need to be filled in. */
-typedef struct
+typedef struct svn_client__ra_session_from_path_results
{
/* The repository root URL. A NULL value means the root URL is
unknown.*/
@@ -688,7 +688,7 @@ svn_client__get_diff_summarize_editor(co
various helper functions may need. Not every copy function uses every
field.
*/
-typedef struct
+typedef struct svn_client__copy_pair_t
{
/* The absolute source path or url. */
const char *src_abspath_or_url;
Modified: subversion/trunk/subversion/libsvn_client/copy.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/copy.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/copy.c (original)
+++ subversion/trunk/subversion/libsvn_client/copy.c Thu Dec 30 20:13:50 2010
@@ -513,7 +513,7 @@ verify_wc_srcs_and_dsts(const apr_array_
/* Path-specific state used as part of path_driver_cb_baton. */
-typedef struct
+typedef struct path_driver_info_t
{
const char *src_url;
const char *src_path;
Modified: subversion/trunk/subversion/libsvn_client/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/log.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/log.c (original)
+++ subversion/trunk/subversion/libsvn_client/log.c Thu Dec 30 20:13:50 2010
@@ -45,7 +45,7 @@
/*** Getting misc. information ***/
/* The baton for use with copyfrom_info_receiver(). */
-typedef struct
+typedef struct copyfrom_info_t
{
svn_boolean_t is_first;
const char *path;
@@ -148,7 +148,7 @@ svn_client__get_copy_source(const char *
/* compatibility with pre-1.5 servers, which send only author/date/log
*revprops in log entries */
-typedef struct
+typedef struct pre_15_receiver_baton_t
{
svn_client_ctx_t *ctx;
/* ra session for retrieving revprops from old servers */
@@ -244,7 +244,7 @@ pre_15_receiver(void *baton, svn_log_ent
}
/* limit receiver */
-typedef struct
+typedef struct limit_receiver_baton_t
{
int limit;
svn_log_entry_receiver_t receiver;
Modified: subversion/trunk/subversion/libsvn_client/merge.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/merge.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/merge.c (original)
+++ subversion/trunk/subversion/libsvn_client/merge.c Thu Dec 30 20:13:50 2010
@@ -1213,7 +1213,7 @@ merge_props_changed(const char *local_di
}
/* Contains any state collected while resolving conflicts. */
-typedef struct
+typedef struct conflict_resolver_baton_t
{
/* The wrapped callback and baton. */
svn_wc_conflict_resolver_func_t wrapped_func;
@@ -2591,7 +2591,7 @@ merge_callbacks =
/* Contains any state collected while receiving path notifications. */
-typedef struct
+typedef struct notification_receiver_baton_t
{
/* The wrapped callback and baton. */
svn_wc_notify_func2_t wrapped_func;
Modified: subversion/trunk/subversion/libsvn_client/patch.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/patch.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/patch.c (original)
+++ subversion/trunk/subversion/libsvn_client/patch.c Thu Dec 30 20:13:50 2010
@@ -2603,7 +2603,7 @@ delete_empty_dirs(apr_array_header_t *ta
}
/* Baton for apply_patches(). */
-typedef struct {
+typedef struct apply_patches_baton_t {
/* The path to the patch file. */
const char *patch_abspath;
Modified: subversion/trunk/subversion/libsvn_client/ra.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/ra.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/ra.c (original)
+++ subversion/trunk/subversion/libsvn_client/ra.c Thu Dec 30 20:13:50 2010
@@ -44,7 +44,7 @@
/* This is the baton that we pass svn_ra_open3(), and is associated with
the callback table we provide to RA. */
-typedef struct
+typedef struct callback_baton_t
{
/* Holds the directory that corresponds to the REPOS_URL at svn_ra_open3()
time. When callbacks specify a relative path, they are joined with
Modified: subversion/trunk/subversion/libsvn_diff/diff_file.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_diff/diff_file.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_diff/diff_file.c (original)
+++ subversion/trunk/subversion/libsvn_diff/diff_file.c Thu Dec 30 20:13:50 2010
@@ -1289,7 +1289,7 @@ svn_diff_file_output_unified3(svn_stream
/* A stream to remember *leading* context. Note that this stream does
*not* copy the data that it is remembering; it just saves
*pointers! */
-typedef struct {
+typedef struct context_saver_t {
svn_stream_t *stream;
const char *data[SVN_DIFF__UNIFIED_CONTEXT_SIZE];
apr_size_t len[SVN_DIFF__UNIFIED_CONTEXT_SIZE];
Modified: subversion/trunk/subversion/libsvn_diff/diff_memory.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_diff/diff_memory.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_diff/diff_memory.c (original)
+++ subversion/trunk/subversion/libsvn_diff/diff_memory.c Thu Dec 30 20:13:50 2010
@@ -644,7 +644,7 @@ svn_diff_mem_string_output_unified(svn_s
/* A stream to remember *leading* context. Note that this stream does
*not* copy the data that it is remembering; it just saves
*pointers! */
-typedef struct {
+typedef struct context_saver_t {
svn_stream_t *stream;
const char *data[SVN_DIFF__UNIFIED_CONTEXT_SIZE];
apr_size_t len[SVN_DIFF__UNIFIED_CONTEXT_SIZE];
Modified: subversion/trunk/subversion/libsvn_fs_base/bdb/env.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/bdb/env.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/bdb/env.c (original)
+++ subversion/trunk/subversion/libsvn_fs_base/bdb/env.c Thu Dec 30 20:13:50 2010
@@ -76,7 +76,7 @@
filesystems. We /should/ be safe using this as a unique hash key,
because the database must be on a local filesystem. We can hope,
anyway. */
-typedef struct
+typedef struct bdb_env_key_t
{
apr_dev_t device;
apr_ino_t inode;
Modified: subversion/trunk/subversion/libsvn_fs_base/bdb/env.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/bdb/env.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/bdb/env.h (original)
+++ subversion/trunk/subversion/libsvn_fs_base/bdb/env.h Thu Dec 30 20:13:50 2010
@@ -48,7 +48,7 @@ typedef struct bdb_env_t bdb_env_t;
/* Thread-specific error info related to the bdb_env_t. */
-typedef struct
+typedef struct bdb_error_info_t
{
/* We hold the extended info here until the Berkeley DB function returns.
It usually returns an error code, triggering the collection and
@@ -75,7 +75,7 @@ typedef struct
/* The Berkeley DB environment baton. */
-typedef struct
+typedef struct bdb_env_baton_t
{
/* The Berkeley DB environment. This pointer must be identical to
the one in the bdb_env_t. */
Modified: subversion/trunk/subversion/libsvn_fs_base/fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/fs.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/fs.h (original)
+++ subversion/trunk/subversion/libsvn_fs_base/fs.h Thu Dec 30 20:13:50 2010
@@ -83,7 +83,7 @@ svn_fs_base__test_required_feature_forma
/*** The filesystem structure. ***/
-typedef struct
+typedef struct base_fs_data_t
{
/* A Berkeley DB environment for all the filesystem's databases.
This establishes the scope of the filesystem's transactions. */
@@ -118,7 +118,7 @@ typedef struct
/*** Filesystem Revision ***/
-typedef struct
+typedef struct revision_t
{
/* id of the transaction that was committed to create this
revision. */
@@ -128,7 +128,7 @@ typedef struct
/*** Transaction Kind ***/
-typedef enum
+typedef enum transaction_kind_t
{
transaction_kind_normal = 1, /* normal, uncommitted */
transaction_kind_committed, /* committed */
@@ -138,7 +138,7 @@ typedef enum
/*** Filesystem Transaction ***/
-typedef struct
+typedef struct transaction_t
{
/* kind of transaction. */
transaction_kind_t kind;
@@ -166,7 +166,7 @@ typedef struct
/*** Node-Revision ***/
-typedef struct
+typedef struct node_revision_t
{
/* node kind */
svn_node_kind_t kind;
@@ -217,7 +217,7 @@ typedef struct
/*** Representation Kind ***/
-typedef enum
+typedef enum rep_kind_t
{
rep_kind_fulltext = 1, /* fulltext */
rep_kind_delta /* delta */
@@ -226,7 +226,7 @@ typedef enum
/*** "Delta" Offset/Window Chunk ***/
-typedef struct
+typedef struct rep_delta_chunk_t
{
/* diff format version number ### at this point, "svndiff" is the
only format used. */
@@ -251,7 +251,7 @@ typedef struct
/*** Representation ***/
-typedef struct
+typedef struct representation_t
{
/* representation kind */
rep_kind_t kind;
@@ -295,7 +295,7 @@ typedef struct
/*** Copy Kind ***/
-typedef enum
+typedef enum copy_kind_t
{
copy_kind_real = 1, /* real copy */
copy_kind_soft /* soft copy */
@@ -304,7 +304,7 @@ typedef enum
/*** Copy ***/
-typedef struct
+typedef struct copy_t
{
/* What kind of copy occurred. */
copy_kind_t kind;
@@ -322,7 +322,7 @@ typedef struct
/*** Change ***/
-typedef struct
+typedef struct change_t
{
/* Path of the change. */
const char *path;
@@ -341,7 +341,7 @@ typedef struct
/*** Lock node ***/
-typedef struct
+typedef struct lock_node_t
{
/* entries list, maps (const char *) name --> (const char *) lock-node-id */
apr_hash_t *entries;
Modified: subversion/trunk/subversion/libsvn_fs_base/id.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/id.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/id.c (original)
+++ subversion/trunk/subversion/libsvn_fs_base/id.c Thu Dec 30 20:13:50 2010
@@ -28,7 +28,7 @@
-typedef struct {
+typedef struct id_private_t {
const char *node_id;
const char *copy_id;
const char *txn_id;
Modified: subversion/trunk/subversion/libsvn_fs_base/tree.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/tree.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/tree.c (original)
+++ subversion/trunk/subversion/libsvn_fs_base/tree.c Thu Dec 30 20:13:50 2010
@@ -103,7 +103,7 @@ struct dag_node_cache_t
};
-typedef struct
+typedef struct base_root_data_t
{
/* For revision roots, this is a dag node for the revision's root
@@ -4239,7 +4239,7 @@ base_paths_changed(apr_hash_t **changed_
/* Our coolio opaque history object. */
-typedef struct
+typedef struct base_history_data_t
{
/* filesystem object */
svn_fs_t *fs;
Modified: subversion/trunk/subversion/libsvn_fs_fs/id.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/id.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/id.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/id.c Thu Dec 30 20:13:50 2010
@@ -28,7 +28,7 @@
-typedef struct {
+typedef struct id_private_t {
const char *node_id;
const char *copy_id;
const char *txn_id;
Modified: subversion/trunk/subversion/libsvn_fs_fs/lock.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/lock.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/lock.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/lock.c Thu Dec 30 20:13:50 2010
@@ -989,7 +989,7 @@ svn_fs_fs__get_lock(svn_lock_t **lock_p,
/* Baton for get_locks_filter_func(). */
-typedef struct
+typedef struct get_locks_filter_baton_t
{
const char *path;
svn_depth_t requested_depth;
Modified: subversion/trunk/subversion/libsvn_fs_fs/tree.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/tree.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/tree.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/tree.c Thu Dec 30 20:13:50 2010
@@ -97,7 +97,7 @@
kept in the FS object and shared among multiple revision root
objects.
*/
-typedef struct
+typedef struct fs_rev_root_data_t
{
/* A dag node for the revision's root directory. */
dag_node_t *root_dir;
@@ -111,7 +111,7 @@ typedef struct
} fs_rev_root_data_t;
-typedef struct
+typedef struct fs_txn_root_data_t
{
/* Cache of txn DAG nodes (without their nested noderevs, because
* it's mutable). */
@@ -2764,7 +2764,7 @@ fs_paths_changed(apr_hash_t **changed_pa
/* Our coolio opaque history object. */
-typedef struct
+typedef struct fs_history_data_t
{
/* filesystem object */
svn_fs_t *fs;
Modified: subversion/trunk/subversion/libsvn_ra_neon/commit.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/commit.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/commit.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/commit.c Thu Dec 30 20:13:50 2010
@@ -56,7 +56,7 @@
* NOTE: If you tweak this structure, please update dup_resource() to
* ensure that it continues to create complete deep copies!
*/
-typedef struct
+typedef struct version_rsrc_t
{
svn_revnum_t revision; /* resource's revision, or SVN_INVALID_REVNUM
if it's new or is the HEAD */
@@ -74,7 +74,7 @@ typedef struct
} version_rsrc_t;
-typedef struct
+typedef struct commit_ctx_t
{
svn_ra_neon__session_t *ras;
const char *activity_url;
@@ -102,7 +102,7 @@ typedef struct
} commit_ctx_t;
-typedef struct
+typedef struct put_baton_t
{
apr_file_t *tmpfile; /* may be NULL for content-less file */
svn_stringbuf_t *fname; /* may be NULL for content-less file */
@@ -112,7 +112,7 @@ typedef struct
apr_pool_t *pool;
} put_baton_t;
-typedef struct
+typedef struct resource_baton_t
{
commit_ctx_t *cc;
version_rsrc_t *rsrc;
Modified: subversion/trunk/subversion/libsvn_ra_neon/fetch.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/fetch.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/fetch.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/fetch.c Thu Dec 30 20:13:50 2010
@@ -55,7 +55,7 @@
#include "ra_neon.h"
-typedef struct {
+typedef struct file_read_ctx_t {
apr_pool_t *pool;
/* these two are the handler that the editor gave us */
@@ -68,13 +68,13 @@ typedef struct {
} file_read_ctx_t;
-typedef struct {
+typedef struct file_write_ctx_t {
svn_boolean_t do_checksum; /* only accumulate checksum if set */
svn_checksum_ctx_t *checksum_ctx; /* accumulating checksum of file contents */
svn_stream_t *stream; /* stream to write file contents to */
} file_write_ctx_t;
-typedef struct {
+typedef struct custom_get_ctx_t {
svn_ra_neon__request_t *req; /* Used to propagate errors out of the reader */
int checked_type; /* have we processed ctype yet? */
@@ -86,7 +86,7 @@ typedef svn_error_t * (*prop_setter_t)(v
const svn_string_t *value,
apr_pool_t *pool);
-typedef struct {
+typedef struct dir_item_t {
/* The baton returned by the editor's open_root/open_dir */
void *baton;
@@ -110,7 +110,7 @@ typedef struct {
} dir_item_t;
-typedef struct {
+typedef struct report_baton_t {
svn_ra_neon__session_t *ras;
apr_file_t *tmpfile;
Modified: subversion/trunk/subversion/libsvn_ra_neon/get_dated_rev.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/get_dated_rev.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/get_dated_rev.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/get_dated_rev.c Thu Dec 30 20:13:50 2010
@@ -71,7 +71,7 @@ static const svn_ra_neon__xml_elm_t drev
{ NULL }
};
-typedef struct
+typedef struct drev_baton_t
{
svn_stringbuf_t *cdata;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_neon/get_deleted_rev.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/get_deleted_rev.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/get_deleted_rev.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/get_deleted_rev.c Thu Dec 30 20:13:50 2010
@@ -67,7 +67,7 @@ static const svn_ra_neon__xml_elm_t drev
};
/* Context for parsing server's response. */
-typedef struct
+typedef struct drev_baton_t
{
svn_stringbuf_t *cdata;
svn_revnum_t revision;
Modified: subversion/trunk/subversion/libsvn_ra_neon/get_location_segments.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/get_location_segments.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/get_location_segments.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/get_location_segments.c Thu Dec 30 20:13:50 2010
@@ -67,7 +67,7 @@ static const svn_ra_neon__xml_elm_t gls_
{ NULL }
};
-typedef struct {
+typedef struct get_location_segments_baton_t {
svn_location_segment_receiver_t receiver;
void *receiver_baton;
apr_pool_t *subpool;
Modified: subversion/trunk/subversion/libsvn_ra_neon/get_locations.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/get_locations.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/get_locations.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/get_locations.c Thu Dec 30 20:13:50 2010
@@ -66,7 +66,7 @@ static const svn_ra_neon__xml_elm_t gloc
{ NULL }
};
-typedef struct {
+typedef struct get_locations_baton_t {
svn_ra_neon__session_t *ras;
apr_hash_t *hash;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_neon/get_locks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/get_locks.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/get_locks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/get_locks.c Thu Dec 30 20:13:50 2010
@@ -120,7 +120,7 @@ static const svn_ra_neon__xml_elm_t getl
/* Context for parsing server's response. */
-typedef struct {
+typedef struct get_locks_baton_t {
const char *path; /* target of the report */
svn_depth_t requested_depth; /* requested depth of the report */
svn_lock_t *current_lock; /* the lock being constructed */
Modified: subversion/trunk/subversion/libsvn_ra_neon/lock.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/lock.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/lock.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/lock.c Thu Dec 30 20:13:50 2010
@@ -65,7 +65,7 @@ static const svn_ra_neon__xml_elm_t lock
{ NULL }
};
-typedef struct
+typedef struct lock_baton_t
{
svn_stringbuf_t *cdata;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_neon/merge.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/merge.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/merge.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/merge.c Thu Dec 30 20:13:50 2010
@@ -76,7 +76,7 @@ enum merge_rtype {
RTYPE_BASELINE /* a baseline resource */
};
-typedef struct {
+typedef struct merge_ctx_t {
/*WARNING: WANT_CDATA should stay the first element in the baton:
svn_ra_neon__xml_collect_cdata() assumes the baton starts with a stringbuf.
*/
Modified: subversion/trunk/subversion/libsvn_ra_neon/options.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/options.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/options.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/options.c Thu Dec 30 20:13:50 2010
@@ -41,7 +41,7 @@ static const svn_ra_neon__xml_elm_t opti
{ NULL }
};
-typedef struct {
+typedef struct options_ctx_t {
/*WARNING: WANT_CDATA should stay the first element in the baton:
svn_ra_neon__xml_collect_cdata() assumes the baton starts with a stringbuf.
*/
Modified: subversion/trunk/subversion/libsvn_ra_neon/props.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/props.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/props.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/props.c Thu Dec 30 20:13:50 2010
@@ -79,7 +79,7 @@ static const ne_propname baseline_props[
/*** Propfind Implementation ***/
-typedef struct {
+typedef struct elem_defn {
svn_ra_neon__xml_elmid id;
const char *name;
int is_property; /* is it a property, or part of some structure? */
Modified: subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h Thu Dec 30 20:13:50 2010
@@ -61,7 +61,7 @@ extern "C" {
typedef int svn_ra_neon__xml_elmid;
/** XML element */
-typedef struct {
+typedef struct svn_ra_neon__xml_elm_t {
/** XML namespace. */
const char *nspace;
@@ -154,7 +154,7 @@ typedef struct svn_ra_neon__session_t {
#define SVN_RA_NEON__HAVE_HTTPV2_SUPPORT(ras) ((ras)->me_resource != NULL)
-typedef struct {
+typedef struct svn_ra_neon__request_t {
ne_request *ne_req; /* neon request structure */
ne_session *ne_sess; /* neon session structure */
svn_ra_neon__session_t *sess; /* DAV session structure */
@@ -436,7 +436,7 @@ svn_error_t *svn_ra_neon__get_path_relat
#define SVN_RA_NEON__PROP_DEADPROP_COUNT SVN_DAV_PROP_NS_DAV "deadprop-count"
-typedef struct {
+typedef struct svn_ra_neon__resource_t {
/* what is the URL for this resource */
const char *url;
Modified: subversion/trunk/subversion/libsvn_ra_neon/replay.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/replay.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/replay.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/replay.c Thu Dec 30 20:13:50 2010
@@ -29,7 +29,7 @@
#include "ra_neon.h"
-typedef struct {
+typedef struct replay_baton_t {
/* The underlying editor and baton we're replaying into. */
const svn_delta_editor_t *editor;
void *edit_baton;
@@ -65,7 +65,7 @@ typedef struct {
dir_item_t))
/* Info about a given directory we've seen. */
-typedef struct {
+typedef struct dir_item_t {
void *baton;
const char *path;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_neon/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/util.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/util.c Thu Dec 30 20:13:50 2010
@@ -154,7 +154,7 @@ validate_element(int parent, int child)
return multistatus_nesting_table[i][j];
}
-typedef struct
+typedef struct multistatus_baton_t
{
svn_stringbuf_t *want_cdata;
svn_stringbuf_t *cdata;
@@ -460,7 +460,7 @@ attach_ne_body_reader(svn_ra_neon__reque
}
-typedef struct
+typedef struct body_reader_wrapper_baton_t
{
svn_ra_neon__request_t *req;
svn_ra_neon__block_reader real_reader;
@@ -916,7 +916,7 @@ error_parser_create(svn_ra_neon__request
* interface.
*/
-typedef struct
+typedef struct body_provider_baton_t
{
svn_ra_neon__request_t *req;
apr_file_t *body_file;
@@ -1065,7 +1065,7 @@ parse_spool_file(svn_ra_neon__session_t
* are returned they are stored in this baton and a Neon level
* error code is returned to the parser.
*/
-typedef struct {
+typedef struct parser_wrapper_baton_t {
svn_ra_neon__request_t *req;
ne_xml_parser *parser;
Modified: subversion/trunk/subversion/libsvn_ra_serf/auth.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/auth.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/auth.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/auth.c Thu Dec 30 20:13:50 2010
@@ -191,7 +191,7 @@ svn_ra_serf__encode_auth_header(const ch
/**
* Baton passed to the response header callback function
*/
-typedef struct {
+typedef struct auth_baton_t {
int code;
const char *header;
svn_ra_serf__handler_t *ctx;
Modified: subversion/trunk/subversion/libsvn_ra_serf/auth_digest.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/auth_digest.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/auth_digest.h (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/auth_digest.h Thu Dec 30 20:13:50 2010
@@ -32,7 +32,7 @@ extern "C" {
/* Stores the context information related to Digest authentication.
The context is per connection. */
-typedef struct
+typedef struct serf_digest_context_t
{
/* nonce-count for digest authentication */
unsigned int digest_nc;
Modified: subversion/trunk/subversion/libsvn_ra_serf/auth_kerb.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/auth_kerb.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/auth_kerb.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/auth_kerb.c Thu Dec 30 20:13:50 2010
@@ -99,7 +99,7 @@
* ### TODO: Not implemented yet!
*/
-typedef enum
+typedef enum gss_api_auth_state
{
gss_api_auth_not_started,
gss_api_auth_in_progress,
@@ -110,7 +110,7 @@ typedef enum
#define KRB_HTTP_SERVICE "HTTP"
/* Stores the context information related to Kerberos authentication. */
-typedef struct
+typedef struct serf_gss_api_context_t
{
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_serf/blame.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/blame.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/blame.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/blame.c Thu Dec 30 20:13:50 2010
@@ -47,7 +47,7 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum blame_state_e {
NONE = 0,
FILE_REVS_REPORT,
FILE_REV,
@@ -58,7 +58,7 @@ typedef enum {
TXDELTA,
} blame_state_e;
-typedef struct {
+typedef struct blame_info_t {
/* Current pool. */
apr_pool_t *pool;
@@ -96,7 +96,7 @@ typedef struct {
} blame_info_t;
-typedef struct {
+typedef struct blame_context_t {
/* pool passed to get_file_revs */
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_serf/commit.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/commit.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/commit.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/commit.c Thu Dec 30 20:13:50 2010
@@ -47,7 +47,7 @@
/* Structure associated with a CHECKOUT request. */
-typedef struct {
+typedef struct checkout_context_t {
apr_pool_t *pool;
@@ -63,7 +63,7 @@ typedef struct {
} checkout_context_t;
/* Baton passed back with the commit editor. */
-typedef struct {
+typedef struct commit_context_t {
/* Pool for our commit. */
apr_pool_t *pool;
@@ -97,7 +97,7 @@ typedef struct {
#define USING_HTTPV2_COMMIT_SUPPORT(commit_ctx) ((commit_ctx)->txn_url != NULL)
/* Structure associated with a PROPPATCH request. */
-typedef struct {
+typedef struct proppatch_context_t {
apr_pool_t *pool;
const char *name;
@@ -119,7 +119,7 @@ typedef struct {
svn_ra_serf__simple_request_context_t progress;
} proppatch_context_t;
-typedef struct {
+typedef struct delete_context_t {
const char *path;
svn_revnum_t revision;
@@ -172,7 +172,7 @@ typedef struct dir_context_t {
} dir_context_t;
/* Represents a file to be committed. */
-typedef struct {
+typedef struct file_context_t {
/* Pool for our file. */
apr_pool_t *pool;
@@ -1225,7 +1225,7 @@ create_txn_post_body(serf_bucket_t **bod
/* Handler baton for POST request. */
-typedef struct
+typedef struct post_response_ctx_t
{
svn_ra_serf__simple_request_context_t *request_ctx;
commit_context_t *commit_ctx;
Modified: subversion/trunk/subversion/libsvn_ra_serf/fake_sspi.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/fake_sspi.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/fake_sspi.h (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/fake_sspi.h Thu Dec 30 20:13:50 2010
@@ -28,12 +28,12 @@ extern "C" {
#endif /* __cplusplus */
-typedef struct {
+typedef struct CtxtHandle {
int dwLower;
int dwUpper;
} CtxtHandle;
-typedef struct {
+struct SecurityFunctionTable {
int (*QuerySecurityPackageInfo)(const void *,const void *);
void (*FreeContextBuffer)(const void *);
int (*AcquireCredentialsHandle)(const void *, const void *, int,
@@ -45,7 +45,8 @@ typedef struct {
const void *, int, int, int, const void *,
int, const void *, const void *,
const void *, const void *);
-} * PSecurityFunctionTable;
+};
+typedef struct SecurityFunctionTable *PSecurityFunctionTable;
typedef int SECURITY_STATUS, DWORD, TimeStamp;
@@ -64,17 +65,17 @@ typedef int SECURITY_STATUS, DWORD, Time
PSecurityFunctionTable InitSecurityInterface(void);
-typedef struct {
+typedef struct SecPkgInfo {
int cbMaxToken;
} SecPkgInfo;
-typedef struct {
+typedef struct SecBuffer {
int BufferType;
int cbBuffer;
const void *pvBuffer;
} SecBuffer;
-typedef struct {
+typedef struct SecBufferDesc {
int cBuffers;
int ulVersion;
const void *pBuffers;
Modified: subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/get_deleted_rev.c Thu Dec 30 20:13:50 2010
@@ -35,12 +35,12 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum drev_state_e {
NONE = 0,
VERSION_NAME,
} drev_state_e;
-typedef struct {
+typedef struct drev_context_t {
apr_pool_t *pool;
const char *path;
Modified: subversion/trunk/subversion/libsvn_ra_serf/getdate.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getdate.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getdate.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getdate.c Thu Dec 30 20:13:50 2010
@@ -49,18 +49,18 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum date_state_e {
NONE = 0,
VERSION_NAME,
} date_state_e;
-typedef struct {
+typedef struct date_info_t {
/* The currently collected value as we build it up */
const char *tmp;
apr_size_t tmp_len;
} date_info_t;
-typedef struct {
+typedef struct date_context_t {
apr_pool_t *pool;
/* The time asked about. */
Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocations.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocations.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocations.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocations.c Thu Dec 30 20:13:50 2010
@@ -46,7 +46,7 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum loc_state_e {
REPORT,
LOCATION,
} loc_state_e;
@@ -59,7 +59,7 @@ typedef struct loc_state_list_t {
struct loc_state_list_t *prev;
} loc_state_list_t;
-typedef struct {
+typedef struct loc_context_t {
/* pool to allocate memory from */
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocationsegments.c Thu Dec 30 20:13:50 2010
@@ -39,7 +39,7 @@
-typedef struct {
+typedef struct gls_context_t {
/* parameters set by our caller */
svn_revnum_t peg_revision;
svn_revnum_t start_rev;
Modified: subversion/trunk/subversion/libsvn_ra_serf/getlocks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/getlocks.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/getlocks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/getlocks.c Thu Dec 30 20:13:50 2010
@@ -49,7 +49,7 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum lock_state_e {
NONE = 0,
REPORT,
LOCK,
@@ -61,7 +61,7 @@ typedef enum {
EXPIRATION_DATE,
} lock_state_e;
-typedef struct {
+typedef struct lock_info_t {
/* Temporary pool */
apr_pool_t *pool;
@@ -73,7 +73,7 @@ typedef struct {
} lock_info_t;
-typedef struct {
+typedef struct lock_context_t {
apr_pool_t *pool;
/* target and requested depth of the operation. */
Modified: subversion/trunk/subversion/libsvn_ra_serf/locks.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/locks.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/locks.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/locks.c Thu Dec 30 20:13:50 2010
@@ -47,7 +47,7 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum lock_state_e {
NONE = 0,
PROP,
LOCK_DISCOVERY,
@@ -60,12 +60,12 @@ typedef enum {
COMMENT,
} lock_state_e;
-typedef struct {
+typedef struct lock_prop_info_t {
const char *data;
apr_size_t len;
} lock_prop_info_t;
-typedef struct {
+typedef struct lock_info_t {
apr_pool_t *pool;
const char *path;
Modified: subversion/trunk/subversion/libsvn_ra_serf/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/log.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/log.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/log.c Thu Dec 30 20:13:50 2010
@@ -49,7 +49,7 @@
/*
* This enum represents the current state of our XML parsing for a REPORT.
*/
-typedef enum {
+typedef enum log_state_e {
NONE = 0,
REPORT,
ITEM,
@@ -65,7 +65,7 @@ typedef enum {
MODIFIED_PATH,
} log_state_e;
-typedef struct {
+typedef struct log_info_t {
apr_pool_t *pool;
/* The currently collected value as we build it up */
@@ -82,7 +82,7 @@ typedef struct {
const char *revprop_name;
} log_info_t;
-typedef struct {
+typedef struct log_context_t {
apr_pool_t *pool;
/* parameters set by our caller */
Modified: subversion/trunk/subversion/libsvn_ra_serf/merge.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/merge.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/merge.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/merge.c Thu Dec 30 20:13:50 2010
@@ -49,7 +49,7 @@
/*
* This enum represents the current state of our XML parsing for a MERGE.
*/
-typedef enum {
+typedef enum merge_state_e {
NONE = 0,
MERGE_RESPONSE,
UPDATED_SET,
@@ -66,14 +66,14 @@ typedef enum {
PROP_VAL,
} merge_state_e;
-typedef enum {
+typedef enum resource_type_e {
UNSET,
BASELINE,
COLLECTION,
CHECKED_IN,
} resource_type_e;
-typedef struct {
+typedef struct merge_info_t {
/* Temporary allocations here please */
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/mergeinfo.c Thu Dec 30 20:13:50 2010
@@ -40,7 +40,7 @@
/* The current state of our XML parsing. */
-typedef enum {
+typedef enum mergeinfo_state_e {
NONE = 0,
MERGEINFO_REPORT,
MERGEINFO_ITEM,
@@ -54,7 +54,7 @@ typedef enum {
get_mergeinfo. curr_path and curr_info contain the value of the
CDATA from the mergeinfo items as we get them from the server. */
-typedef struct {
+typedef struct mergeinfo_context_t {
apr_pool_t *pool;
svn_stringbuf_t *curr_path;
svn_stringbuf_t *curr_info;
Modified: subversion/trunk/subversion/libsvn_ra_serf/options.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/options.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/options.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/options.c Thu Dec 30 20:13:50 2010
@@ -48,7 +48,7 @@
/*
* This enum represents the current state of our XML parsing for an OPTIONS.
*/
-typedef enum {
+typedef enum options_state_e {
OPTIONS,
ACTIVITY_COLLECTION,
HREF,
Modified: subversion/trunk/subversion/libsvn_ra_serf/property.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/property.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/property.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/property.c Thu Dec 30 20:13:50 2010
@@ -37,14 +37,14 @@
/* Our current parsing state we're in for the PROPFIND response. */
-typedef enum {
+typedef enum prop_state_e {
NONE = 0,
RESPONSE,
PROP,
PROPVAL,
} prop_state_e;
-typedef struct {
+typedef struct prop_info_t {
apr_pool_t *pool;
/* Current ns, attribute name, and value of the property we're parsing */
Modified: subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h Thu Dec 30 20:13:50 2010
@@ -67,7 +67,7 @@ extern "C" {
typedef struct svn_ra_serf__session_t svn_ra_serf__session_t;
typedef struct svn_ra_serf__auth_protocol_t svn_ra_serf__auth_protocol_t;
-typedef enum
+typedef enum svn_ra_serf__authn_types
{
svn_ra_serf__authn_none = 0x00,
svn_ra_serf__authn_basic = 0x01,
Modified: subversion/trunk/subversion/libsvn_ra_serf/replay.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/replay.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/replay.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/replay.c Thu Dec 30 20:13:50 2010
@@ -47,7 +47,7 @@
/*
* This enum represents the current state of our XML parsing.
*/
-typedef enum {
+typedef enum replay_state_e {
NONE = 0,
REPORT,
OPEN_DIR,
@@ -76,7 +76,7 @@ typedef svn_error_t *
const svn_string_t *value,
apr_pool_t *pool);
-typedef struct {
+typedef struct prop_info_t {
apr_pool_t *pool;
change_prop_t change;
Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/update.c Thu Dec 30 20:13:50 2010
@@ -63,7 +63,7 @@
* allocations that will live as long as the tag is opened. Once
* the tag is 'closed', the pool will be reused.
*/
-typedef enum {
+typedef enum report_state_e {
NONE = 0,
OPEN_DIR,
ADD_DIR,
Modified: subversion/trunk/subversion/libsvn_ra_serf/win32_auth_sspi.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/win32_auth_sspi.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/win32_auth_sspi.h (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/win32_auth_sspi.h Thu Dec 30 20:13:50 2010
@@ -50,7 +50,7 @@
extern "C" {
#endif /* __cplusplus */
-typedef enum
+typedef enum sspi_auth_state
{
sspi_auth_not_started,
sspi_auth_in_progress,
@@ -60,7 +60,7 @@ typedef enum
/* Stores the context information related to SSPI. The context is per
connection, it enables SSPI to go through the challenge/response cycle
of the authentication protocols. */
-typedef struct
+typedef struct serf_sspi_context_t
{
CtxtHandle ctx;
Modified: subversion/trunk/subversion/libsvn_ra_svn/client.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/client.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_svn/client.c (original)
+++ subversion/trunk/subversion/libsvn_ra_svn/client.c Thu Dec 30 20:13:50 2010
@@ -64,7 +64,7 @@
#define DEPTH_TO_RECURSE(d) \
((d) == svn_depth_unknown || (d) > svn_depth_files)
-typedef struct {
+typedef struct ra_svn_commit_callback_baton_t {
svn_ra_svn__session_baton_t *sess_baton;
apr_pool_t *pool;
svn_revnum_t *new_rev;
@@ -72,7 +72,7 @@ typedef struct {
void *callback_baton;
} ra_svn_commit_callback_baton_t;
-typedef struct {
+typedef struct ra_svn_reporter_baton_t {
svn_ra_svn__session_baton_t *sess_baton;
svn_ra_svn_conn_t *conn;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_ra_svn/editorp.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/editorp.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_svn/editorp.c (original)
+++ subversion/trunk/subversion/libsvn_ra_svn/editorp.c Thu Dec 30 20:13:50 2010
@@ -48,7 +48,7 @@
* connection; both ends are useful for both server and client.
*/
-typedef struct {
+typedef struct ra_svn_edit_baton_t {
svn_ra_svn_conn_t *conn;
svn_ra_svn_edit_callback callback; /* Called on successful completion. */
void *callback_baton;
@@ -57,14 +57,14 @@ typedef struct {
} ra_svn_edit_baton_t;
/* Works for both directories and files. */
-typedef struct {
+typedef struct ra_svn_baton_t {
svn_ra_svn_conn_t *conn;
apr_pool_t *pool;
ra_svn_edit_baton_t *eb;
const char *token;
} ra_svn_baton_t;
-typedef struct {
+typedef struct ra_svn_driver_state_t {
const svn_delta_editor_t *editor;
void *edit_baton;
apr_hash_t *tokens;
@@ -85,7 +85,7 @@ typedef struct {
field in this structure is vestigial for files, and we use it for a
different purpose instead: at apply-textdelta time, we set it to a
subpool of the file pool, which is destroyed in textdelta-end. */
-typedef struct {
+typedef struct ra_svn_token_entry_t {
const char *token;
void *baton;
svn_boolean_t is_file;
Modified: subversion/trunk/subversion/libsvn_ra_svn/streams.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/streams.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_svn/streams.c (original)
+++ subversion/trunk/subversion/libsvn_ra_svn/streams.c Thu Dec 30 20:13:50 2010
@@ -42,12 +42,12 @@ struct svn_ra_svn__stream_st {
ra_svn_timeout_fn_t timeout_fn;
};
-typedef struct {
+typedef struct sock_baton_t {
apr_socket_t *sock;
apr_pool_t *pool;
} sock_baton_t;
-typedef struct {
+typedef struct file_baton_t {
apr_file_t *in_file;
apr_file_t *out_file;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/libsvn_subr/auth.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/auth.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/auth.c (original)
+++ subversion/trunk/subversion/libsvn_subr/auth.c Thu Dec 30 20:13:50 2010
@@ -60,7 +60,7 @@
/* This effectively defines a single table. Every provider in this
array returns the same kind of credentials. */
-typedef struct
+typedef struct provider_set_t
{
/* ordered array of svn_auth_provider_object_t */
apr_array_header_t *providers;
Modified: subversion/trunk/subversion/libsvn_subr/cache-inprocess.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cache-inprocess.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/cache-inprocess.c (original)
+++ subversion/trunk/subversion/libsvn_subr/cache-inprocess.c Thu Dec 30 20:13:50 2010
@@ -32,7 +32,7 @@
#include "cache.h"
/* The (internal) cache object. */
-typedef struct {
+typedef struct inprocess_cache_t {
/* Maps from a key (of size CACHE->KLEN) to a struct cache_entry. */
apr_hash_t *hash;
apr_ssize_t klen;
Modified: subversion/trunk/subversion/libsvn_subr/cache-memcache.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cache-memcache.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/cache-memcache.c (original)
+++ subversion/trunk/subversion/libsvn_subr/cache-memcache.c Thu Dec 30 20:13:50 2010
@@ -44,7 +44,7 @@
*/
/* The (internal) cache object. */
-typedef struct {
+typedef struct memcache_t {
/* The memcached server set we're using. */
apr_memcache_t *memcache;
Modified: subversion/trunk/subversion/libsvn_subr/cache.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cache.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/cache.h (original)
+++ subversion/trunk/subversion/libsvn_subr/cache.h Thu Dec 30 20:13:50 2010
@@ -30,7 +30,7 @@
extern "C" {
#endif /* __cplusplus */
-typedef struct {
+typedef struct svn_cache__vtable_t {
svn_error_t *(*get)(void **value,
svn_boolean_t *found,
void *cache_implementation,
Modified: subversion/trunk/subversion/libsvn_subr/date.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/date.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/date.c (original)
+++ subversion/trunk/subversion/libsvn_subr/date.c Thu Dec 30 20:13:50 2010
@@ -42,7 +42,7 @@ enum rule_action {
};
/* How to handle a particular character in a template */
-typedef struct
+typedef struct rule
{
char key; /* The template char that this rule matches */
const char *valid; /* String of valid chars for this rule */
@@ -53,7 +53,7 @@ typedef struct
} rule;
/* The parsed values, before localtime/gmt processing */
-typedef struct
+typedef struct match_state
{
apr_time_exp_t base;
apr_int32_t offhours;
Modified: subversion/trunk/subversion/libsvn_subr/dirent_uri.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/dirent_uri.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/dirent_uri.c (original)
+++ subversion/trunk/subversion/libsvn_subr/dirent_uri.c Thu Dec 30 20:13:50 2010
@@ -57,7 +57,7 @@
#endif
/* Path type definition. Used only by internal functions. */
-typedef enum {
+typedef enum path_type_t {
type_uri,
type_dirent,
type_relpath
Modified: subversion/trunk/subversion/libsvn_subr/error.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/error.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/error.c (original)
+++ subversion/trunk/subversion/libsvn_subr/error.c Thu Dec 30 20:13:50 2010
@@ -580,7 +580,7 @@ svn_err_best_message(svn_error_t *err, c
/* svn_strerror() and helpers */
-typedef struct {
+typedef struct err_defn {
svn_errno_t errcode;
const char *errdesc;
} err_defn;
Modified: subversion/trunk/subversion/libsvn_subr/mergeinfo.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/mergeinfo.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/mergeinfo.c (original)
+++ subversion/trunk/subversion/libsvn_subr/mergeinfo.c Thu Dec 30 20:13:50 2010
@@ -126,7 +126,7 @@ parse_pathname(const char **input,
(SVN_IS_VALID_REVNUM((range)->start) && ((range)->start < (range)->end))
/* Ways in which two svn_merge_range_t can intersect or adjoin, if at all. */
-typedef enum
+typedef enum intersection_type_t
{
/* Ranges don't intersect and don't adjoin. */
svn__no_intersection,
Modified: subversion/trunk/subversion/libsvn_subr/simple_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/simple_providers.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/simple_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/simple_providers.c Thu Dec 30 20:13:50 2010
@@ -49,7 +49,7 @@
#define AUTHN_PASSTYPE_KEY "passtype"
/* Baton type for the simple provider. */
-typedef struct
+typedef struct simple_provider_baton_t
{
svn_auth_plaintext_prompt_func_t plaintext_prompt_func;
void *prompt_baton;
@@ -541,7 +541,7 @@ svn_auth_get_simple_provider2
/*-----------------------------------------------------------------------*/
/* Baton type for username/password prompting. */
-typedef struct
+typedef struct simple_prompt_provider_baton_t
{
svn_auth_simple_prompt_func_t prompt_func;
void *prompt_baton;
@@ -552,7 +552,7 @@ typedef struct
/* Iteration baton type for username/password prompting. */
-typedef struct
+typedef struct simple_prompt_iter_baton_t
{
/* how many times we've reprompted */
int retries;
Modified: subversion/trunk/subversion/libsvn_subr/ssl_client_cert_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/ssl_client_cert_providers.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/ssl_client_cert_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/ssl_client_cert_providers.c Thu Dec 30 20:13:50 2010
@@ -105,7 +105,7 @@ void svn_auth_get_ssl_client_cert_file_p
/* Baton type for prompting to send client ssl creds.
There is no iteration baton type. */
-typedef struct
+typedef struct ssl_client_cert_prompt_provider_baton_t
{
svn_auth_ssl_client_cert_prompt_func_t prompt_func;
void *prompt_baton;
@@ -115,7 +115,7 @@ typedef struct
} ssl_client_cert_prompt_provider_baton_t;
/* Iteration baton. */
-typedef struct
+typedef struct ssl_client_cert_prompt_iter_baton_t
{
/* The original provider baton */
ssl_client_cert_prompt_provider_baton_t *pb;
Modified: subversion/trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c Thu Dec 30 20:13:50 2010
@@ -49,7 +49,7 @@
#define AUTHN_PASSTYPE_KEY "passtype"
/* Baton type for the ssl client cert passphrase provider. */
-typedef struct
+typedef struct ssl_client_cert_pw_file_provider_baton_t
{
svn_auth_plaintext_passphrase_prompt_func_t plaintext_passphrase_prompt_func;
void *prompt_baton;
@@ -405,7 +405,7 @@ svn_auth_get_ssl_client_cert_pw_file_pro
/* Baton type for client passphrase prompting.
There is no iteration baton type. */
-typedef struct
+typedef struct ssl_client_cert_pw_prompt_provider_baton_t
{
svn_auth_ssl_client_cert_pw_prompt_func_t prompt_func;
void *prompt_baton;
@@ -415,7 +415,7 @@ typedef struct
} ssl_client_cert_pw_prompt_provider_baton_t;
/* Iteration baton. */
-typedef struct
+typedef struct ssl_client_cert_pw_prompt_iter_baton_t
{
/* The original provider baton */
ssl_client_cert_pw_prompt_provider_baton_t *pb;
Modified: subversion/trunk/subversion/libsvn_subr/ssl_server_trust_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/ssl_server_trust_providers.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/ssl_server_trust_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/ssl_server_trust_providers.c Thu Dec 30 20:13:50 2010
@@ -182,7 +182,7 @@ svn_auth_get_ssl_server_trust_file_provi
/* Baton type for prompting to verify server ssl creds.
There is no iteration baton type. */
-typedef struct
+typedef struct ssl_server_trust_prompt_provider_baton_t
{
svn_auth_ssl_server_trust_prompt_func_t prompt_func;
void *prompt_baton;
Modified: subversion/trunk/subversion/libsvn_subr/subst.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/subst.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/subst.c (original)
+++ subversion/trunk/subversion/libsvn_subr/subst.c Thu Dec 30 20:13:50 2010
@@ -1281,7 +1281,7 @@ translated_stream_close(void *baton)
/* svn_stream_mark_t for translation streams. */
-typedef struct
+typedef struct mark_translated_t
{
/* Saved translation state. */
struct translated_stream_baton saved_baton;
Modified: subversion/trunk/subversion/libsvn_subr/username_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/username_providers.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/username_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/username_providers.c Thu Dec 30 20:13:50 2010
@@ -165,7 +165,7 @@ svn_auth_get_username_provider(svn_auth_
/*-----------------------------------------------------------------------*/
/* Baton type for username-only prompting. */
-typedef struct
+typedef struct username_prompt_provider_baton_t
{
svn_auth_username_prompt_func_t prompt_func;
void *prompt_baton;
@@ -176,7 +176,7 @@ typedef struct
/* Iteration baton type for username-only prompting. */
-typedef struct
+typedef struct username_prompt_iter_baton_t
{
/* how many times we've reprompted */
int retries;
Modified: subversion/trunk/subversion/libsvn_subr/win32_crashrpt.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/win32_crashrpt.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/win32_crashrpt.c (original)
+++ subversion/trunk/subversion/libsvn_subr/win32_crashrpt.c Thu Dec 30 20:13:50 2010
@@ -375,7 +375,7 @@ format_value(char *value_str, DWORD64 mo
/* Internal structure used to pass some data to the enumerate symbols
* callback */
-typedef struct {
+typedef struct symbols_baton_t {
STACKFRAME64 *stack_frame;
FILE *log_file;
int nr_of_frame;
Modified: subversion/trunk/subversion/libsvn_wc/adm_ops.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_ops.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/adm_ops.c (original)
+++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Thu Dec 30 20:13:50 2010
@@ -74,7 +74,7 @@ struct svn_wc_committed_queue_t
svn_boolean_t have_recursive;
};
-typedef struct
+typedef struct committed_queue_item_t
{
const char *local_abspath;
svn_boolean_t recurse;
Modified: subversion/trunk/subversion/libsvn_wc/entries.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/entries.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/entries.c (original)
+++ subversion/trunk/subversion/libsvn_wc/entries.c Thu Dec 30 20:13:50 2010
@@ -52,7 +52,7 @@
/* Temporary structures which mirror the tables in wc-metadata.sql.
For detailed descriptions of each field, see that file. */
-typedef struct {
+typedef struct db_base_node_t {
apr_int64_t wc_id;
const char *local_relpath;
apr_int64_t repos_id;
@@ -71,7 +71,7 @@ typedef struct {
apr_hash_t *properties;
} db_base_node_t;
-typedef struct {
+typedef struct db_working_node_t {
apr_int64_t wc_id;
const char *local_relpath;
apr_int64_t op_depth;
@@ -93,7 +93,7 @@ typedef struct {
apr_hash_t *properties;
} db_working_node_t;
-typedef struct {
+typedef struct db_actual_node_t {
apr_int64_t wc_id;
const char *local_relpath;
const char *parent_relpath;
Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/wc_db.c (original)
+++ subversion/trunk/subversion/libsvn_wc/wc_db.c Thu Dec 30 20:13:50 2010
@@ -170,7 +170,7 @@ typedef struct insert_base_baton_t {
} insert_base_baton_t;
-typedef struct {
+typedef struct insert_working_baton_t {
/* common to all insertions into WORKING (including NODE_DATA) */
svn_wc__db_status_t presence;
svn_wc__db_kind_t kind;
Modified: subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c (original)
+++ subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c Thu Dec 30 20:13:50 2010
@@ -46,7 +46,7 @@
extern module AP_MODULE_DECLARE_DATA authz_svn_module;
-typedef struct {
+typedef struct authz_svn_config_rec {
int authoritative;
int anonymous;
int no_auth_when_anon_ok;
Modified: subversion/trunk/subversion/mod_dav_svn/dav_svn.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/dav_svn.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/dav_svn.h (original)
+++ subversion/trunk/subversion/mod_dav_svn/dav_svn.h Thu Dec 30 20:13:50 2010
@@ -73,7 +73,7 @@ extern "C" {
* ### only a single FS open; otherwise, it will have to work a bit harder
* ### to keep the things in sync.
*/
-typedef struct {
+typedef struct dav_svn_repos {
apr_pool_t *pool; /* request_rec -> pool */
/* Remember the root URL path of this repository (just a path; no
@@ -175,7 +175,7 @@ enum dav_svn_private_restype {
/* store info about a root in a repository */
-typedef struct {
+typedef struct dav_svn_root {
/* If a root within the FS has been opened, the value is stored here.
Otherwise, this field is NULL. */
svn_fs_root_t *root;
@@ -662,7 +662,7 @@ dav_svn__post_create_txn(const dav_resou
/*** authz.c ***/
/* A baton needed by dav_svn__authz_read_func(). */
-typedef struct
+typedef struct dav_svn__authz_read_baton
{
/* The original request, needed to generate a subrequest. */
request_rec *r;
@@ -809,7 +809,7 @@ dav_svn__build_uri(const dav_svn_repos *
### URIs which we may need to parse. it also ignores any scheme, host,
### and port in the URI and simply assumes it refers to the same server.
*/
-typedef struct {
+typedef struct dav_svn__uri_info {
svn_revnum_t rev;
const char *repos_path;
const char *activity_id;
Modified: subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c Thu Dec 30 20:13:50 2010
@@ -50,7 +50,7 @@
#define PATHAUTHZ_BYPASS_ARG "short_circuit"
/* per-server configuration */
-typedef struct {
+typedef struct server_conf_t {
const char *special_uri;
} server_conf_t;
@@ -73,7 +73,7 @@ enum path_authz_conf {
};
/* per-dir configuration */
-typedef struct {
+typedef struct dir_conf_t {
const char *fs_path; /* path to the SVN FS */
const char *repo_name; /* repository name */
const char *xslt_uri; /* XSL transform URI */
@@ -663,7 +663,7 @@ merge_xml_filter_insert(request_rec *r)
}
-typedef struct {
+typedef struct merge_ctx_t {
apr_bucket_brigade *bb;
apr_xml_parser *parser;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/mod_dav_svn/reports/replay.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/reports/replay.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/reports/replay.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/reports/replay.c Thu Dec 30 20:13:50 2010
@@ -42,7 +42,7 @@
#include "../dav_svn.h"
-typedef struct {
+typedef struct edit_baton_t {
apr_bucket_brigade *bb;
ap_filter_t *output;
svn_boolean_t started;
Modified: subversion/trunk/subversion/mod_dav_svn/reports/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/reports/update.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/reports/update.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/reports/update.c Thu Dec 30 20:13:50 2010
@@ -43,7 +43,7 @@
#include "../dav_svn.h"
-typedef struct {
+typedef struct update_ctx_t {
const dav_resource *resource;
/* the revision we are updating to. used to generated IDs. */
Modified: subversion/trunk/subversion/mod_dav_svn/repos.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/repos.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/repos.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/repos.c Thu Dec 30 20:13:50 2010
@@ -71,7 +71,7 @@ struct dav_stream {
/* Convenience structure that facilitates combined memory allocation of
a dav_resource and dav_resource_private pair. */
-typedef struct {
+typedef struct dav_resource_combined {
dav_resource res;
dav_resource_private priv;
} dav_resource_combined;
@@ -3049,7 +3049,7 @@ set_headers(request_rec *r, const dav_re
}
-typedef struct {
+typedef struct diff_ctx_t {
ap_filter_t *output;
apr_pool_t *pool;
} diff_ctx_t;
@@ -3932,7 +3932,7 @@ move_resource(dav_resource *src,
}
-typedef struct {
+typedef struct walker_ctx_t {
/* the input walk parameters */
const dav_walk_params *params;
Modified: subversion/trunk/subversion/svn/blame-cmd.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/blame-cmd.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/blame-cmd.c (original)
+++ subversion/trunk/subversion/svn/blame-cmd.c Thu Dec 30 20:13:50 2010
@@ -37,7 +37,7 @@
#include "svn_private_config.h"
-typedef struct
+typedef struct blame_baton_t
{
svn_cl__opt_state_t *opt_state;
svn_stream_t *out;
Modified: subversion/trunk/subversion/svn/cl.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/cl.h?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/cl.h (original)
+++ subversion/trunk/subversion/svn/cl.h Thu Dec 30 20:13:50 2010
@@ -47,7 +47,7 @@ extern "C" {
/*** Option processing ***/
/* --accept actions */
-typedef enum
+typedef enum svn_cl__accept_t
{
/* invalid accept action */
svn_cl__accept_invalid = -2,
@@ -112,7 +112,7 @@ svn_cl__accept_from_word(const char *wor
/*** Mergeinfo flavors. ***/
/* --show-revs values */
-typedef enum {
+typedef enum svn_cl__show_revs_t {
svn_cl__show_revs_invalid = -1,
svn_cl__show_revs_merged,
svn_cl__show_revs_eligible
@@ -233,7 +233,7 @@ typedef struct svn_cl__opt_state_t
} svn_cl__opt_state_t;
-typedef struct
+typedef struct svn_cl__cmd_baton_t
{
svn_cl__opt_state_t *opt_state;
svn_client_ctx_t *ctx;
@@ -324,7 +324,7 @@ svn_cl__check_cancel(void *baton);
/* Various conflict-resolution callbacks. */
-typedef struct {
+typedef struct svn_cl__conflict_baton_t {
svn_cl__accept_t accept_which;
apr_hash_t *config;
const char *editor_cmd;
Modified: subversion/trunk/subversion/svn/main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/main.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/main.c (original)
+++ subversion/trunk/subversion/svn/main.c Thu Dec 30 20:13:50 2010
@@ -64,7 +64,7 @@
/* Add an identifier here for long options that don't have a short
option. Options that have both long and short options should just
use the short option letter as identifier. */
-typedef enum {
+typedef enum svn_cl__longopt_t {
opt_ancestor_path = SVN_OPT_FIRST_LONGOPT_ID,
opt_auth_password,
opt_auth_username,
Modified: subversion/trunk/subversion/svn/proplist-cmd.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/proplist-cmd.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/proplist-cmd.c (original)
+++ subversion/trunk/subversion/svn/proplist-cmd.c Thu Dec 30 20:13:50 2010
@@ -39,7 +39,7 @@
#include "svn_private_config.h"
-typedef struct
+typedef struct proplist_baton_t
{
svn_cl__opt_state_t *opt_state;
svn_boolean_t is_url;
Modified: subversion/trunk/subversion/svnserve/serve.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnserve/serve.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svnserve/serve.c (original)
+++ subversion/trunk/subversion/svnserve/serve.c Thu Dec 30 20:13:50 2010
@@ -59,7 +59,7 @@
#include "server.h"
-typedef struct {
+typedef struct commit_callback_baton_t {
apr_pool_t *pool;
svn_revnum_t *new_rev;
const char **date;
@@ -67,7 +67,7 @@ typedef struct {
const char **post_commit_err;
} commit_callback_baton_t;
-typedef struct {
+typedef struct report_driver_baton_t {
server_baton_t *sb;
const char *repos_url; /* Decoded repository URL. */
void *report_baton;
@@ -79,18 +79,18 @@ typedef struct {
svn_revnum_t *from_rev;
} report_driver_baton_t;
-typedef struct {
+typedef struct log_baton_t {
const char *fs_path;
svn_ra_svn_conn_t *conn;
int stack_depth;
} log_baton_t;
-typedef struct {
+typedef struct file_revs_baton_t {
svn_ra_svn_conn_t *conn;
apr_pool_t *pool; /* Pool provided in the handler call. */
} file_revs_baton_t;
-typedef struct {
+typedef struct fs_warning_baton_t {
server_baton_t *server;
svn_ra_svn_conn_t *conn;
apr_pool_t *pool;
Modified: subversion/trunk/subversion/svnsync/main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnsync/main.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svnsync/main.c (original)
+++ subversion/trunk/subversion/svnsync/main.c Thu Dec 30 20:13:50 2010
@@ -226,7 +226,7 @@ static const apr_getopt_option_t svnsync
{ 0, 0, 0, 0 }
};
-typedef struct {
+typedef struct opt_baton_t {
svn_boolean_t non_interactive;
svn_boolean_t trust_server_cert;
svn_boolean_t no_auth_cache;
@@ -355,7 +355,7 @@ get_lock(const svn_string_t **lock_strin
/* Baton for the various subcommands to share. */
-typedef struct {
+typedef struct subcommand_baton_t {
/* common to all subcommands */
apr_hash_t *config;
svn_ra_callbacks2_t source_callbacks;
@@ -930,7 +930,7 @@ open_target_session(svn_ra_session_t **t
}
/* Replay baton, used during sychnronization. */
-typedef struct {
+typedef struct replay_baton_t {
svn_ra_session_t *from_session;
svn_ra_session_t *to_session;
subcommand_baton_t *sb;
Modified: subversion/trunk/subversion/svnsync/sync.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnsync/sync.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/svnsync/sync.c (original)
+++ subversion/trunk/subversion/svnsync/sync.c Thu Dec 30 20:13:50 2010
@@ -137,7 +137,7 @@ svnsync_normalize_revprops(apr_hash_t *r
/* Edit baton */
-typedef struct {
+typedef struct edit_baton_t {
const svn_delta_editor_t *wrapped_editor;
void *wrapped_edit_baton;
const char *to_url; /* URL we're copying into, for correct copyfrom URLs */
@@ -155,7 +155,7 @@ typedef struct {
/* A dual-purpose baton for files and directories. */
-typedef struct {
+typedef struct node_baton_t {
void *edit_baton;
void *wrapped_node_baton;
} node_baton_t;
Modified: subversion/trunk/subversion/tests/libsvn_client/client-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_client/client-test.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_client/client-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_client/client-test.c Thu Dec 30 20:13:50 2010
@@ -36,7 +36,7 @@
#include "../svn_test.h"
#include "../svn_test_fs.h"
-typedef struct {
+typedef struct mergeinfo_catalog_item {
const char *path;
const char *unparsed_mergeinfo;
svn_boolean_t remains;
Modified: subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_repos/repos-test.c?rev=1053996&r1=1053995&r2=1053996&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_repos/repos-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_repos/repos-test.c Thu Dec 30 20:13:50 2010
@@ -2377,7 +2377,7 @@ get_logs(const svn_test_opts_t *opts,
/* Tests for svn_repos_get_file_revsN() */
-typedef struct {
+typedef struct file_revs_t {
svn_revnum_t rev;
const char *path;
svn_boolean_t result_of_merge;
Re: svn commit: r1053996 [1/2] - in /subversion/trunk/subversion:
include/ include/private/ libsvn_client/ libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/
libsvn_fs_fs/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/
libsvn_wc/ mod_authz_svn/
Posted by Branko Čibej <br...@xbc.nu>.
On 04.01.2011 16:44, Bert Huijben wrote:
>
>> -----Original Message-----
>> From: Branko Čibej [mailto:brane@xbc.nu]
>> Sent: dinsdag 4 januari 2011 16:27
>> To: dev@subversion.apache.org
>> Subject: Re: svn commit: r1053996 [1/2] - in
>> /subversion/trunk/subversion: include/ include/private/ libsvn_client/
>> libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/
>> libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/ libsvn_wc/
>> mod_authz_svn/
>>
>> I frankly see no reason at all to do this "everywhere", it's just
>> unnecessary code churn. The struct tags are only useful if the
>> structure
>> references itself (via pointers), and our practice for such cases was
>> to
>> declare the typedef first, and the struct itself below it, and use the
>> typedef name in the struct definition.
>>
>> So unless someone can explain the reasoning why all these anonymous
>> structs and enums etc. should have names -- on technical grounds, not
>> some stylistic hand-waving -- then please revert.
> 2 minor (but to me very useful) reasons to use an explicit name:
> * svn diff -x -p shows the structname this way, so it makes commit diffs more readable
> * Debuggers that handle typedefs as an alias for the struct (such as Visual Studio) show foo_t in the debugger output instead of __unnamed_ABCDEF (ABCDEF is a hex number which can change between compiler invocations).
Ah. The debugger thing is not a bad reason at all.
Personally I prefer this way:
typedef struct foo_t foo_t;
struct foo_t {};
but I like vermilion bikesheds, too.
-- Brane
RE: svn commit: r1053996 [1/2] - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/ libsvn_wc/ mod_authz_svn/
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Branko Čibej [mailto:brane@xbc.nu]
> Sent: dinsdag 4 januari 2011 16:27
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1053996 [1/2] - in
> /subversion/trunk/subversion: include/ include/private/ libsvn_client/
> libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/
> libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/ libsvn_wc/
> mod_authz_svn/
>
> I frankly see no reason at all to do this "everywhere", it's just
> unnecessary code churn. The struct tags are only useful if the
> structure
> references itself (via pointers), and our practice for such cases was
> to
> declare the typedef first, and the struct itself below it, and use the
> typedef name in the struct definition.
>
> So unless someone can explain the reasoning why all these anonymous
> structs and enums etc. should have names -- on technical grounds, not
> some stylistic hand-waving -- then please revert.
2 minor (but to me very useful) reasons to use an explicit name:
* svn diff -x -p shows the structname this way, so it makes commit diffs more readable
* Debuggers that handle typedefs as an alias for the struct (such as Visual Studio) show foo_t in the debugger output instead of __unnamed_ABCDEF (ABCDEF is a hex number which can change between compiler invocations).
Bert
Re: svn commit: r1053996 [1/2] - in /subversion/trunk/subversion:
include/ include/private/ libsvn_client/ libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/
libsvn_fs_fs/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/
libsvn_wc/ mod_authz_svn/ ...
Posted by Branko Čibej <br...@xbc.nu>.
On 04.01.2011 16:20, Philip Martin wrote:
> danielsh@apache.org writes:
>
>> Author: danielsh
>> Date: Thu Dec 30 20:13:50 2010
>> New Revision: 1053996
>>
>> URL: http://svn.apache.org/viewvc?rev=1053996&view=rev
>> Log:
>> Once and for all, name all our anonymous struct/enum typedefs.
>>
>> Follows up on r1040058, and with thanks to Danny Trebbien.
>>
>> * everywhere:
>> Change 'typedef struct {} foo_t;' to 'typedef struct foo_t {} foo_t;'.
> If there is a consensus that this is a good thing to do then we should
> add it to our coding guidelines
I frankly see no reason at all to do this "everywhere", it's just
unnecessary code churn. The struct tags are only useful if the structure
references itself (via pointers), and our practice for such cases was to
declare the typedef first, and the struct itself below it, and use the
typedef name in the struct definition.
So unless someone can explain the reasoning why all these anonymous
structs and enums etc. should have names -- on technical grounds, not
some stylistic hand-waving -- then please revert.
-- Brane
Re: svn commit: r1053996 [1/2] - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_diff/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_subr/ libsvn_wc/ mod_authz_svn/ ...
Posted by Philip Martin <ph...@wandisco.com>.
danielsh@apache.org writes:
> Author: danielsh
> Date: Thu Dec 30 20:13:50 2010
> New Revision: 1053996
>
> URL: http://svn.apache.org/viewvc?rev=1053996&view=rev
> Log:
> Once and for all, name all our anonymous struct/enum typedefs.
>
> Follows up on r1040058, and with thanks to Danny Trebbien.
>
> * everywhere:
> Change 'typedef struct {} foo_t;' to 'typedef struct foo_t {} foo_t;'.
If there is a consensus that this is a good thing to do then we should
add it to our coding guidelines.
--
Philip