You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Eric Covener <co...@gmail.com> on 2013/08/23 18:59:55 UTC
Re: svn commit: r1516930 - in /httpd/httpd/trunk: docs/manual/mod/mod_proxy.xml
modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c
modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=1516930&r1=1516929&r2=1516930&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Fri Aug 23 16:48:42 2013
> @@ -1975,13 +1975,25 @@ static int proxy_http_handler(request_re
> }
> }
>
> + /* Step Three-and-a-Half: See if the socket is still connected (if desired) */
> + if (worker->s->ping_timeout_set && worker->s->ping_timeout < 0 &&
> + !ap_proxy_is_socket_connected(backend->sock)) {
> + backend->close = 1;
> + ap_log_rerror(APLOG_MARK, APLOG_INFO, status, r, APLOGNO()
> + "socket check failed to %pI (%s)",
> + worker->cp->addr, worker->s->hostname);
> + retry++;
> + continue;
> + }
> +
This is already done in step 2 -- Is this to just narrow the window
between the check and writing the request, or is the previous check
not always happening.
Re: svn commit: r1516930 - in /httpd/httpd/trunk: docs/manual/mod/mod_proxy.xml modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Aug 23, 2013, at 12:59 PM, Eric Covener <co...@gmail.com> wrote:
>> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=1516930&r1=1516929&r2=1516930&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
>> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Fri Aug 23 16:48:42 2013
>> @@ -1975,13 +1975,25 @@ static int proxy_http_handler(request_re
>> }
>> }
>>
>> + /* Step Three-and-a-Half: See if the socket is still connected (if desired) */
>> + if (worker->s->ping_timeout_set && worker->s->ping_timeout < 0 &&
>> + !ap_proxy_is_socket_connected(backend->sock)) {
>> + backend->close = 1;
>> + ap_log_rerror(APLOG_MARK, APLOG_INFO, status, r, APLOGNO()
>> + "socket check failed to %pI (%s)",
>> + worker->cp->addr, worker->s->hostname);
>> + retry++;
>> + continue;
>> + }
>> +
>
> This is already done in step 2 -- Is this to just narrow the window
> between the check and writing the request, or is the previous check
> not always happening.
>
To narrow it. Esp if we just went through the whole process
of building one up.