You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Taher Alkhateeb <sl...@gmail.com> on 2015/10/23 10:10:28 UTC
Removing Javolution and resolving sax implementation - OFBIZ-5169
Hi everyone,
I need some help and guidance. I removed all remaining references to Javolution from the framework except for this one annoying dependency, and we cannot remove the jar before getting a different implementation.
So the code in EntitySaxReader.java depends on _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for importing data to the framework. And my question is, what is the recommended library replacement? I am thinking of using _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have other preferences for XML parsing in OFBiz?
Thank you for your help!
Taher Alkhateeb
Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi Jacques,
I'll issue a JIRA and start working on it as soon as I can. Right now I'm
focusing on Start.java trying to clean that up a little bit.
Taher Alkhateeb
On Tue, Jan 26, 2016 at 5:50 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Hi Taher,
>
> I think the best is to open a JIra to share the effort there. You might
> even reopen OFBIZ-2390...
>
> Thanks!
>
> Jacques
>
> Le 10/12/2015 11:21, Taher Alkhateeb a écrit :
>
>> Hi everyone,
>>
>> After studying EntitySaxReader.java to figure out a way to remove
>> javolution dependency I realized that the whole interface is dependent on
>> javolution, so even if I switch to xerces or other implementations I am
>> still left with dependencies that require a major rewrite. What makes
>> things even worse is that many parts of the framework depend on this
>> class.
>>
>> I think the class implementation is really ugly and hard to comprehend
>> with
>> no docs to interpret the functionality. Furthermore, many of the public
>> methods should not be public and the calls within the class are like
>> spaghetti.
>>
>> Can anyone guide me as to whether changing the signature is a problem for
>> the dependencies within the framework? I know for example
>> EntityDataLoader,
>> EntityData, and the web tools in WebToolsServices depend on it. So this
>> will be a big change and I'm not sure if this might break something else.
>>
>> Any clue from the seniors here on how to approach this. I got a major
>> headache looking at that darn thing?
>>
>> Taher Alkhateeb
>>
>> On Fri, Oct 23, 2015 at 5:42 PM, Adrian Crum <
>> adrian.crum@sandglass-software.com> wrote:
>>
>> https://docs.oracle.com/javase/tutorial/jaxp/sax/parsing.html
>>>
>>> https://issues.apache.org/jira/browse/OFBIZ-2390
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 10/23/2015 7:20 AM, Taher Alkhateeb wrote:
>>>
>>> Hi Adrian,
>>>>
>>>> I believe xerces also already exists in the project. Which one should I
>>>> prefer or use? Are there any existing utilities or things that would
>>>> shortcut my work?
>>>>
>>>> Taher Alkhateeb
>>>>
>>>> ----- Original Message -----
>>>>
>>>> From: "Adrian Crum" <ad...@sandglass-software.com>
>>>> To: dev@ofbiz.apache.org
>>>> Sent: Friday, 23 October, 2015 5:02:51 PM
>>>> Subject: Re: Removing Javolution and resolving sax implementation -
>>>> OFBIZ-5169
>>>>
>>>> Xerces would be fine, but we already have a pull parser in the project
>>>> (an XStream dependency):
>>>>
>>>> http://www.extreme.indiana.edu/xgws/xsoap/xpp/
>>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
>>>>
>>>> Hi everyone,
>>>>>
>>>>> I need some help and guidance. I removed all remaining references to
>>>>> Javolution from the framework except for this one annoying dependency,
>>>>> and
>>>>> we cannot remove the jar before getting a different implementation.
>>>>>
>>>>> So the code in EntitySaxReader.java depends on
>>>>> _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for
>>>>> importing data to the framework. And my question is, what is the
>>>>> recommended library replacement? I am thinking of using
>>>>> _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we
>>>>> have
>>>>> other preferences for XML parsing in OFBiz?
>>>>>
>>>>> Thank you for your help!
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>>>
>>>>>
>>>>
Re: Removing Javolution and resolving sax implementation -
OFBIZ-5169
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Taher,
I think the best is to open a JIra to share the effort there. You might even reopen OFBIZ-2390...
Thanks!
Jacques
Le 10/12/2015 11:21, Taher Alkhateeb a écrit :
> Hi everyone,
>
> After studying EntitySaxReader.java to figure out a way to remove
> javolution dependency I realized that the whole interface is dependent on
> javolution, so even if I switch to xerces or other implementations I am
> still left with dependencies that require a major rewrite. What makes
> things even worse is that many parts of the framework depend on this class.
>
> I think the class implementation is really ugly and hard to comprehend with
> no docs to interpret the functionality. Furthermore, many of the public
> methods should not be public and the calls within the class are like
> spaghetti.
>
> Can anyone guide me as to whether changing the signature is a problem for
> the dependencies within the framework? I know for example EntityDataLoader,
> EntityData, and the web tools in WebToolsServices depend on it. So this
> will be a big change and I'm not sure if this might break something else.
>
> Any clue from the seniors here on how to approach this. I got a major
> headache looking at that darn thing?
>
> Taher Alkhateeb
>
> On Fri, Oct 23, 2015 at 5:42 PM, Adrian Crum <
> adrian.crum@sandglass-software.com> wrote:
>
>> https://docs.oracle.com/javase/tutorial/jaxp/sax/parsing.html
>>
>> https://issues.apache.org/jira/browse/OFBIZ-2390
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 10/23/2015 7:20 AM, Taher Alkhateeb wrote:
>>
>>> Hi Adrian,
>>>
>>> I believe xerces also already exists in the project. Which one should I
>>> prefer or use? Are there any existing utilities or things that would
>>> shortcut my work?
>>>
>>> Taher Alkhateeb
>>>
>>> ----- Original Message -----
>>>
>>> From: "Adrian Crum" <ad...@sandglass-software.com>
>>> To: dev@ofbiz.apache.org
>>> Sent: Friday, 23 October, 2015 5:02:51 PM
>>> Subject: Re: Removing Javolution and resolving sax implementation -
>>> OFBIZ-5169
>>>
>>> Xerces would be fine, but we already have a pull parser in the project
>>> (an XStream dependency):
>>>
>>> http://www.extreme.indiana.edu/xgws/xsoap/xpp/
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> I need some help and guidance. I removed all remaining references to
>>>> Javolution from the framework except for this one annoying dependency, and
>>>> we cannot remove the jar before getting a different implementation.
>>>>
>>>> So the code in EntitySaxReader.java depends on
>>>> _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for
>>>> importing data to the framework. And my question is, what is the
>>>> recommended library replacement? I am thinking of using
>>>> _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have
>>>> other preferences for XML parsing in OFBiz?
>>>>
>>>> Thank you for your help!
>>>>
>>>> Taher Alkhateeb
>>>>
>>>>
>>>
Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi everyone,
After studying EntitySaxReader.java to figure out a way to remove
javolution dependency I realized that the whole interface is dependent on
javolution, so even if I switch to xerces or other implementations I am
still left with dependencies that require a major rewrite. What makes
things even worse is that many parts of the framework depend on this class.
I think the class implementation is really ugly and hard to comprehend with
no docs to interpret the functionality. Furthermore, many of the public
methods should not be public and the calls within the class are like
spaghetti.
Can anyone guide me as to whether changing the signature is a problem for
the dependencies within the framework? I know for example EntityDataLoader,
EntityData, and the web tools in WebToolsServices depend on it. So this
will be a big change and I'm not sure if this might break something else.
Any clue from the seniors here on how to approach this. I got a major
headache looking at that darn thing?
Taher Alkhateeb
On Fri, Oct 23, 2015 at 5:42 PM, Adrian Crum <
adrian.crum@sandglass-software.com> wrote:
> https://docs.oracle.com/javase/tutorial/jaxp/sax/parsing.html
>
> https://issues.apache.org/jira/browse/OFBIZ-2390
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 10/23/2015 7:20 AM, Taher Alkhateeb wrote:
>
>> Hi Adrian,
>>
>> I believe xerces also already exists in the project. Which one should I
>> prefer or use? Are there any existing utilities or things that would
>> shortcut my work?
>>
>> Taher Alkhateeb
>>
>> ----- Original Message -----
>>
>> From: "Adrian Crum" <ad...@sandglass-software.com>
>> To: dev@ofbiz.apache.org
>> Sent: Friday, 23 October, 2015 5:02:51 PM
>> Subject: Re: Removing Javolution and resolving sax implementation -
>> OFBIZ-5169
>>
>> Xerces would be fine, but we already have a pull parser in the project
>> (an XStream dependency):
>>
>> http://www.extreme.indiana.edu/xgws/xsoap/xpp/
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
>>
>>> Hi everyone,
>>>
>>> I need some help and guidance. I removed all remaining references to
>>> Javolution from the framework except for this one annoying dependency, and
>>> we cannot remove the jar before getting a different implementation.
>>>
>>> So the code in EntitySaxReader.java depends on
>>> _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for
>>> importing data to the framework. And my question is, what is the
>>> recommended library replacement? I am thinking of using
>>> _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have
>>> other preferences for XML parsing in OFBiz?
>>>
>>> Thank you for your help!
>>>
>>> Taher Alkhateeb
>>>
>>>
>>
>>
Re: Removing Javolution and resolving sax implementation -
OFBIZ-5169
Posted by Taher Alkhateeb <sl...@gmail.com>.
Excellent, there's even a patch! Thank you.
----- Original Message -----
From: "Adrian Crum" <ad...@sandglass-software.com>
To: dev@ofbiz.apache.org
Sent: Friday, 23 October, 2015 5:42:56 PM
Subject: Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
https://docs.oracle.com/javase/tutorial/jaxp/sax/parsing.html
https://issues.apache.org/jira/browse/OFBIZ-2390
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/23/2015 7:20 AM, Taher Alkhateeb wrote:
> Hi Adrian,
>
> I believe xerces also already exists in the project. Which one should I prefer or use? Are there any existing utilities or things that would shortcut my work?
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Adrian Crum" <ad...@sandglass-software.com>
> To: dev@ofbiz.apache.org
> Sent: Friday, 23 October, 2015 5:02:51 PM
> Subject: Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
>
> Xerces would be fine, but we already have a pull parser in the project
> (an XStream dependency):
>
> http://www.extreme.indiana.edu/xgws/xsoap/xpp/
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
>> Hi everyone,
>>
>> I need some help and guidance. I removed all remaining references to Javolution from the framework except for this one annoying dependency, and we cannot remove the jar before getting a different implementation.
>>
>> So the code in EntitySaxReader.java depends on _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for importing data to the framework. And my question is, what is the recommended library replacement? I am thinking of using _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have other preferences for XML parsing in OFBiz?
>>
>> Thank you for your help!
>>
>> Taher Alkhateeb
>>
>
>
Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
Posted by Adrian Crum <ad...@sandglass-software.com>.
https://docs.oracle.com/javase/tutorial/jaxp/sax/parsing.html
https://issues.apache.org/jira/browse/OFBIZ-2390
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/23/2015 7:20 AM, Taher Alkhateeb wrote:
> Hi Adrian,
>
> I believe xerces also already exists in the project. Which one should I prefer or use? Are there any existing utilities or things that would shortcut my work?
>
> Taher Alkhateeb
>
> ----- Original Message -----
>
> From: "Adrian Crum" <ad...@sandglass-software.com>
> To: dev@ofbiz.apache.org
> Sent: Friday, 23 October, 2015 5:02:51 PM
> Subject: Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
>
> Xerces would be fine, but we already have a pull parser in the project
> (an XStream dependency):
>
> http://www.extreme.indiana.edu/xgws/xsoap/xpp/
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
>> Hi everyone,
>>
>> I need some help and guidance. I removed all remaining references to Javolution from the framework except for this one annoying dependency, and we cannot remove the jar before getting a different implementation.
>>
>> So the code in EntitySaxReader.java depends on _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for importing data to the framework. And my question is, what is the recommended library replacement? I am thinking of using _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have other preferences for XML parsing in OFBiz?
>>
>> Thank you for your help!
>>
>> Taher Alkhateeb
>>
>
>
Re: Removing Javolution and resolving sax implementation -
OFBIZ-5169
Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi Adrian,
I believe xerces also already exists in the project. Which one should I prefer or use? Are there any existing utilities or things that would shortcut my work?
Taher Alkhateeb
----- Original Message -----
From: "Adrian Crum" <ad...@sandglass-software.com>
To: dev@ofbiz.apache.org
Sent: Friday, 23 October, 2015 5:02:51 PM
Subject: Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
Xerces would be fine, but we already have a pull parser in the project
(an XStream dependency):
http://www.extreme.indiana.edu/xgws/xsoap/xpp/
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
> Hi everyone,
>
> I need some help and guidance. I removed all remaining references to Javolution from the framework except for this one annoying dependency, and we cannot remove the jar before getting a different implementation.
>
> So the code in EntitySaxReader.java depends on _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for importing data to the framework. And my question is, what is the recommended library replacement? I am thinking of using _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have other preferences for XML parsing in OFBiz?
>
> Thank you for your help!
>
> Taher Alkhateeb
>
Re: Removing Javolution and resolving sax implementation - OFBIZ-5169
Posted by Adrian Crum <ad...@sandglass-software.com>.
Xerces would be fine, but we already have a pull parser in the project
(an XStream dependency):
http://www.extreme.indiana.edu/xgws/xsoap/xpp/
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 10/23/2015 1:10 AM, Taher Alkhateeb wrote:
> Hi everyone,
>
> I need some help and guidance. I removed all remaining references to Javolution from the framework except for this one annoying dependency, and we cannot remove the jar before getting a different implementation.
>
> So the code in EntitySaxReader.java depends on _javolution.xml.sax.XMLReaderImpl_ for implementing the Sax parser for importing data to the framework. And my question is, what is the recommended library replacement? I am thinking of using _org.apache.xerces.parsers.SAXParser_. Am I on the right path or do we have other preferences for XML parsing in OFBiz?
>
> Thank you for your help!
>
> Taher Alkhateeb
>