[jira] Commented: (DERBY-3889) LOBStreamControl.truncate() doesn't delete temporary files

["Kristian Waagan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639005#action_12639005 ] 

Kristian Waagan commented on DERBY-3889:
----------------------------------------

The patch looks good to me. The refactoring makes it easer to write correct code.
+1 to commit

I reviewed the code and ran the repro. Without the patch I observed thousands of temporary files, and with the patch the ls command showed zero or one file in the tmp directory. I have also started the regression tests.

> LOBStreamControl.truncate() doesn't delete temporary files
> ----------------------------------------------------------
>
>                 Key: DERBY-3889
>                 URL: https://issues.apache.org/jira/browse/DERBY-3889
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.3.1.4, 10.4.2.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: derby-3889-1a.diff, derby-3889-1a.stat, TruncateClob.java
>
>
> If LOBStreamControl.truncate() reduces the size of the lob so that it fits in the internal buffer, it closes the temporary file, but it doesn't remove it. See the attached Java class (TruncateClob.java) which fills the tmp directory with temporary lob files, even if each lob is explicitly freed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.