You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/09/15 15:46:36 UTC

Review Request 38404: Remove workaround code in PhoenixTransactSQL.prepareGetLatestMetricSqlStmt()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38404/
-----------------------------------------------------------

Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-13103
    https://issues.apache.org/jira/browse/AMBARI-13103


Repository: ambari


Description
-------

Remove workaround for single hostname queries from AMS code, after patched phoenix-core is available in maven repo.


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 77652dc 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 8693a21 

Diff: https://reviews.apache.org/r/38404/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 38404: Remove workaround code in PhoenixTransactSQL.prepareGetLatestMetricSqlStmt()

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38404/#review99025
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Вер. 15, 2015, 1:46 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38404/
> -----------------------------------------------------------
> 
> (Updated Вер. 15, 2015, 1:46 після полудня)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13103
>     https://issues.apache.org/jira/browse/AMBARI-13103
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove workaround for single hostname queries from AMS code, after patched phoenix-core is available in maven repo.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 77652dc 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 8693a21 
> 
> Diff: https://reviews.apache.org/r/38404/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 38404: Remove workaround code in PhoenixTransactSQL.prepareGetLatestMetricSqlStmt()

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38404/
-----------------------------------------------------------

(Updated Сен. 15, 2015, 2:14 п.п.)


Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-13103
    https://issues.apache.org/jira/browse/AMBARI-13103


Repository: ambari


Description
-------

Remove workaround for single hostname queries from AMS code, after patched phoenix-core is available in maven repo.


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 77652dc 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java 8693a21 

Diff: https://reviews.apache.org/r/38404/diff/


Testing (updated)
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] ambari-metrics .................................... SUCCESS [1.157s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.739s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.614s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.948s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.067s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.218s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [23:01.533s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [1.191s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [3:40.908s]


Thanks,

Dmytro Sen