[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1168: Fix: use triple v0.1.2, split dubbogo from triple

[GitBox <gi...@apache.org>]

gaoxinge commented on a change in pull request #1168:
URL: https://github.com/apache/dubbo-go/pull/1168#discussion_r617183722



##########
File path: registry/nacos/registry_test.go
##########
@@ -65,6 +65,7 @@ func TestNacosRegistry_Register(t *testing.T) {
 		t.Errorf("register error:%s \n", err.Error())
 		return
 	}
+	time.Sleep(time.Second)

Review comment:
       Why add sleep?

##########
File path: registry/consul/service_discovery.go
##########
@@ -38,6 +38,7 @@ import (
 	"github.com/apache/dubbo-go/common/extension"
 	"github.com/apache/dubbo-go/common/logger"
 	"github.com/apache/dubbo-go/config"
+	_ "github.com/apache/dubbo-go/metadata/mapping/memory"

Review comment:
       Why import `_ "github.com/apache/dubbo-go/metadata/mapping/memory"`?

##########
File path: registry/zookeeper/service_discovery_test.go
##########
@@ -64,6 +65,8 @@ func TestNewZookeeperServiceDiscovery(t *testing.T) {
 	name := "zookeeper1"
 	_, err := newZookeeperServiceDiscovery(name)
 
+	time.Sleep(time.Second)

Review comment:
       Why add sleep?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org