You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/17 02:13:04 UTC

[GitHub] [kafka] hachikuji edited a comment on pull request #11767: KAFKA-13598: set log4j appender to default acks

hachikuji edited a comment on pull request #11767:
URL: https://github.com/apache/kafka/pull/11767#issuecomment-1042497943


   > Yes, I don't know the getters serve any purpose, either. But I'm still worried that there's someone relying on it. 
   I'd like to hear what @hachikuji 's thought since he did the change to make `requiredNumAcks` to 1 in this PR: https://github.com/apache/kafka/pull/5425#discussion_r205861230
   
   Unfair to mention a PR from 4 years ago 😉 . Regardless whether anyone actually uses this class, it does seem weird to have getters that we know are broken. I agree it seems better to initialize the defaults explicitly (and to use types consistently). Perhaps we may as well fix the other broken getters while we're at it. At a quick glance, it looks like `maxBlockMs` is the only other one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org