[GitHub] merlimat commented on a change in pull request #626: Reduce memory settings for LocalBookieEsemble in tests mode

[gi...@git.apache.org]

merlimat commented on a change in pull request #626: Reduce memory settings for LocalBookieEsemble in tests mode
URL: https://github.com/apache/incubator-pulsar/pull/626#discussion_r130989284
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
 ##########
 @@ -149,7 +149,7 @@ void start() throws Exception {
         if (!onlyBroker) {
             // Start LocalBookKeeper
             bkEnsemble = new LocalBookkeeperEnsemble(numOfBk, zkPort, bkPort, zkDir, bkDir, wipeData);
-            bkEnsemble.start();
+            bkEnsemble.startStandalone();
 
 Review comment:
   No, I left that calling `start()` starts the "low-memory" bookie, while `startStandalone()` is what we use for the `bin/pulsar standalone` command.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services