You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/05/07 17:06:35 UTC
[kudu-CR] KUDU-2677 Raise default value for --tablet history max age sec
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13265
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec
......................................................................
KUDU-2677 Raise default value for --tablet_history_max_age_sec
This raises the default --tablet_history_max_age_sec to 1 week, to
support incremental backup and the diff scans it relies on.
Raising the default will cause clients to be able to scan further into
the past before, into a region where the data has been GC'd. This
condition will be temporarily, and will end when the new default period
has passed. We don't expect this to be a problem because we don't think
many users are doing scans like this, and if they are they probably
adjusted --tablet_history_max_age_sec and so won't be affected by the
change in default. If they want to raise their own setting for the flag
to accomodate incremental backups then they will be able to take steps
to mitigate the above issue.
Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
---
M src/kudu/tablet/tablet.cc
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/13265/1
--
To view, visit http://gerrit.cloudera.org:8080/13265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Gerrit-Change-Number: 13265
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2677 Raise default value for --tablet history max age sec
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13265 )
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Gerrit-Change-Number: 13265
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 08 May 2019 19:43:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2677 Raise default value for --tablet history max age sec
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13265 )
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec
......................................................................
KUDU-2677 Raise default value for --tablet_history_max_age_sec
This raises the default --tablet_history_max_age_sec to 1 week, to
support incremental backup and the diff scans it relies on.
Raising the default will cause clients to be able to scan further into
the past, possibly into a region where the data has been GC'd. This
would result in no rows returned, which might be surprising to some
users. This condition will be temporary, and will end when the new
default period has passed. We don't expect this to be a problem because
we don't think many users are doing scans like this, and if they are
they probably adjusted --tablet_history_max_age_sec and so won't be
affected by the change in default. If they want to raise their own
setting for the flag to accomodate incremental backups then they will
be able to take steps to mitigate the above issue.
Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Reviewed-on: http://gerrit.cloudera.org:8080/13265
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/tablet.cc
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Gerrit-Change-Number: 13265
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2677 Raise default value for --tablet history max age sec
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13265
to look at the new patch set (#2).
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec
......................................................................
KUDU-2677 Raise default value for --tablet_history_max_age_sec
This raises the default --tablet_history_max_age_sec to 1 week, to
support incremental backup and the diff scans it relies on.
Raising the default will cause clients to be able to scan further into
the past, possibly into a region where the data has been GC'd. This
would result in no rows returned, which might be surprising to some
users. This condition will be temporary, and will end when the new
default period has passed. We don't expect this to be a problem because
we don't think many users are doing scans like this, and if they are
they probably adjusted --tablet_history_max_age_sec and so won't be
affected by the change in default. If they want to raise their own
setting for the flag to accomodate incremental backups then they will
be able to take steps to mitigate the above issue.
Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
---
M src/kudu/tablet/tablet.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/13265/2
--
To view, visit http://gerrit.cloudera.org:8080/13265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Gerrit-Change-Number: 13265
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2677 Raise default value for --tablet history max age sec
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13265 )
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG@12
PS1, Line 12: Raising the default will cause clients to be able to scan further into
: the past before, into a region where the data has been GC'd.
> What happens if you try to scan into this region?
Done
http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG@14
PS1, Line 14: condition will be temporarily, and will end when the new default period
> temporary
Done
http://gerrit.cloudera.org:8080/#/c/13265/1/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/13265/1/src/kudu/tablet/tablet.cc@137
PS1, Line 137: DEFINE_int32(tablet_history_max_age_sec, 60 * 60 * 24 * 7,
> Should probably also stabilize this flag if we expect configuration managem
Done
--
To view, visit http://gerrit.cloudera.org:8080/13265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Gerrit-Change-Number: 13265
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 08 May 2019 19:34:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2677 Raise default value for --tablet history max age sec
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13265 )
Change subject: KUDU-2677 Raise default value for --tablet_history_max_age_sec
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG@12
PS1, Line 12: Raising the default will cause clients to be able to scan further into
: the past before, into a region where the data has been GC'd.
What happens if you try to scan into this region?
http://gerrit.cloudera.org:8080/#/c/13265/1//COMMIT_MSG@14
PS1, Line 14: condition will be temporarily, and will end when the new default period
temporary
http://gerrit.cloudera.org:8080/#/c/13265/1/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/13265/1/src/kudu/tablet/tablet.cc@137
PS1, Line 137: DEFINE_int32(tablet_history_max_age_sec, 60 * 60 * 24 * 7,
Should probably also stabilize this flag if we expect configuration management tools to expose it.
--
To view, visit http://gerrit.cloudera.org:8080/13265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6398b57ec1abcd12c59a3588dd1a61900c0ccdeb
Gerrit-Change-Number: 13265
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 May 2019 17:35:47 +0000
Gerrit-HasComments: Yes