[GitHub] [helix] alirezazamani commented on a change in pull request #1583: Fix redundant workflow context updates for finised workflows

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1583:
URL: https://github.com/apache/helix/pull/1583#discussion_r539503790



##########
File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
##########
@@ -217,7 +217,6 @@ public void assignWorkflow(String workflow, WorkflowConfig workflowCfg,
     } else {
       LOG.debug("Workflow {} is not ready to be scheduled.", workflow);
     }
-    _clusterDataCache.updateWorkflowContext(workflow, workflowCtx);

Review comment:
       This update is not necessary. When there is a job that needs to be scheduled, we update the workflow context there. If there is no job, then we do not need to update the workflow context




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org