You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2002/04/10 22:04:04 UTC
Re: svn commit: rev 1662 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr
On Wed, Apr 10, 2002 at 12:29:29AM -0500, kfogel@tigris.org wrote:
>...
> * subversion/include/svn_io.h
> (svn_io__filesizes_different_p): Replaces formerly static function
> filesizes_definitely_different_p, but now takes `const char *'
> instead of `svn_stringbuf_t *'. All callers changed.
>
> * subversion/libsvn_subr/io.c
> (svn_io__filesizes_different_p): Code from questions.c, see above.
That is part of the public interface, so it shouldn't have two underscores
after the "svn_io" portion.
>...
> +++ trunk/subversion/libsvn_wc/questions.h Wed Apr 10 00:29:12 2002
>...
> + * history and logs, available at http://subversion.tigris.org/.
> + * ====================================================================
> + */
> +
> +
> +#include <apr_pools.h>
> +#include "svn_types.h"
> +#include "svn_string.h"
> +#include "svn_error.h"
Even private headers must have guards and the C++ stuff.
>...
> +++ trunk/subversion/libsvn_wc/translate.h Wed Apr 10 00:29:12 2002
Same.
>...
> +++ trunk/subversion/libsvn_wc/props.h Wed Apr 10 00:29:13 2002
Same.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1662 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Greg Stein <gs...@lyra.org> writes:
> That is part of the public interface, so it shouldn't have two underscores
> after the "svn_io" portion.
Bing! Nice catch, thanks!
> >...
> > +++ trunk/subversion/libsvn_wc/questions.h Wed Apr 10 00:29:12 2002
> >...
> > + * history and logs, available at http://subversion.tigris.org/.
> > + * ====================================================================
> > + */
> > +
> > +
> > +#include <apr_pools.h>
> > +#include "svn_types.h"
> > +#include "svn_string.h"
> > +#include "svn_error.h"
>
> Even private headers must have guards and the C++ stuff.
Thanks again (and same for the next two).
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org