You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 21:51:41 UTC

[GitHub] [arrow] alippai edited a comment on pull request #10181: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API in NodeJS

alippai edited a comment on pull request #10181:
URL: https://github.com/apache/arrow/pull/10181#issuecomment-841520624


   During benchmarking it I realized that we already use TextEncoder and TextDecoder only.
   `useNativeEncoders` is always evaluated to `true` in all supported Node versions and it takes precedence over `_Buffer`
   https://github.com/apache/arrow/blob/f47703e5237aca8cc081e140fd8a6120492649db/js/src/util/utf8.ts#L27-L34


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org