[GitHub] [hive] jfsii commented on a diff in pull request #3256: HIVE-26188: Query level cache and HMS local cache doesn't work locally and with Explain statements.

[GitBox <gi...@apache.org>]

jfsii commented on code in PR #3256:
URL: https://github.com/apache/hive/pull/3256#discussion_r870597220


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java:
##########
@@ -282,4 +282,11 @@ public boolean skipAuthorization() {
     }
     return super.skipAuthorization();
   }
+
+  @Override
+  public void startAnalysis() {
+    if (conf.getBoolVar(HiveConf.ConfVars.HIVE_OPTIMIZE_HMS_QUERY_CACHE_ENABLED)) {
+      queryState.createHMSCache();

Review Comment:
   @kgyrtkirk I think the reason I initially did not have it for the other analyzers is that I could not prove it was safe easily -
   I.E. For DDL I could imagine maybe there are situations in which we do not want the original metadata cached and we want to fetch the updated metadata after modification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org