You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "vernedeng (via GitHub)" <gi...@apache.org> on 2023/07/12 09:18:23 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #8513: [INLONG-8511][Manager] Add admin permission for public tenant to all users
vernedeng opened a new pull request, #8513:
URL: https://github.com/apache/inlong/pull/8513
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #8511
### Motivation
Add admin permission of public tenant to all users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #8513: [INLONG-8511][Manager] Add admin permission of public tenant to all users
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8513:
URL: https://github.com/apache/inlong/pull/8513#discussion_r1261332493
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/TenantRoleServiceImpl.java:
##########
@@ -137,4 +139,14 @@ public Boolean delete(Integer id) {
return true;
}
+ @Override
+ public int saveDefault(String username, String operator) {
Review Comment:
Please change the return type to `Integer` in service or controller layer, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #8513: [INLONG-8511][Manager] Add admin permission of public tenant to all users
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8513:
URL: https://github.com/apache/inlong/pull/8513#discussion_r1261330007
##########
inlong-manager/manager-web/sql/changes-1.8.0.sql:
##########
@@ -78,6 +78,10 @@ ALTER TABLE tenant_user_role
CREATE INDEX index_tenant
ON tenant_user_role (tenant, is_deleted);
+INSERT INTO tenant_user_role(username, role_code, tenant, creator)
Review Comment:
Why 1.8.0, not 1.9.0?
##########
inlong-manager/manager-web/sql/changes-1.8.0.sql:
##########
@@ -78,6 +78,10 @@ ALTER TABLE tenant_user_role
CREATE INDEX index_tenant
ON tenant_user_role (tenant, is_deleted);
+INSERT INTO tenant_user_role(username, role_code, tenant, creator)
Review Comment:
Why change in 1.8.0, not in 1.9.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #8513: [INLONG-8511][Manager] Add admin permission of public tenant to all users
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #8513:
URL: https://github.com/apache/inlong/pull/8513#discussion_r1261891867
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/TenantRoleServiceImpl.java:
##########
@@ -137,4 +139,14 @@ public Boolean delete(Integer id) {
return true;
}
+ @Override
+ public int saveDefault(String username, String operator) {
Review Comment:
fixed, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #8513: [INLONG-8511][Manager] Add admin permission of public tenant to all users
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #8513:
URL: https://github.com/apache/inlong/pull/8513#discussion_r1261891423
##########
inlong-manager/manager-web/sql/changes-1.8.0.sql:
##########
@@ -78,6 +78,10 @@ ALTER TABLE tenant_user_role
CREATE INDEX index_tenant
ON tenant_user_role (tenant, is_deleted);
+INSERT INTO tenant_user_role(username, role_code, tenant, creator)
Review Comment:
This is a bugfix for 1.8.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #8513: [INLONG-8511][Manager] Add admin permission of public tenant to all users
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8513:
URL: https://github.com/apache/inlong/pull/8513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org