[GitHub] marcoabreu commented on a change in pull request #11636: [MXNET-769] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #11636: [MXNET-769] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()
URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r206911742
 
 

 ##########
 File path: src/executor/graph_executor.cc
 ##########
 @@ -1282,7 +1282,7 @@ void GraphExecutor::InitDataEntryMemory(std::vector<NDArray>* shared_pool) {
   for (size_t i = 0; i < pool_info.size(); i++) {
     sorted_pool_index.push_back(i);
   }
-  auto pool_comparator = [&pool_info](int lhs, int rhs){
+  auto pool_comparator = [&pool_info](size_t lhs, size_t rhs){
 
 Review comment:
   To keep concerns separate

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services