You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/25 22:13:24 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8099: Allow resizing width of SQL Lab left bar / editor

codecov-io commented on issue #8099: Allow resizing width of SQL Lab left bar / editor
URL: https://github.com/apache/incubator-superset/pull/8099#issuecomment-524668616
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=h1) Report
   > Merging [#8099](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/279307c602c3f9537e1e8e5f2a2f26abaf85b07a?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8099/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #8099      +/-   ##
   =========================================
   - Coverage   65.93%   65.9%   -0.04%     
   =========================================
     Files         485     485              
     Lines       22887   22925      +38     
     Branches     2521    2538      +17     
   =========================================
   + Hits        15090   15108      +18     
   - Misses       7666    7685      +19     
   - Partials      131     132       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: |
   | [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `57.66% <100%> (+2.27%)` | :arrow_up: |
   | [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQ29udHJvbFBhbmVsc0NvbnRhaW5lci5qc3g=) | `68.35% <0%> (-11.65%)` | :arrow_down: |
   | [...uperset/assets/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Tb3V0aFBhbmUuanN4) | `85.71% <0%> (-5.72%)` | :arrow_down: |
   | [superset/assets/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xVdGlscy5qcw==) | `94.8% <0%> (-2.21%)` | :arrow_down: |
   | [superset/assets/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3N0b3JlLmpz) | `92.3% <0%> (-1.45%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `76.84% <0%> (-0.17%)` | :arrow_down: |
   | [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.85% <0%> (ø)` | :arrow_up: |
   | [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/8099/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `33.33% <0%> (+1.75%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=footer). Last update [279307c...e8fe5b9](https://codecov.io/gh/apache/incubator-superset/pull/8099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org