You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Davis <pe...@pdavis.cx> on 2002/08/11 18:41:16 UTC

Re: [Issue 864] Changed - 'svn rm --force' a scheduled (not committed) directory tree fails with locking errors

I filed two issues, and you incorrectly changed the summary on one of them to 
match the other (maybe you got them confused?)  The cleanup problem has 
nothing to do with deleting directories that are missing.  It has to do with 
deleting trees (a directory with one or more subdirectories).

I would have just made a comment to the issue, but I can't figure out how to 
do that.  Maybe I don't have access?  Why can I file an issue but cannot 
respond to comments on my own issue :)?


Anyway, I'll try and repro with HEAD and update.

On Sunday 11 August 2002 06:46, issues@subversion.tigris.org wrote:
> http://subversion.tigris.org/issues/show_bug.cgi?id=864
>
> *** Old
> --- New
> ***************
> *** 54,56 ****
> --- 54,62 ----
>   $ svn mkdir a
>   $ svn rm --force a
>   [works]
> +
> + ------- Additional Comments From philip@tigris.org  2002-08-11 06:46 PDT
> ------- + This is a known problem with the path joining code (well, known
> to me + anyway :-). I came across the problem while working on my next
> issue + 749 patch. I've fixed it and it will get checked in once it passes
> the + regression tests.
> \ No newline at end of file
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: issues-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: issues-help@subversion.tigris.org

-- 
Peter Davis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 864] Changed - 'svn rm --force' a scheduled (not committed) directory tree fails with locking errors

Posted by Philip Martin <ph...@codematters.co.uk>.
[I didn't notice that these had the wrong CC (dev@subissue instead of
 dev@subversion), I believe Peter intended this discussion to be on
 the list.]

Philip Martin <ph...@codematters.co.uk> writes:

> Peter Davis <pe...@pdavis.cx> writes:
> 
> > On Sunday 11 August 2002 12:08, you wrote:
> > > Does 'svn rm --force /path/to/wc/a' work when 'svn rm --force a' fails?
> > 
> > Yup.
> 
> Hmm, in that case is there any possibility that you actually running
> an old version and not rev 2940?
> 
> I'm not prepared to back out my 749 patches to debug it at the moment.
> If you want to have a go set a break point on svn_wc_adm_open and look
> at the paths that get passed in. The problem was that some paths had a
> "./" prefix, so "." "./a" and "./a/b" were opened and none of those
> matched "a/b".  With rev 2940 ".", "a" and "a/b" should be opened.
> 
> > 
> > > It also helps if you can raise one issue for one problem :-)
> > 
> > Did I not?  One issue for deleting missing dirs, and one for deleting 
> > not-missing dirs with subdirs (which includes the problem with 'svn cleanup' 
> > not recursing into scheduled dirs in the workaround). :->
> 
> Issue 864 mentions the rm locking problem, a non-recursive cleanup
> problem and a feature request for deletion of missing directories.
> That's three things in one issue :-)



Philip Martin <ph...@codematters.co.uk> writes:

> Philip Martin <ph...@codematters.co.uk> writes:
> 
> > Peter Davis <pe...@pdavis.cx> writes:
> > 
> > > On Sunday 11 August 2002 12:08, you wrote:
> > > > Does 'svn rm --force /path/to/wc/a' work when 'svn rm --force a' fails?
> > > 
> > > Yup.
> > 
> > Hmm, in that case is there any possibility that you actually running
> > an old version and not rev 2940?
> 
> OK, having checked in r2941, I can now try r2940, and yes it
> fails.  Sorry about that.  It *is* fixed in r2941.


-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 864] Changed - 'svn rm --force' a scheduled (not committed) directory tree fails with locking errors

Posted by Philip Martin <ph...@codematters.co.uk>.
Peter Davis <pe...@pdavis.cx> writes:

> I filed two issues, and you incorrectly changed the summary on one of them to 
> match the other (maybe you got them confused?)  The cleanup problem has 
> nothing to do with deleting directories that are missing.  It has to do with 
> deleting trees (a directory with one or more subdirectories).

Apologies if I got it wrong.  It may be the patches I have for issue
749 are giving me different results, but it is fixed in my tree.  The
"Working copy not locked" problem looks exactly like the one I fixed
with rev 2938.  If it's not fixed now it will get fixed when I check
in my issue 749 patch.

Does 'svn rm --force /path/to/wc/a' work when 'svn rm --force a' fails?

It also helps if you can raise one issue for one problem :-)

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Issue 864] Changed - 'svn rm --force' a scheduled (not committed) directory tree fails with locking errors

Posted by Peter Davis <pe...@pdavis.cx>.
On Sunday 11 August 2002 11:41, Peter Davis wrote:
> Anyway, I'll try and repro with HEAD and update.

Both bugs still occur exactly as I filed them as of 2940.

$ svn mkdir a a/b
$ svn rm --force a       # fails
$ svn rm --force a/b     # works
$ svn cleanup            # no error (but doesn't work)
$ svn rm --force a       # still fails
$ svn cleanup a          # works
$ svn rm --force a       # works

-- 
Peter Davis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org