[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #18759: [fix](planner) fix pr "using crchash replace murmurhash in the runtime filter"

["BiteTheDDDDt (via GitHub)" <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #18759:
URL: https://github.com/apache/doris/pull/18759#discussion_r1171046981


##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -463,6 +513,15 @@ class BloomFilterFunc final : public BloomFilterFuncBase {
         return dummy.find(*_bloom_filter, data);
     }
 
+    // This function is only to be used if the be_exec_version may be less than 2. If updated, please delete it.
+    bool find_crc32_hash(const void* data) const override {
+        if constexpr (std::is_same_v<typename BloomFilterTypeTraits<type>::FindOp, StringFindOp>) {

Review Comment:
   maybe `FixedStringFindOp` can use new hash also.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org