You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Wenchen Fan (Jira)" <ji...@apache.org> on 2019/10/02 03:47:00 UTC

[jira] [Resolved] (SPARK-29310) TestMemoryManager should implement getExecutionMemoryUsageForTask()

     [ https://issues.apache.org/jira/browse/SPARK-29310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wenchen Fan resolved SPARK-29310.
---------------------------------
    Fix Version/s: 3.0.0
       Resolution: Fixed

Issue resolved by pull request 25985
[https://github.com/apache/spark/pull/25985]

> TestMemoryManager should implement getExecutionMemoryUsageForTask()
> -------------------------------------------------------------------
>
>                 Key: SPARK-29310
>                 URL: https://issues.apache.org/jira/browse/SPARK-29310
>             Project: Spark
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 3.0.0
>            Reporter: Josh Rosen
>            Assignee: Josh Rosen
>            Priority: Major
>             Fix For: 3.0.0
>
>
> Spark uses a {{TestMemoryManager}} class to mock out memory manager functionality in tests, allowing test authors to exercise control over certain behaviors (e.g. to simulate OOMs).
> Our tests have memory-leak detection to ensure that all allocated memory is cleaned up at the end of each test case; this helps to guard against bugs that could cause production memory leaks.
> Unfortunately, however, this leak-detection logic is broken for tests which use {{TestMemoryManager}} because it does not override the {{getExecutionMemoryUsageForTask()}} method which the leak-detection mechanism needs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org