You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/02 08:24:54 UTC

[GitHub] [dubbo] AlbumenJ opened a new pull request #8662: Add 3.0 Multi Instance Support

AlbumenJ opened a new pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662


   ## What is the purpose of the change
   
   
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-911459733


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8662](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a68aee9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/b8de0a7fd505a438b35e0db2a3e660aed33784dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8de0a7) will **increase** coverage by `0.11%`.
   > The diff coverage is `72.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8662/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8662      +/-   ##
   ============================================
   + Coverage     63.49%   63.61%   +0.11%     
     Complexity      312      312              
   ============================================
     Files          1121     1138      +17     
     Lines         46975    47607     +632     
     Branches       7093     7157      +64     
   ============================================
   + Hits          29829    30283     +454     
   - Misses        13846    14003     +157     
   - Partials       3300     3321      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL0ZpbHRlckNoYWluQnVpbGRlci5qYXZh) | `56.52% <ø> (ø)` | |
   | [...c/cluster/governance/GovernanceRuleRepository.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZ292ZXJuYW5jZS9Hb3Zlcm5hbmNlUnVsZVJlcG9zaXRvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...o/rpc/cluster/support/wrapper/AbstractCluster.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL0Fic3RyYWN0Q2x1c3Rlci5qYXZh) | `22.36% <0.00%> (ø)` | |
   | [.../apache/dubbo/common/beans/ScopeBeanException.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...mon/beans/factory/ScopeBeanFactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvZmFjdG9yeS9TY29wZUJlYW5GYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/convert/Converter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9Db252ZXJ0ZXIuamF2YQ==) | `76.92% <ø> (ø)` | |
   | [...o/common/convert/multiple/MultiValueConverter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9tdWx0aXBsZS9NdWx0aVZhbHVlQ29udmVydGVyLmphdmE=) | `58.33% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVnaXN0cnlDb25maWcuamF2YQ==) | `91.12% <ø> (ø)` | |
   | [...org/apache/dubbo/rpc/model/ScopeModelAccessor.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbEFjY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [202 more](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b8de0a7...a68aee9](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-911480360


   ReferenceConfig.java
   ```
   // TODO, uncomment this line once service key is unified
   serviceMetadata.setServiceKey(URL.buildKey(interfaceName, group, version));
   ```
   一个工程如果有多个Reference引用同一个服务接口，配置的回调onXXX各自不同，ReferenceConfig只存一份consumerModel是搞不定的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-911459733


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8662](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a68aee9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/b8de0a7fd505a438b35e0db2a3e660aed33784dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8de0a7) will **increase** coverage by `0.09%`.
   > The diff coverage is `72.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8662/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8662      +/-   ##
   ============================================
   + Coverage     63.49%   63.59%   +0.09%     
     Complexity      312      312              
   ============================================
     Files          1121     1138      +17     
     Lines         46975    47607     +632     
     Branches       7093     7157      +64     
   ============================================
   + Hits          29829    30274     +445     
   - Misses        13846    14011     +165     
   - Partials       3300     3322      +22     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL0ZpbHRlckNoYWluQnVpbGRlci5qYXZh) | `56.52% <ø> (ø)` | |
   | [...c/cluster/governance/GovernanceRuleRepository.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZ292ZXJuYW5jZS9Hb3Zlcm5hbmNlUnVsZVJlcG9zaXRvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...o/rpc/cluster/support/wrapper/AbstractCluster.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL0Fic3RyYWN0Q2x1c3Rlci5qYXZh) | `22.36% <0.00%> (ø)` | |
   | [.../apache/dubbo/common/beans/ScopeBeanException.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...mon/beans/factory/ScopeBeanFactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvZmFjdG9yeS9TY29wZUJlYW5GYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/convert/Converter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9Db252ZXJ0ZXIuamF2YQ==) | `76.92% <ø> (ø)` | |
   | [...o/common/convert/multiple/MultiValueConverter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9tdWx0aXBsZS9NdWx0aVZhbHVlQ29udmVydGVyLmphdmE=) | `58.33% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVnaXN0cnlDb25maWcuamF2YQ==) | `91.12% <ø> (ø)` | |
   | [...org/apache/dubbo/rpc/model/ScopeModelAccessor.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbEFjY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [202 more](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b8de0a7...a68aee9](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-911459733


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8662](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a68aee9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/b8de0a7fd505a438b35e0db2a3e660aed33784dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8de0a7) will **decrease** coverage by `0.08%`.
   > The diff coverage is `72.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8662/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8662      +/-   ##
   ============================================
   - Coverage     63.49%   63.41%   -0.09%     
   + Complexity      312      311       -1     
   ============================================
     Files          1121     1138      +17     
     Lines         46975    47561     +586     
     Branches       7093     7122      +29     
   ============================================
   + Hits          29829    30160     +331     
   - Misses        13846    14065     +219     
   - Partials       3300     3336      +36     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL0ZpbHRlckNoYWluQnVpbGRlci5qYXZh) | `56.52% <ø> (ø)` | |
   | [...c/cluster/governance/GovernanceRuleRepository.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZ292ZXJuYW5jZS9Hb3Zlcm5hbmNlUnVsZVJlcG9zaXRvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...o/rpc/cluster/support/wrapper/AbstractCluster.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL0Fic3RyYWN0Q2x1c3Rlci5qYXZh) | `22.36% <0.00%> (ø)` | |
   | [.../apache/dubbo/common/beans/ScopeBeanException.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...mon/beans/factory/ScopeBeanFactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvZmFjdG9yeS9TY29wZUJlYW5GYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/convert/Converter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9Db252ZXJ0ZXIuamF2YQ==) | `76.92% <ø> (ø)` | |
   | [...o/common/convert/multiple/MultiValueConverter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9tdWx0aXBsZS9NdWx0aVZhbHVlQ29udmVydGVyLmphdmE=) | `58.33% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVnaXN0cnlDb25maWcuamF2YQ==) | `91.12% <ø> (ø)` | |
   | [...org/apache/dubbo/rpc/model/ScopeModelAccessor.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbEFjY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [242 more](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b8de0a7...a68aee9](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-911459733


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8662](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a68aee9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/b8de0a7fd505a438b35e0db2a3e660aed33784dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8de0a7) will **increase** coverage by `0.08%`.
   > The diff coverage is `72.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8662/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8662      +/-   ##
   ============================================
   + Coverage     63.49%   63.58%   +0.08%     
     Complexity      312      312              
   ============================================
     Files          1121     1138      +17     
     Lines         46975    47607     +632     
     Branches       7093     7157      +64     
   ============================================
   + Hits          29829    30271     +442     
   - Misses        13846    14012     +166     
   - Partials       3300     3324      +24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL0ZpbHRlckNoYWluQnVpbGRlci5qYXZh) | `56.52% <ø> (ø)` | |
   | [...c/cluster/governance/GovernanceRuleRepository.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZ292ZXJuYW5jZS9Hb3Zlcm5hbmNlUnVsZVJlcG9zaXRvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...o/rpc/cluster/support/wrapper/AbstractCluster.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL0Fic3RyYWN0Q2x1c3Rlci5qYXZh) | `22.36% <0.00%> (ø)` | |
   | [.../apache/dubbo/common/beans/ScopeBeanException.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvU2NvcGVCZWFuRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...mon/beans/factory/ScopeBeanFactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnMvZmFjdG9yeS9TY29wZUJlYW5GYWN0b3J5SW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/common/convert/Converter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9Db252ZXJ0ZXIuamF2YQ==) | `76.92% <ø> (ø)` | |
   | [...o/common/convert/multiple/MultiValueConverter.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9tdWx0aXBsZS9NdWx0aVZhbHVlQ29udmVydGVyLmphdmE=) | `58.33% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVnaXN0cnlDb25maWcuamF2YQ==) | `91.12% <ø> (ø)` | |
   | [...org/apache/dubbo/rpc/model/ScopeModelAccessor.java](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbEFjY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [202 more](https://codecov.io/gh/apache/dubbo/pull/8662/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b8de0a7...a68aee9](https://codecov.io/gh/apache/dubbo/pull/8662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-912357185


   做了一下3.0多实例的同一接口多引用测试， 测试结果很完美，测试代码见 #8670  
   非常期待早日发布具备同样功能的2.7.14！ #8567 和 #8602 两个问题就可以关掉啦


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on pull request #8662: Add 3.0 Multi Instance Support

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on pull request #8662:
URL: https://github.com/apache/dubbo/pull/8662#issuecomment-911525589


   > ReferenceConfig.java
   > 
   > ```
   > // TODO, uncomment this line once service key is unified
   > serviceMetadata.setServiceKey(URL.buildKey(interfaceName, group, version));
   > ```
   > 
   > 一个工程如果有多个Reference引用同一个服务接口，配置的回调onXXX各自不同，ReferenceConfig只存一份consumerModel是搞不定的
   
   这个 PR 只是基础代码，最后的版本多个 ReferenceConfig 之间可以独立工作


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org