You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Thomas Andraschko <zo...@gmail.com> on 2012/09/15 18:26:58 UTC
Eclipse/Checkstyle errors
Hi,
we have many checkstyle errors (not warnings) in the test classes.
Can i fix them or should i exclude (don't know if possible in Eclipse) the
test classes from checkstyle?
The most errors are "{ should be on a new line" and naming errors of
constants and variables.
Also i have many eclipse errors that @PostConstruct, @PreDestory,
@WebServiceRef etc are not accessible.
Can we add this APIs with provided scope or is there any better solution?
Regards,
Thomas
Re: Eclipse/Checkstyle errors
Posted by Romain Manni-Bucau <rm...@gmail.com>.
We can filter them http://checkstyle.sourceforge.net/config.html#Filters
Le 15 sept. 2012 20:09, "Thomas Andraschko" <zo...@gmail.com> a écrit :
> I use the same rules as the maven plugin, you must just import the
> settings.
> The problem is that maven-checkstyle-plugin does not check the test-src but
> eclipse does (per default).
>
> So what do you think? should we fix this errors or should the developers
> exclude test classes?
>
> 2012/9/15 Joseph Bergmark <be...@apache.org>
>
> > I haven't used the checkstyle plugin for Eclipse, so afraid I can't
> > provide much advice here. Its too bad it doesn't appear to follow the
> > same rules as the maven plugin.
> >
> > Sincerely,
> >
> > Joe
> >
> > On Sat, Sep 15, 2012 at 1:15 PM, Thomas Andraschko <zo...@gmail.com>
> > wrote:
> > > It's only in test-classes because the won't be checked by maven.
> > > For example -> AbstractUnitTest#addExtension
> > >
> > > 2012/9/15 Joseph Bergmark <be...@apache.org>
> > >
> > >> Which test classes are you getting check style errors in? When I
> > >> build on the command line I don't see any check style errors:
> > >>
> > >> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
> > >> openwebbeans-web ---
> > >> [INFO]
> > >> [INFO]
> > >>
> > >>
> > >> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
> > >> openwebbeans-impl ---
> > >> [INFO]
> > >> [INFO]
> > >>
> > >> etc..
> > >>
> > >> Sincerely,
> > >>
> > >> Joe
> > >>
> > >> On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zoigln@gmail.com
> >
> > >> wrote:
> > >> > Hi,
> > >> >
> > >> > we have many checkstyle errors (not warnings) in the test classes.
> > >> > Can i fix them or should i exclude (don't know if possible in
> Eclipse)
> > >> the
> > >> > test classes from checkstyle?
> > >> > The most errors are "{ should be on a new line" and naming errors of
> > >> > constants and variables.
> > >> >
> > >> > Also i have many eclipse errors that @PostConstruct, @PreDestory,
> > >> > @WebServiceRef etc are not accessible.
> > >> > Can we add this APIs with provided scope or is there any better
> > solution?
> > >> >
> > >> > Regards,
> > >> > Thomas
> > >>
> >
>
Re: Eclipse/Checkstyle errors
Posted by Romain Manni-Bucau <rm...@gmail.com>.
If it bothers you add the ignore section for now.1.1.6 is expected adap
Le 16 sept. 2012 19:32, "Thomas Andraschko" <zo...@gmail.com> a écrit :
> all right! And what about the checkstyle errors?
>
> 2012/9/16 Mark Struberg <st...@yahoo.de>
>
> > yes, we had requests from _huge_ users running old WAS on mainframes.
> > Among those are big stock exchanges, banks and a big western defence
> pact...
> >
> >
> >
> >
> >
> > ----- Original Message -----
> > > From: Romain Manni-Bucau <rm...@gmail.com>
> > > To: dev@openwebbeans.apache.org
> > > Cc:
> > > Sent: Sunday, September 16, 2012 12:15 PM
> > > Subject: Re: Eclipse/Checkstyle errors
> > >
> > > for checkstyle fix them if you activate it in mvn build otherwise i
> fear
> > > some of us will not check it (i know i'm part of them)
> > >
> > > about @Override: do we still target j5?
> > >
> > > *Romain Manni-Bucau*
> > > *Twitter: @rmannibucau*
> > > *Blog: http://rmannibucau.wordpress.com*
> > >
> > >
> > >
> > >
> > > 2012/9/16 Thomas Andraschko <zo...@gmail.com>
> > >
> > >> I would fix it, that's no problem.
> > >>
> > >> We also have many compiler warnings because sometimes @Override is
> > used for
> > >> implemented methods in test classes, which is not compatible to Java
> > 1.5.
> > >>
> > >> Could i create tickets for @Override and checkstyle errors in
> > test-classes?
> > >> I would fix them for 1.1.7.
> > >>
> > >> 2012/9/15 David Jencks <da...@yahoo.com>
> > >>
> > >> > My opinion as a pretty much completely inactive contributor to OWB
> is
> > >> that
> > >> > it would be better to have the test classes follow the same style
> > > rules
> > >> as
> > >> > the main code, but I'm not prepared to help fix it.
> > >> >
> > >> > thanks
> > >> > david jencks
> > >> >
> > >>
> > >
> >
>
Re: Eclipse/Checkstyle errors
Posted by Thomas Andraschko <zo...@gmail.com>.
all right! And what about the checkstyle errors?
2012/9/16 Mark Struberg <st...@yahoo.de>
> yes, we had requests from _huge_ users running old WAS on mainframes.
> Among those are big stock exchanges, banks and a big western defence pact...
>
>
>
>
>
> ----- Original Message -----
> > From: Romain Manni-Bucau <rm...@gmail.com>
> > To: dev@openwebbeans.apache.org
> > Cc:
> > Sent: Sunday, September 16, 2012 12:15 PM
> > Subject: Re: Eclipse/Checkstyle errors
> >
> > for checkstyle fix them if you activate it in mvn build otherwise i fear
> > some of us will not check it (i know i'm part of them)
> >
> > about @Override: do we still target j5?
> >
> > *Romain Manni-Bucau*
> > *Twitter: @rmannibucau*
> > *Blog: http://rmannibucau.wordpress.com*
> >
> >
> >
> >
> > 2012/9/16 Thomas Andraschko <zo...@gmail.com>
> >
> >> I would fix it, that's no problem.
> >>
> >> We also have many compiler warnings because sometimes @Override is
> used for
> >> implemented methods in test classes, which is not compatible to Java
> 1.5.
> >>
> >> Could i create tickets for @Override and checkstyle errors in
> test-classes?
> >> I would fix them for 1.1.7.
> >>
> >> 2012/9/15 David Jencks <da...@yahoo.com>
> >>
> >> > My opinion as a pretty much completely inactive contributor to OWB is
> >> that
> >> > it would be better to have the test classes follow the same style
> > rules
> >> as
> >> > the main code, but I'm not prepared to help fix it.
> >> >
> >> > thanks
> >> > david jencks
> >> >
> >>
> >
>
Re: Eclipse/Checkstyle errors
Posted by Mark Struberg <st...@yahoo.de>.
yes, we had requests from _huge_ users running old WAS on mainframes. Among those are big stock exchanges, banks and a big western defence pact...
----- Original Message -----
> From: Romain Manni-Bucau <rm...@gmail.com>
> To: dev@openwebbeans.apache.org
> Cc:
> Sent: Sunday, September 16, 2012 12:15 PM
> Subject: Re: Eclipse/Checkstyle errors
>
> for checkstyle fix them if you activate it in mvn build otherwise i fear
> some of us will not check it (i know i'm part of them)
>
> about @Override: do we still target j5?
>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau*
> *Blog: http://rmannibucau.wordpress.com*
>
>
>
>
> 2012/9/16 Thomas Andraschko <zo...@gmail.com>
>
>> I would fix it, that's no problem.
>>
>> We also have many compiler warnings because sometimes @Override is used for
>> implemented methods in test classes, which is not compatible to Java 1.5.
>>
>> Could i create tickets for @Override and checkstyle errors in test-classes?
>> I would fix them for 1.1.7.
>>
>> 2012/9/15 David Jencks <da...@yahoo.com>
>>
>> > My opinion as a pretty much completely inactive contributor to OWB is
>> that
>> > it would be better to have the test classes follow the same style
> rules
>> as
>> > the main code, but I'm not prepared to help fix it.
>> >
>> > thanks
>> > david jencks
>> >
>>
>
Re: Eclipse/Checkstyle errors
Posted by Romain Manni-Bucau <rm...@gmail.com>.
for checkstyle fix them if you activate it in mvn build otherwise i fear
some of us will not check it (i know i'm part of them)
about @Override: do we still target j5?
*Romain Manni-Bucau*
*Twitter: @rmannibucau*
*Blog: http://rmannibucau.wordpress.com*
2012/9/16 Thomas Andraschko <zo...@gmail.com>
> I would fix it, that's no problem.
>
> We also have many compiler warnings because sometimes @Override is used for
> implemented methods in test classes, which is not compatible to Java 1.5.
>
> Could i create tickets for @Override and checkstyle errors in test-classes?
> I would fix them for 1.1.7.
>
> 2012/9/15 David Jencks <da...@yahoo.com>
>
> > My opinion as a pretty much completely inactive contributor to OWB is
> that
> > it would be better to have the test classes follow the same style rules
> as
> > the main code, but I'm not prepared to help fix it.
> >
> > thanks
> > david jencks
> >
>
Re: Eclipse/Checkstyle errors
Posted by Mark Struberg <st...@yahoo.de>.
please let those for now.
we originally had java 6 as target.
But due to some customer requests we switched to java 5 for building.
I propose to require java6 ++ for owb-1.2 ++
LieGrue,
strub
----- Original Message -----
> From: Thomas Andraschko <zo...@gmail.com>
> To: dev@openwebbeans.apache.org
> Cc:
> Sent: Sunday, September 16, 2012 12:11 PM
> Subject: Re: Eclipse/Checkstyle errors
>
> I would fix it, that's no problem.
>
> We also have many compiler warnings because sometimes @Override is used for
> implemented methods in test classes, which is not compatible to Java 1.5.
>
> Could i create tickets for @Override and checkstyle errors in test-classes?
> I would fix them for 1.1.7.
>
> 2012/9/15 David Jencks <da...@yahoo.com>
>
>> My opinion as a pretty much completely inactive contributor to OWB is that
>> it would be better to have the test classes follow the same style rules as
>> the main code, but I'm not prepared to help fix it.
>>
>> thanks
>> david jencks
>>
>
Re: Eclipse/Checkstyle errors
Posted by Thomas Andraschko <zo...@gmail.com>.
I would fix it, that's no problem.
We also have many compiler warnings because sometimes @Override is used for
implemented methods in test classes, which is not compatible to Java 1.5.
Could i create tickets for @Override and checkstyle errors in test-classes?
I would fix them for 1.1.7.
2012/9/15 David Jencks <da...@yahoo.com>
> My opinion as a pretty much completely inactive contributor to OWB is that
> it would be better to have the test classes follow the same style rules as
> the main code, but I'm not prepared to help fix it.
>
> thanks
> david jencks
>
Re: Eclipse/Checkstyle errors
Posted by David Jencks <da...@yahoo.com>.
My opinion as a pretty much completely inactive contributor to OWB is that it would be better to have the test classes follow the same style rules as the main code, but I'm not prepared to help fix it.
thanks
david jencks
On Sep 15, 2012, at 11:09 AM, Thomas Andraschko wrote:
> I use the same rules as the maven plugin, you must just import the settings.
> The problem is that maven-checkstyle-plugin does not check the test-src but
> eclipse does (per default).
>
> So what do you think? should we fix this errors or should the developers
> exclude test classes?
>
> 2012/9/15 Joseph Bergmark <be...@apache.org>
>
>> I haven't used the checkstyle plugin for Eclipse, so afraid I can't
>> provide much advice here. Its too bad it doesn't appear to follow the
>> same rules as the maven plugin.
>>
>> Sincerely,
>>
>> Joe
>>
>> On Sat, Sep 15, 2012 at 1:15 PM, Thomas Andraschko <zo...@gmail.com>
>> wrote:
>>> It's only in test-classes because the won't be checked by maven.
>>> For example -> AbstractUnitTest#addExtension
>>>
>>> 2012/9/15 Joseph Bergmark <be...@apache.org>
>>>
>>>> Which test classes are you getting check style errors in? When I
>>>> build on the command line I don't see any check style errors:
>>>>
>>>> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>>>> openwebbeans-web ---
>>>> [INFO]
>>>> [INFO]
>>>>
>>>>
>>>> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>>>> openwebbeans-impl ---
>>>> [INFO]
>>>> [INFO]
>>>>
>>>> etc..
>>>>
>>>> Sincerely,
>>>>
>>>> Joe
>>>>
>>>> On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zo...@gmail.com>
>>>> wrote:
>>>>> Hi,
>>>>>
>>>>> we have many checkstyle errors (not warnings) in the test classes.
>>>>> Can i fix them or should i exclude (don't know if possible in Eclipse)
>>>> the
>>>>> test classes from checkstyle?
>>>>> The most errors are "{ should be on a new line" and naming errors of
>>>>> constants and variables.
>>>>>
>>>>> Also i have many eclipse errors that @PostConstruct, @PreDestory,
>>>>> @WebServiceRef etc are not accessible.
>>>>> Can we add this APIs with provided scope or is there any better
>> solution?
>>>>>
>>>>> Regards,
>>>>> Thomas
>>>>
>>
Re: Eclipse/Checkstyle errors
Posted by Thomas Andraschko <zo...@gmail.com>.
I use the same rules as the maven plugin, you must just import the settings.
The problem is that maven-checkstyle-plugin does not check the test-src but
eclipse does (per default).
So what do you think? should we fix this errors or should the developers
exclude test classes?
2012/9/15 Joseph Bergmark <be...@apache.org>
> I haven't used the checkstyle plugin for Eclipse, so afraid I can't
> provide much advice here. Its too bad it doesn't appear to follow the
> same rules as the maven plugin.
>
> Sincerely,
>
> Joe
>
> On Sat, Sep 15, 2012 at 1:15 PM, Thomas Andraschko <zo...@gmail.com>
> wrote:
> > It's only in test-classes because the won't be checked by maven.
> > For example -> AbstractUnitTest#addExtension
> >
> > 2012/9/15 Joseph Bergmark <be...@apache.org>
> >
> >> Which test classes are you getting check style errors in? When I
> >> build on the command line I don't see any check style errors:
> >>
> >> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
> >> openwebbeans-web ---
> >> [INFO]
> >> [INFO]
> >>
> >>
> >> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
> >> openwebbeans-impl ---
> >> [INFO]
> >> [INFO]
> >>
> >> etc..
> >>
> >> Sincerely,
> >>
> >> Joe
> >>
> >> On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zo...@gmail.com>
> >> wrote:
> >> > Hi,
> >> >
> >> > we have many checkstyle errors (not warnings) in the test classes.
> >> > Can i fix them or should i exclude (don't know if possible in Eclipse)
> >> the
> >> > test classes from checkstyle?
> >> > The most errors are "{ should be on a new line" and naming errors of
> >> > constants and variables.
> >> >
> >> > Also i have many eclipse errors that @PostConstruct, @PreDestory,
> >> > @WebServiceRef etc are not accessible.
> >> > Can we add this APIs with provided scope or is there any better
> solution?
> >> >
> >> > Regards,
> >> > Thomas
> >>
>
Re: Eclipse/Checkstyle errors
Posted by Joseph Bergmark <be...@apache.org>.
I haven't used the checkstyle plugin for Eclipse, so afraid I can't
provide much advice here. Its too bad it doesn't appear to follow the
same rules as the maven plugin.
Sincerely,
Joe
On Sat, Sep 15, 2012 at 1:15 PM, Thomas Andraschko <zo...@gmail.com> wrote:
> It's only in test-classes because the won't be checked by maven.
> For example -> AbstractUnitTest#addExtension
>
> 2012/9/15 Joseph Bergmark <be...@apache.org>
>
>> Which test classes are you getting check style errors in? When I
>> build on the command line I don't see any check style errors:
>>
>> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>> openwebbeans-web ---
>> [INFO]
>> [INFO]
>>
>>
>> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>> openwebbeans-impl ---
>> [INFO]
>> [INFO]
>>
>> etc..
>>
>> Sincerely,
>>
>> Joe
>>
>> On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zo...@gmail.com>
>> wrote:
>> > Hi,
>> >
>> > we have many checkstyle errors (not warnings) in the test classes.
>> > Can i fix them or should i exclude (don't know if possible in Eclipse)
>> the
>> > test classes from checkstyle?
>> > The most errors are "{ should be on a new line" and naming errors of
>> > constants and variables.
>> >
>> > Also i have many eclipse errors that @PostConstruct, @PreDestory,
>> > @WebServiceRef etc are not accessible.
>> > Can we add this APIs with provided scope or is there any better solution?
>> >
>> > Regards,
>> > Thomas
>>
Re: Eclipse/Checkstyle errors
Posted by Thomas Andraschko <zo...@gmail.com>.
It's only in test-classes because the won't be checked by maven.
For example -> AbstractUnitTest#addExtension
2012/9/15 Joseph Bergmark <be...@apache.org>
> Which test classes are you getting check style errors in? When I
> build on the command line I don't see any check style errors:
>
> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
> openwebbeans-web ---
> [INFO]
> [INFO]
>
>
> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
> openwebbeans-impl ---
> [INFO]
> [INFO]
>
> etc..
>
> Sincerely,
>
> Joe
>
> On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zo...@gmail.com>
> wrote:
> > Hi,
> >
> > we have many checkstyle errors (not warnings) in the test classes.
> > Can i fix them or should i exclude (don't know if possible in Eclipse)
> the
> > test classes from checkstyle?
> > The most errors are "{ should be on a new line" and naming errors of
> > constants and variables.
> >
> > Also i have many eclipse errors that @PostConstruct, @PreDestory,
> > @WebServiceRef etc are not accessible.
> > Can we add this APIs with provided scope or is there any better solution?
> >
> > Regards,
> > Thomas
>
Re: Eclipse/Checkstyle errors
Posted by Joseph Bergmark <be...@apache.org>.
Which test classes are you getting check style errors in? When I
build on the command line I don't see any check style errors:
[INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
openwebbeans-web ---
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
openwebbeans-impl ---
[INFO]
[INFO]
etc..
Sincerely,
Joe
On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zo...@gmail.com> wrote:
> Hi,
>
> we have many checkstyle errors (not warnings) in the test classes.
> Can i fix them or should i exclude (don't know if possible in Eclipse) the
> test classes from checkstyle?
> The most errors are "{ should be on a new line" and naming errors of
> constants and variables.
>
> Also i have many eclipse errors that @PostConstruct, @PreDestory,
> @WebServiceRef etc are not accessible.
> Can we add this APIs with provided scope or is there any better solution?
>
> Regards,
> Thomas