You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "wanghangyu817 (via GitHub)" <gi...@apache.org> on 2023/10/31 07:50:38 UTC
[PR] Added support for multiple Apache Doris [nifi]
wanghangyu817 opened a new pull request, #7959:
URL: https://github.com/apache/nifi/pull/7959
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-12296](https://issues.apache.org/jira/projects/NIFI/issues/NIFI-12296)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12296 Added support for multiple Apache Doris [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7959:
URL: https://github.com/apache/nifi/pull/7959#issuecomment-1794850911
@wanghangyu817 As the pull request has merge conflicts and is not passing the GitHub `ci-workflow` build, I am closing it for now. I recommend enabling the `ci-workflow` in your fork on GitHub and working on this feature in a separate branch. Once you have a passing build, you can merge your changes into a single commit to prepare for the initial review. If you have any questions, feel free to raise them on the associated Jira issue or in the dev channel on Apache NiFi Slack. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12296 Added support for multiple Apache Doris [nifi]
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7959:
URL: https://github.com/apache/nifi/pull/7959#issuecomment-1793904373
Does this approach offer capabilities that a user cannot get by using a MySQL client?
Also it looks like your PR is a little out of whack in terms of conflicts, merge commits, etc. I recommend checking out a "feature branch" instead of working from your fork of the `main` branch. Then you can rebase your `main` branch against the Apache NiFi one, and rebase your feature branch against that. It helps avoid merge commits, conflicts, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12296 Added support for multiple Apache Doris [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7959: NIFI-12296 Added support for multiple Apache Doris
URL: https://github.com/apache/nifi/pull/7959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org