You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/12 21:29:16 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #464: [YUNIKORN-1324] Plugin: Disable PodDisruptionBudget feature gate to allow scheduling on K8s 1.25
craigcondit opened a new pull request, #464:
URL: https://github.com/apache/yunikorn-k8shim/pull/464
### What is this PR for?
The plugin implementation in the shim does not startup completely on K8s 1.25 due to initialization of a PodDisruptionBudget informer, which cannot work on K8s 1.25. Disabling this feature allows the scheduler to function properly.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1324
### How should this be tested?
Existing e2e tests should cover this.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #464: [YUNIKORN-1324] Plugin: Disable PodDisruptionBudget feature gate to allow scheduling on K8s 1.25
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #464:
URL: https://github.com/apache/yunikorn-k8shim/pull/464#issuecomment-1244526733
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#464](https://codecov.io/gh/apache/yunikorn-k8shim/pull/464?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d83d28f) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/9fc4e9198544ba32723c65943f1088d41a30fe98?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9fc4e91) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #464 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 41 41
Lines 6767 6767
=======================================
Hits 4534 4534
Misses 2062 2062
Partials 171 171
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #464: [YUNIKORN-1324] Plugin: Disable PodDisruptionBudget feature gate to allow scheduling on K8s 1.25
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #464: [YUNIKORN-1324] Plugin: Disable PodDisruptionBudget feature gate to allow scheduling on K8s 1.25
URL: https://github.com/apache/yunikorn-k8shim/pull/464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org