[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1253: [HUDI-558] Introduce ability to compress bloom filters while storing in parquet

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #1253: [HUDI-558] Introduce ability to compress bloom filters while storing in parquet
URL: https://github.com/apache/incubator-hudi/pull/1253#discussion_r372198618
 
 

 ##########
 File path: hudi-common/src/test/java/org/apache/hudi/common/util/TestParquetUtils.java
 ##########
 @@ -132,7 +132,7 @@ private void writeParquetFile(String filePath, List<String> rowKeys) throws Exce
     BloomFilter filter = BloomFilterFactory
         .createBloomFilter(1000, 0.0001, 10000, bloomFilterTypeToTest);
     HoodieAvroWriteSupport writeSupport =
-        new HoodieAvroWriteSupport(new AvroSchemaConverter().convert(schema), schema, filter);
+        new HoodieAvroWriteSupport(new AvroSchemaConverter().convert(schema), schema, filter, false);
 
 Review comment:
   don't we need to test both true and false? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services