You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/05/08 07:34:44 UTC

[GitHub] [openwhisk] KeonHee opened a new pull request #4898: Change AcknowledegmentMessage interface

KeonHee opened a new pull request #4898:
URL: https://github.com/apache/openwhisk/pull/4898


   ## Description
   1. `instanceType` json field added
       - It is necessary when another component is added to distinguish json values of invoker and controller.
   2. Add test case for serde `InstanceId`
   3. Change `AcknowledegmentMessage` interface
       - The `AcknowledegmentMessage` may not always respond to the invoker
   
   
   ## Related issue and scope
   no related issue
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [x] Controller
   - [x] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] rabbah commented on pull request #4898: Change AcknowledegmentMessage interface

Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #4898:
URL: https://github.com/apache/openwhisk/pull/4898#issuecomment-625798699


   hi @KeonHee can you expand on the need for this change? What components are you adding that are not "invokers" but which are sending ack messages?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 merged pull request #4898: Change AcknowledegmentMessage interface

Posted by GitBox <gi...@apache.org>.
style95 merged pull request #4898:
URL: https://github.com/apache/openwhisk/pull/4898


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk] style95 commented on a change in pull request #4898: Change AcknowledegmentMessage interface

Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #4898:
URL: https://github.com/apache/openwhisk/pull/4898#discussion_r426359359



##########
File path: core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/CommonLoadBalancer.scala
##########
@@ -283,7 +288,7 @@ abstract class CommonLoadBalancer(config: WhiskConfig,
         totalActivationMemory.add(entry.memoryLimit.toMB * (-1))
         activationsPerNamespace.get(entry.namespaceId).foreach(_.decrement())
 
-        releaseInvoker(invoker, entry)
+        invoker.foreach(releaseInvoker(_, entry))

Review comment:
       👍 
   
   If this is to use some methods of `CommonLoadBalancer` in the downstream, isn't there any other methods to be updated as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org