You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/02/28 18:44:30 UTC
[GitHub] [cassandra-sidecar] rustyrazorblade opened a new pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
rustyrazorblade opened a new pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6
…a 11 support.
* Upgrading from findbugs (JDK 8 only) to Spotbugs. FindBugs was abandoned
years ago and will not be updated.
* Pinned the transitive Guava dependency to version 28-2.re.
* Upgraded the DataStax driver to version 3.8
* Upgraded Gradle to version 6.2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
dineshjoshi commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385949677
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
Review comment:
Simulacron has some issues with 3.8 driver. Can we stay with the 3.6? The integration tests failed with 3.8 but downgrading to 3.6 worked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
dineshjoshi commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385976692
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
compile group: 'com.google.inject', name: 'guice', version: '4.2.2'
compile group: 'org.apache.commons', name: 'commons-configuration2', version: '2.4'
+ compile(group: 'com.google.guava', name: 'guava', version: '28.2-jre') {
Review comment:
I understand. I would like to take a conservative approach in upgrading guava. Here's my concern -
```
+--- com.datastax.cassandra:cassandra-driver-core:3.6+ -> 3.6.0
| +--- io.netty:netty-handler:4.0.56.Final -> 4.1.30.Final (*)
| +--- com.google.guava:guava:19.0 -> 28.2-jre
| | +--- com.google.guava:failureaccess:1.0.1
| | +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
```
This might actually break the driver. So, ideally we should go to a driver that supports Guava 28. Right now v3.8 of the driver seems to be breaking the integration tests so we cannot upgrade that. Let's address this as a follow up ticket?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] dineshjoshi commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
dineshjoshi commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385949515
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
compile group: 'com.google.inject', name: 'guice', version: '4.2.2'
compile group: 'org.apache.commons', name: 'commons-configuration2', version: '2.4'
+ compile(group: 'com.google.guava', name: 'guava', version: '28.2-jre') {
Review comment:
We don't need this. The guava version update in the buildscript is sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385950906
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
Review comment:
Yeah, we can roll this back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] rustyrazorblade closed pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
rustyrazorblade closed pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385954706
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
compile group: 'com.google.inject', name: 'guice', version: '4.2.2'
compile group: 'org.apache.commons', name: 'commons-configuration2', version: '2.4'
+ compile(group: 'com.google.guava', name: 'guava', version: '28.2-jre') {
Review comment:
For reference on the Guava side: https://github.com/google/guava/issues/3272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385976914
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
compile group: 'com.google.inject', name: 'guice', version: '4.2.2'
compile group: 'org.apache.commons', name: 'commons-configuration2', version: '2.4'
+ compile(group: 'com.google.guava', name: 'guava', version: '28.2-jre') {
Review comment:
Fair enough, I'll update my branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385955331
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
compile group: 'com.google.inject', name: 'guice', version: '4.2.2'
compile group: 'org.apache.commons', name: 'commons-configuration2', version: '2.4'
+ compile(group: 'com.google.guava', name: 'guava', version: '28.2-jre') {
Review comment:
Here's the buildscan of the dependency tree if I remove the explicit Guava block:
when I build it with the forced guava version:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
Posted by GitBox <gi...@apache.org>.
rustyrazorblade commented on a change in pull request #6: CASSANDRA-15610 Upgraded gradle dependencies, some of which are blockers for full jav…
URL: https://github.com/apache/cassandra-sidecar/pull/6#discussion_r385954608
##########
File path: build.gradle
##########
@@ -73,10 +85,15 @@ dependencies {
compile 'org.slf4j:slf4j-api:1.7.25'
compile 'ch.qos.logback:logback-core:1.2.3'
compile 'ch.qos.logback:logback-classic:1.2.3'
- compile 'com.datastax.cassandra:cassandra-driver-core:3.6+'
+
+ compile 'com.datastax.cassandra:cassandra-driver-core:3.8+'
compile group: 'com.google.inject', name: 'guice', version: '4.2.2'
compile group: 'org.apache.commons', name: 'commons-configuration2', version: '2.4'
+ compile(group: 'com.google.guava', name: 'guava', version: '28.2-jre') {
Review comment:
We still need it. Guava isn't JDK 11 compatible till version 27, and the buildscript block only affects the build tooling, not the artifacts. I've verified this locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org