You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "asafm (via GitHub)" <gi...@apache.org> on 2023/07/04 08:05:48 UTC
[GitHub] [pulsar] asafm opened a new issue, #20712: Add "pip" label automatically to a PR when adding file to PIP directory
asafm opened a new issue, #20712:
URL: https://github.com/apache/pulsar/issues/20712
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Motivation
When someone creates a new PR for a new PIP, they need to select a number.
Today they search for previous PIPs PRs based on text like "[pip]" but people forget to register that text in their title thus leading to numbering conflicts.
### Solution
There will be a GitHub workflow, which will detect if a PR contains a *new* file matching the pattern "pip*.md" and add the label "pip" to the PR.
Once we add "pip" label to previous PIP PRs, we can modify the search for previous PIPs listed [here](https://github.com/apache/pulsar/blob/master/pip/README.md) to be based on "pip" label, and type: PR.
### Alternatives
Using titles as described in motivation
### Anything else?
No
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #20712:
URL: https://github.com/apache/pulsar/issues/20712#issuecomment-1625677640
You would probably want to enhance - https://github.com/apache/pulsar-test-infra/tree/master/docbot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] asafm commented on issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on issue #20712:
URL: https://github.com/apache/pulsar/issues/20712#issuecomment-1628446968
Brilliant!
@tisonkun Would you be able to backfill the label for the ~8 PIPs PRs the already exists?
Once that's done, I'll submit a PR to modify the place to search for existing PRs (https://github.com/apache/pulsar/blob/master/pip/README.md) so it will be a search by PIP label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #20712:
URL: https://github.com/apache/pulsar/issues/20712#issuecomment-1619792720
Some thoughts -
* Labeler actions
* Filter by path filter actions and do arbitrary labeling with GitHub scripts
I'll investigate which one or other is better. Anyone who is familiar with this domain can leave a comment or take it over.
cc @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] asafm commented on issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on issue #20712:
URL: https://github.com/apache/pulsar/issues/20712#issuecomment-1619746712
@tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
URL: https://github.com/apache/pulsar/issues/20712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #20712: Add "pip" label automatically to a PR when adding file to PIP directory
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #20712:
URL: https://github.com/apache/pulsar/issues/20712#issuecomment-1627389891
@dave2wave I submit a patch - https://github.com/apache/pulsar/pull/20760
docbot is tightly coupled with PR description. It can be refactored to handle all traffic about PR labels later, but I'd prefer to use a mature action for achieving this request now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org