You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/11 22:21:18 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#8812: [filter_box] dashboard should carry defaultValue in filter_box
graceguo-supercat opened a new pull request #8812: [filter_box] dashboard should carry defaultValue in filter_box
URL: https://github.com/apache/incubator-superset/pull/8812
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [x] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
When user created a filter_box, they can set defaultValue for a field. When this filter is added to dashboard, we should carry defaultValue, and apply defaultValue to charts in dashboard.
Currently this defaultValue seems not carried to dashboard. So when user added a filter box with defaultValue to dashboard, they will see filter has pre-selected value, but dashboard didn't apply it.
### TEST PLAN
Ci and manual test
### REVIEWERS
@etr2460 @michellethomas @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org